1. 23 5月, 2015 1 次提交
  2. 22 5月, 2015 9 次提交
  3. 21 5月, 2015 19 次提交
    • T
      Merge pull request #2946 from tmeschter/Fix1579 · a5497dc3
      Tom Meschter 提交于
      Generate relative paths correctly.
      
      **Bug:** Fixes #1579.
      
      **Customer Scenario:**
      The customer wishes to use a shared rule set file in their project to control their diagnostics. The .ruleset file is at the root of their solution, so the customer adds it to their project as a linked file. They then set it as the active rule set by right-clicking on the file in Solution Explorer and selecting "Set as Active Rule Set".
      
      The file should become the active rule set for the project, turning various diagnostics on or off or altering their severity. Instead the customer gets an error in the Error List: "The file '..\\..\\..\\Rule.ruleset' cannot be found" and the rule set has no effect.
      
      **Fix:**
      When adding `..` to the relative path to backup to higher-level directories, we effectively add each one multiple times. The fix is to stop doing that.
      
      **Testing:**
      I manually tested the following variation on the original scenario:
      
      * Rule set file in the same directory as the project file
      * Rule set file one level above the project file
      * Rule set file two levels above the project file
      * Rule set file up two levels and then down in a subdirectory
      * Rule set file one level below the project file
      * Rule set file two levels below the project file
      * Rule set file on a different directory
      
      and verified that in each case the project file ends up with the correct path, and that the rule set takes effect as expected.
      
      I also added unit tests to exercise the affected code.
      a5497dc3
    • R
      Merge pull request #2967 from rchande/stabilization · b31b9ffa
      Ravi Chande 提交于
      Use a ConditionalWeakTable for SyntaxContext cache
      b31b9ffa
    • D
      Merge pull request #2947 from DustinCampbell/fix-2825-2 · 54e3c71f
      Dustin Campbell 提交于
      Fix Code Model bug with adding attributes in presence of XML doc comments
      54e3c71f
    • M
      Merge pull request #2939 from mavasani/IDEAnalyzerConcurrency · 900fbf7b
      Manish Vasani 提交于
      Guard against concurrent callbacks into analyzers in IDE
      
      Customer scenario: We need to do so for couple of scenarios:
      
      1. Different diagnostic clients might end up requesting diagnostics at the same time and hence end up attempting to invoke into the same analyzer simultaneously.
      
      
      2. FixAll occurrences computes diagnostics in parallel, hence can causes concurrent callbacks.
      
      If the analyzer hasn't been written in a thread-safe way, then concurrent callbacks into it can cause analyzers to produce incorrect/misleading/duplicate diagnostics or the analyzer itself might throw and never execute again in the VS session.
      
      Fixes #2410
      
      Testing: There is no functional change here, so existing tests provide adequate coverage. I manually verified that FixAll performance is acceptable for simplify name/remove unnecessary usings across projects/solution in Roslyn.sln
      
      Approved by MattGe.
      900fbf7b
    • A
      Ensure BoundLValueToRValueWrapper nodes are marked as compiler generated. · 96bc10ea
      AlekseyTs 提交于
      Fixes #2662.
      96bc10ea
    • R
      Use a ConditionalWeakTable for SyntaxContext cache · 55ee60e1
      Ravi Chande 提交于
      55ee60e1
    • N
      Merge pull request #2957 from gafter/fix2771-stabilization · 2773ce50
      Neal Gafter 提交于
      Make C# lexer resilient to binary data
      2773ce50
    • A
      Merge pull request #2937 from AlekseyTs/Issue2928 · 6e1d7a2d
      AlekseyTs 提交于
      Ensure anonymous types are always defined in a Global namespace.
      6e1d7a2d
    • A
      Merge pull request #2935 from AlekseyTs/Issue2640 · ea9b4f74
      AlekseyTs 提交于
      Optimize away BoundReferenceAssignment in StackScheduler if the assigned local isn't used.
      ea9b4f74
    • M
      Merge pull request #2933 from mattwar/Bug2832RTM · b1ab8ba3
      Matt Warren 提交于
      remove disposal logic from recoverable tree and text
      b1ab8ba3
    • M
      Merge pull request #2951 from mattwar/Bug2714 · dfc7b42f
      Matt Warren 提交于
      remove rule about no line between attributes
      dfc7b42f
    • N
      2573fe15
    • N
      Make lexer resilient to binary files as input · ea1fb754
      Neal Gafter 提交于
      Fixes #2771
      ea1fb754
    • T
      Merge pull request #2927 from tmat/EnCIPChange · 7ef2dfb7
      Tomáš Matoušek 提交于
      Fix errors reported intermittently when changing the current IP by drag & drop right after edit
      7ef2dfb7
    • J
      Merge pull request #2945 from jaredpar/fix-2630 · 3fecfe7e
      Jared Parsons 提交于
      Use correct count in ReplaceSeparator
      3fecfe7e
    • T
      Remove use of StringComparer.OrdinalIgnoreCase · 6935c155
      Tom Meschter 提交于
      These unit tests will now assert that casing is unchanged by
      `FilePathUtilities.GetRelativePath(...)`.
      6935c155
    • J
      Use correct count in ReplaceSeparator · b1c743fa
      Jared Parsons 提交于
      The bounds checking code for the existing separator has no need to do an
      upper bound check on `index`.  The IndexOf method will return -1 or a
      valid index into nodesWithSeps.  Hence the comparison with `this.Count`
      here was both unnecessary and incorrect (should have been
      `nodesWithSeps.Count`).
      
      closes #2630
      b1c743fa
    • T
      Generate relative paths correctly · a4ad4aef
      Tom Meschter 提交于
      The `FilePathUtilities.GetRelativePath(...)` method is used in various
      places in the Workspaces and VS layers to generate a relative path from
      a starting directory to a target file or directory. However, it has a
      bug where it will generate an incorrect path if you need to go up more
      than one level from the starting directory to get to the target.
      
      For example, if the starting directory is `C:\Alpha\Beta\Gamma` and the
      target is `C:\Alpha\SomeFile.txt`, the correct relative path would be
      `..\..\SomeFile.txt`. Instead, we get `..\..\..\SomeFile.txt` (note the
      extra `..`).
      
      This commit fixes the issue and adds unit tests for this method.
      a4ad4aef
    • M
      Remove commented-out code · 93e475dc
      Matt Warren 提交于
      93e475dc
  4. 20 5月, 2015 11 次提交