Factor MetadataWriter out of PeWriter. The MetadataWriter is responsible for serialization of metadata section and has a full and a delta version (FullMetadataWrtier, DeltaMetadataWriter).

We had a base PeWriter and two derived classes: FullPeWriter and DeltaPeWriter (for enc). We don’t wrap EnC deltas to PE format so it’s odd we have DeltaPeWriter that actually doesn’t write anything related to PE-COFF format.
 (changeset 1367838)

Revert change to Lexer and allow '[0-9]+#' identifiers but report a specific error that the syntax is no longer supported (changeset 1367796)

***NO_CI***
 (changeset 1367780)

VB: Split SyntaxFacts partial class into additional parts to allow linking the source for SyntaxKind methods only

1. SyntaxFacts.vb is split into SyntaxFacts.vb and SyntaxKindFacts.vb
2. The VBSyntaxGenerator tool has an additional /gettext option that generates a SyntaxFacts partial class with a single method: GetText(kind As SyntaxKind)
 (changeset 1367744)

***NO_CI***
 (changeset 1367702)

***NO_CI***
 (changeset 1367677)

Prevent SemanticModel.GetSymbolInfo from crashing when Me/this is used outside of a valid member context. (changeset 1367667)

1) delete redundant property groups
2) delete explicit OutDir setting since it's already set from the project imports. (changeset 1367653)

2. Update fakesign to use the closedsource targets
3. Revert the opensourcedebug flag setting change, because the closedsource target sets it to false
4. A side effect of this is that 42.42.42.42 builds will now go back to doing partial builds correctly

 (changeset 1367248)

Add more argument validation and doc comments to CodeFixContext members and address CR feedback. (changeset 1367239)

This was causing some unecessary rebuilds inside Visual Studio. (changeset 1367226)

The VB one has been replaced by a diagnostic, so it's no longer needed. The C# one isn't running right now but we'll leave it around as a reference until it's been converted too. (changeset 1367223)

When the target of a using alias used an extern alias as a qualifier, we used to emit the first alias on the containing assembly.  This was problematic since that extern alias might not be in scope.  Now we take into account which extern aliases are in scope.  This is still not as nice as Dev12's behavior - matching the alias in source - but it's cheaper and should be equivalent.

CR: ToMat; AnGocke (changeset 1367143)

Test for bug 1077204: Because a foreach iteration variable of a value type is read-only, an invocation of a mutating method on its instance field of a value type should make a temp copy rather than mutate the field in-place (changeset 1367129)

Without this flag, many duplicate copies of our binaries are made for all Portable projects, which is wasteful. (changeset 1367128)

Fix for bug 1072380: Audit public APIs to make sure we have the right degree of validation for parameters

Add argument validation for public APIs in diagnostic analyzer driver, code fix and refactoring context. (changeset 1367094)

Let clause may be a closure scope. Add missing case to LambdaFrame.AssertIsLambdaScopeSyntax. (changeset 1367055)

added fast lane for active file for solution crawler. currently only one that uses it is diagnostic service.

now, rather than 1.5 seconds, active file path uses 200ms delay (which should be same as dev12)

this could potentially affect typing responsiveness since we run analyzers on the active file more often than before but this is the only way to get faster update on active file.

also, now normal file path will stop running while active file one is running in solution crawler. (changeset 1367049)

***NO_CI***
 (changeset 1367038)

Fix build break from my previous checkin: Remove usings for deleted namespace Microsoft.CodeAnalysis.Diagnostics.Internal

Pass me the virtual squirrel... (changeset 1366544)

IDE and compiler analyzer driver refactoring to internalize a bunch of public APIs in the compiler driver.

Bunch of analyzer related types (actions, scope, etc.) were forced to be public as the IDE driver was doing the core analyzer action execution. The big change here that enabled internalizing was to move all the core analyzer action execution down to the compiler layer by adding Execute*Actions public APIs on compiler analyzer driver for all action kinds (analogous to the current ExecuteSyntaxNodeActions and ExecuteCodeBlockActions APIs). Major API internalization changes are:

1) Make HostAnalysisScope and its subytpes internal in the compiler layer and remove the public API AnalyzerDriver.GetSessionAnalysisScope. Session analysis scope essentially maintains a map from analyzers to their registered actions. By explicitly storing this map on the IDE driver, we don't need the shared session scope.

2) Make constructors of all the analyzer context types internal and make all the analysis scope types internal too as IDE driver doesn't need them anymore.

3) Make AnalyzerAction and all it's subtypes internal in compiler layer. This was made possible by both the above changes.

4) The only remaining public type now (apart from DiagnosticAnalyzer and context types) is AnalyzerActions, which is essentially a bag of registered actions. All it's properties that exposed the analyzer actions have been made internal. (changeset 1366505)

Test for bug 1076661: Assert fails at Microsoft.CodeAnalysis.CSharp.SyntaxExtensions.IsTypeInContextWhichNeedsDynamicAttribute (changeset 1366421)

Implements feedback from CR. (changeset 1366292)

Signed integer compression in PE Writer was implemented incorrectly. Fix the implementation. This didn't actually affect anything Roslyn currently emits since we are only using this compression to encode low bounds of arrays, which are always 0 in C# and VB.
     Support arbitrary negative syntax offsets in EditAndContinueMethodDebugInformation. Rather than using signed integers to encode the negative values, which increases the size of the data for the majority of cases when the offsets are positive, we encode a baseline and add it to the offsets. (changeset 1365821)

***NO_CI***
 (changeset 1365691)

Use the same algorithm for state machine type name generation for iterators that is used for async in both C# and VB.
Preserve the name of the state machine when emitting EnC delta. (changeset 1365145)