1. 13 3月, 2015 7 次提交
    • V
      Use ?. operator where beneficial · ddd29d1f
      Vladimir Reshetnikov 提交于
      ddd29d1f
    • V
      Some code cleanup · 08e8bf89
      Vladimir Reshetnikov 提交于
      08e8bf89
    • H
      Merge pull request #1216 from heejaechang/Telemetry · 7b63f3ac
      Heejae Chang 提交于
      log when VS has hit low memory barrier
      7b63f3ac
    • J
      Read logic must consider unicode character lengths · 6313aa3c
      Jared Parsons 提交于
      The SourceTextStream type was operating under the assumption that
      Encoder.Convert was a non-throwing method so long as it was passed a
      destination buffer with at least one byte available for writing.  The
      actual contract for Convert is it will not throw so long as it is able
      to write the result of converting at least one character to the
      destination buffer (or there is nothing to convert).  In that case it
      will throw an ArgumentException indicating it attempting to do work but
      was unable to do so.
      
      The SourceTextStream type processes the characters in chunks according
      to the count passed into Read.  This caused a bug when a character which
      was represented with more than one byte value was at the end of a
      logical chunk of text.  The Converter would convert all the chars except
      the last one.  But SourceTextStream continued processing because there
      was at least one byte left in the destination buffer and hence an
      exception was thrown.
      
      The fix is to not check for count > 0 when processing but instead count
      >= the maximum number of bytes the encoding could produce for a single
      character.
      
      Note: I did consider calling GetByteCount here instead but decided
      against it.  It essentially forces the encoder to do the work of
      decoding the lead byte twice on every iteration of the loop. Seemed
      better to keep the simple worst case check here.
      
      closes #1197
      closes #1221
      6313aa3c
    • J
      Remove references to implementation DLLs · d26da4e6
      Jared Parsons 提交于
      These DLLs are of the Implementation variety and should not be
      referenced.  The good news is we weren't using them anyways.
      d26da4e6
    • A
      Add the CoreCompile targets for C# & VB to MSBuildTask project · aa8d4ae4
      Andy Gocke 提交于
      This extracts the CoreCompile target from the Microsoft.CSharp.CurrentVersion
      and Microsoft.VisualBasic.CurrentVersion targets files and creates two new
      targets files, Microsoft.CSharp.Core and Microsoft.VisualBasic.Core, to contain
      it.
      
      This is necessary because the CoreCompile target contains the actual invocation
      of the Csc/Vbc tasks, which the MSBuildTask assembly contains. Any changes in
      the public surface area of the tasks need to be reflected in the targets. These
      targets should eventually be inserted into the MSBuild install with the task as
      the compiler public entry point.
      aa8d4ae4
    • C
      Merge pull request #1219 from cston/1105626 · e463d455
      Charles Stoner 提交于
      EE: Non-printable characters should not be escaped when using 'nq' format specifier
      
      Incorporated more feedback from PR#1206.
      e463d455
  2. 12 3月, 2015 33 次提交