Update the version of the toolset compilers used for build and make sure that all projects are using the toolset NuGet. (changeset 1330804)

- Ensure we can build and run tests when current system locale isn’t English.
- Move CSC/VBC help strings to resources so that they can be localized.
 (changeset 1330638)

separated IsParameterlessValueTypeConstructor into IsParameterlessValueTypeConstructor and IsDefaultValueTypeConstructor

It is pretty confusing to follow the usage of IsParameterlessValueTypeConstructor with optional flag.

***NO_CI***
 (changeset 1330578)

This is consistent with behavior of "new" when used with structs in general - we should call public parameterless constructor if present, which Activator.CreateInstance does.
It is also consistent with VB and F#

***NO_CI***
 (changeset 1330480)

Replace a couple of metadata references with the equivalent project-to-project references. (changeset 1330367)

Fix bug 1020273: Return the same value as the native C# compiler did in unchecked conversion from floating-point types to integral types in constant expressions in case of overflow. The C# spec says the result is unspecified in these cases, but we want to return the same unspecified value as the native compiler. Before this fix, Roslyn returned zero in these cases. (changeset 1330238)

Making codegen for compound operators over properties with generic receivers same as in Dev12 for compatibility reasons.

This affects cases like

T x;
x.P1 += foo(ref x);
x[1] += foo(ref x);

***NO_CI***
 (changeset 1330113)

Added roslyn diagnostic rule that warns about using generic CodeAction using CodeAction.Create (changeset 1330067)

- Syntax tree
- Parsing
- Initial binding
- Naive lowering, resulting IL might be inefficient or, in some cases, might be incorrect with respect to preserving side effects in the target.
 (changeset 1329866)

We were calling GetDeclarationDiagnostics() before attaching the driver and this would have led to binding twice in the compiler (since attaching the driver produces a new compilation). Moving the call to GetDeclarationDiagnostics() after attaching the driver's queue. (changeset 1329763)

Replace invocations of CaseInsensitiveComparison.Compare with CaseInsensitiveComparison.Equals, remove some unnecessary code elements (usings, qualifiers, type arguments, casts, empty elements in xml doc comments).
 (changeset 1329726)

The PDB has an attributes field for each local.  We were setting "1" for "compiler-generated" and "0" for everything else.  It turns out that dev12 was expecting "1" for "ignored by the expression compiler" and "0" for everything else.  This was most important for display class locals, which are compiler-generated but should definitely not be ignored by the expression compiler.

As far as I can determine, we now emit the same values as the native compiler.

TODO: The Roslyn expression compiler does not consume the attributes field - it just uses the name to determine whether a local is interesting.  Should we consume the field for consistency with the native expression compiler?

CR: PHarring, KevinH, NGafter, VSadov (changeset 1329523)

Fix Workspaces.csproj. When defining the MSBUILD12 constant, don't obliterate the other constants. (changeset 1329444)

MSBuildWorkspace.cs needs to know if the project is building against MSBuild 12 or not. Add the MSBUILD12 constant when it is. (changeset 1329434)

Handle the trivial case of ((x)) -> (x) when only the inner parenthesized expression has Simplifier annotation. (changeset 1329157)

Just the Unit testcases

          This change fixes the issues related to handling Turkish Locale(mainly around Turkish-i)

          The bugs 1016490, 1016492, 1016504 and 1016514 are fixed.

    Next change will contain fixes for Integration tests. (changeset 1328547)

Speculative semantic model is not designed to work on TypeConstraintSyntax. When a conflicting location is a type constraint, get  the inner TypeSyntax to obtain a speculative semantic model for that node.  The bug existed in both languages and this fixes both. (changeset 1328496)

Fix 529531: Conflict resolution engine in refactorings should insert parentheses to keep correct parsing

In this bug, the expander is trying to expand code like "x as N + 1" where N is an alias to int?. The expander was expanding this to x as int? + 1 which is not the fully expanded form. Fixing it to expand to x as global::System.Nullable<int> + 1 which when simplified knows to put parentheses correctly: (x as int?) + 1 (changeset 1328490)

While parser does not produce nonterminals without a single child, it is possible to get such nodes via factories or rewriters.
We should be able to compute Span for such nodes.

Fixes #204

***NO_CI***
 (changeset 1328488)

The fxcop rules have msdn helplinks that would show up in the ruleset editor and CA results window. This change adds those links to the roslyn fxcop analyzers. (changeset 1327942)

Code generation, when emitting expressions for literals, would reflect against the members of some predefined types to figure out possible constants. It also used reflection in one place to invoke syntax factories. This code isn't very portable, so remove the reflection with more explicit code. (changeset 1327081)

Added comparison options to INamespaceOrTypeExtensions based on comparision options for INamespaceSymbolExtensions. (changeset 1326375)

Fix bug 1016693: Do not give a warning about missing 'new' modifier on compiler-generated backing fields. (changeset 1326362)

* Fix 879811: Do not suppress ambiguity errors if they are caused be the same nested type imported through several using static directives with different type arguments.
* Fix typos in comments, corrupted characters due to incorrect source encoding, remove unnecessary casts, namespace qualifiers, type arguments and using directives. (changeset 1326357)

Assign a random number as a logging ID instead. For later exceptions, catch and log, and then continue the rest of compilation. (changeset 1326350)

There were many classes that would inherit other classes, but all methods being used were static methods. It appears inheritance wasn't being used to take advantage of a type hierarchy or for virtual dispatch, but just to scope helper methods. This is overkill and makes the code more difficult to understand.

Also, remove a few places where static methods were newing up objects that should have been singletons. (changeset 1326268)

Fix how we get the directory of the VBCSCompiler from its path in the native client. (changeset 1326192)

Make signatures of internal SyntaxFactory.ParseDebuggerExpression methods consistent (changeset 1325699)

messages.

The new native client is written in C++11 to be more maintainable and
forward-looking. The native client is a static library, which is now
linked into the csc2 and vbc2 projects instead of having a single csc2.cpp
file which is shared between the two projects and built for each based on
a preprocessor definition.

The MSBuildTask is also configured to use csc2/vbc2 and feature no extra
code for Roslyn, which will prevent us from having to maintain both a
native and a managed version of the client. (changeset 1325415)

Update toolset to 20140827.1 signed drop. This also enables the Roslyn analyzers in command line build (they used to only work in IDE) and fixes a bunch of violations of DirectlyAwaitingTaskAnalyzer. (changeset 1325368)

This change fixes the global/assembly suppress message attribute generation for member symbols via the light bulb. This attribute takes a Target string denoting a string representation for the symbol on which the suppression is to be applied. Currently, we just walk up to the enclosing type and emit its fully qualified name, suppressing the diagnostic on entire type rather then the member.
Now, we do the correct thing by using a unique string for member. This unique string for declaration symbols is generated using the existing DocumentationCommendId.CreateDeclarationId API, which is used across workspaces by various features that need such a string representation. This type also exposes GetSymbolsForDeclarationId API for converting the string representation back to symbols. The suppression logic in compiler layer uses this API to decode this attribute's target string. In the process I also fixed couple of bugs in the DocumentationCommendId APIs which surfaced through the added tests. (changeset 1325198)

Updated a comment explaining why pinned locals are always converted to unmanaged pointer types when loaded.
Also tweaked a little the lowering of the fixed access to strings to drop an unnecessary conversion to a pointer when doing null check.
***NO_CI***
 (changeset 1325162)

C#: Avoid using ErrorMethodSymbol as a context for a binder, this breaks containership chain for symbols and creates a bunch of other problems. (changeset 1324902)

Disallow simplification of type name to predefined type keyword inside nameof() since language doesn't allow predefined type keywords inside nameof().

Also including code review feedback for an earlier fix. (changeset 1324882)

This is a part of porting C# synthesized refactoring work where the names of long-lived variables follow a naming pattern that allows us to reverse-engineer the SynthesizedLocalKind value from the variable name. Especially in this change, we give a synthesized variable an explicit name based on its SynthesizedLocalKind at emit time, not at local symbol creation time. (changeset 1324862)