Fixes #949

Zip

This changes the Windows builds to restore in the same manner as Linux.  Helps ensure we keep the lab consistent between the runs.

The other positive upside of this change is shaves ~10 minutes of individual runs.  Roslyn.sln is a *huge* solution, has a rather large MSBuild include pattern and as a result puts a lot of pressure on restore.  As such the set of restores we do typically takes ~10 minutes.

Long term we'll be working with NuGet to get this time down a bit.  At the moment though we're a bit of an odd solution here with our size and time requirements.

Fix issue with code model eventing and VB type characters on parameter names

Fix a testing issue

Changed some tests from blocking waits to be properly async.

Ensure that flow analysis calls VisitRvalue instead of Visit for expressions in order to enforce proper state transition.

Fix PublicAPI analyzer in our source tree

Remove some debug-only code...

This closes #6028, and #6001

that intentionally slowed down the code to help detect race conditions
Fixes #4337

Ensure that flow analysis calls VisitRvalue instead of Visit for expressions in order to enforce proper state transition.

Fixes #5992.

If logical expression is not visited with VisitRvalue method, current state remains splitted, which causes a NullReferenceException when the next expression is visited.

Update TestRunner.cs to properly create the parent directory instead of a directory with the file name.

Fixes #6002

Essentially, the problem is that the type character should never be considered as part of the parameter name. This was happening in two places:

1. Comparison of parameter names in code model events. Because the type character was being included, a Rename event would be incorrectly triggered.
2. ICodeModelService.GetName(...) incorrectly returned the type character for parameters. This resulted in downstream effects of not being able to look up the CodeElement for a node by name.

Updating the other instance of AssertDebugException in RealParserTests to only be used in Debug mode.

Added pathmap to msbuild options

Follow the CommonWith pattern in compilation options

Supply CodeBases for binding redirects

Stop assuming previous submission aliases have been resolved

Real parser

Fix text color copied from interactive window

Fix typo in summary comment

fixed null exception

made CS0067 another build only error

moved Diagnostic usage to DiagnosticData in workspace layer

double quotes
you have 'windows-roslyn-internal''

[‎10/‎14/‎2015 2:01 PM] Tanner Gooding: 
and you need
label('windows-roslyn') 
label('windows-roslyn-internal')  
so two separate entries
[‎10/‎14/‎2015 2:02 PM] Jonathon Marolf: 
oh...
[‎10/‎14/‎2015 2:02 PM] Tanner Gooding: 
apparently
[‎10/‎14/‎2015 2:02 PM] Jonathon Marolf: 
alright, I'll change it in open
[‎10/‎14/‎2015 2:03 PM] Tanner Gooding: 
actually
just set it to label('windows-roslyn-internal')  for the moment
im not sure two entries will work either
[‎10/‎14/‎2015 2:04 PM] Jonathon Marolf: 
ok

[‎10/‎14/‎2015 1:55 PM] Tanner Gooding: 
needs to be 'windows-roslyn windows-roslyn-internal'
and one more change
[‎10/‎14/‎2015 1:55 PM] Jonathon Marolf: 
one more change that is?
[‎10/‎14/‎2015 1:56 PM] Tanner Gooding: 
is to modify maxPerNode(1) to maxPerNode(4)
[‎10/‎14/‎2015 1:56 PM] Jonathon Marolf: 
k