Previously we reported diagnostics caused by the debuggee not allowing edits in the corresponding module in EnC diagnostic analyzer.
A module does not support edits if any of its instances does not support the edits. There are scenarios in which module instances may be loaded while in break mode.
E.g. if the user attaches to a secondary process while debugging a primary process, the secondary process might have a module instance loaded of the same module loaded to the primary process.
To handle these cases we hooked up debugger module load/unload events and invalidated the reported diagnostics.

This approach has a few problems:
1) EnC analyzer is now non-deterministic, as it can give different answers for the same inputs depending on the state of the debuggee
2) Turns out that the debugger does not deliver module load/unload events in all cases (e.g. when the secondary process is killed).
3) It's a bit complicated and would get even more complicated once we moved EnC to OOP/Cloud

Instead, we don't report these errors until the user triggers the "continue" action. At this point the VS and all processes being debugged are blocked until the changes analyzed and applied.
Since this situation is not very common the slight regression in interactivity is acceptable.

Addresses 815MB allocations analyzing Roslyn.sln.

This is not a user facing string, so must not be localized. Additionally, with https://github.com/dotnet/roslyn/pull/38886, we now support bulk severity configuration in editorconfig based on diagnostic category, so the string ought to be a non-localized constant without any spaces.

Update src/Features/Core/Portable/RemoveUnusedParametersAndValues/AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs

EnC: Tweak handling of out-of-sync documents to work around source file content inconsistencies (#40947)

* Do not block in presence of out-of-sync documents.

Instead, ignore any changes made to these documents while debugging until their content matches the source used to build the baseline DLL.

* Only check output PDB, not debugger SymReader, for document checksums.
Turns out SymReader does not support reading document checksums once EnC changes have been applied.

Better handle errors that might occur when validating checksums. Previously some of the errors were not reported as diagnostics.

We previously blocked EnC when we observed a source file that is out-of-sync (i.e. its current content does not match the checksum in the originally built PDB). We can however just ignore these files and report a warning that changes made to this file won’t be applied until the file content is reverted back to the state it was when the PDB was built (the file transitions to “matching” state). Once a file is in matching state it can’t change back to another state. We know that we have not applied any change to the code that was compiled from the file because we ignored the file while it was in out-of-sync state. Therefore we know that any changes made from now on can be safely applied to the debuggee.

If we can’t determine whether a file matches or not due to error reading the PDB or the source file content we can treat it similarly to out-of-sync file. That is, ignore any changes until we are able to confirm the file matches. That can happen if, e.g. the PDB is temporarily locked by another process and unlocked later.

Simplify implementation of GetStatusAsync.

Fixes VSO [1051496](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1051496) ([VS feedback](https://developercommunity.visualstudio.com/content/problem/880533/edits-were-made-which-cannot-be-compiled-stop-debu.html))

Ensure that we don't kick off SolutionCrawler's Reanalyze functionality if solution crawler is turned off with the option `InternalSolutionCrawlerOptions.SolutionCrawler`.

This is needed for our internal RPS performance tests which intend to turn off solution crawler for certain scenarios to reduce noise from it.

Follow-up to https://github.com/dotnet/roslyn/pull/40289

Workspace options should now be set with `Workspace.TryApplyChanges(Workspace.CurrentSolution.WithOptions(newOptions))`

My previous fix to #30887 added special handling for special Winforms  method with prefix "ShouldSerialize" or "Reset". However, I incorrectly required both these methods to have boolean return type, while only the former should have boolean return. Reset methods needs to be void returning. This change fixes this case.

Fixes #38491 reported on developer community for this bug.

Mostly straightforward annotation. The SymbolComparer is deleted because
the code was unused.

Fixes #38507

move code from derived funtion to base class

remove refactoring when there is const keyword

* Adds nullability, removes dead code.

* Clean up RemoteHostClient exception and lifetime handling

* Nullables

* JsonRpcEx disposal cleanup

* Nullables

* Refactor abstract JsonRpcEx to sealed RemoteEndPoint

* Use RemoteEndPoint for ServiceHub services

* Move ctor

* Use RemoteEndPoint in ServiceHubRemoteHostClient

* Minor cleanup of log messages

* JsonRpcTargetOptions

* Use RemoteEndPoint in CodeLens, tests

* Inline Extensions.InvokeAsync methods into RemoteEndPoint

* Remove unnecessary invoke methods

* Unify exception handling

* Allow null arguments in remote invocation

* Simplify ClientDirectStream

* Fold ClientDirectStream and ServerDirectStream into RemoteEntryPoint

* Feedback

* Fix test

Fixes #38050

Improve IDE0060 messages for parameter which has non-zero references, but still can be removed as the initial parameter value is never used.