- 23 5月, 2015 4 次提交
-
-
由 dotnet bot 提交于
-
由 Matt Warren 提交于
Fix format rule for dot expression after label
-
由 Charles Stoner 提交于
Treat .csx/.vbx as regular source files from command-line compilers; change *ParseOptions.WithKind(SourceCodeKind) to internal; and throw NotSupportedException from CSharpParseOptions and VisualBasicParseOptions constructors if SourceCodeKind is Interactive or Script. [These changes should apply to the 'stabilization' branch only.] As a result of the changes, a significant number of unit tests are now skipped. (Search for SCRIPTING define and #2888 to find the test changes.)
-
由 Charles Stoner 提交于
-
- 22 5月, 2015 15 次提交
-
-
由 Dustin Campbell 提交于
Ensure that calls into EnvDTE.CodeModel work even if the underlying FileCodeModel has not been realized
-
由 Manish Vasani 提交于
Handle analyzers which have enabled rules, but no registered actions. Customer scenario: Analyzer author writes a bolier plate analyzer that defines the rule that it intends to implement in future, but registers no analyzer actions for analysis. Adding such an analyzer to your analyzer assembly brings down the entire analysis, and no analyzers execute during command line build. The issue was reported for StyleCopAnalyzers package which has many such to-be-implemented analyzers. Fixes #2980 Fix description: Add a null check around the place we compute set of all registered actions for analyzers. Testing: Added regression tests + existing tests.
-
由 Tomáš Matoušek 提交于
Improve debugging experience around exception filters
-
由 Manish Vasani 提交于
Customer scenario: Analyzer author writes a bolier plate analyzer that defines the rule that it intends to implement in future, but registers no analyzer actions for analysis. Adding such an analyzer to your analyzer assembly brings down the entire analysis, and no analyzers execute during command line build. The issue was reported for StyleCopAnalyzers package which has many such to-be-implemented analyzers. Fixes #2980 Fix description: Add a null check around the place we compute set of all registered actions for analyzers. Testing: Added regression tests + existing tests.
-
由 AlekseyTs 提交于
Ensure BoundLValueToRValueWrapper nodes are marked as compiler generated.
-
由 Paul Harrington 提交于
Port2966
-
由 Tomas Matousek 提交于
-
由 Neal Gafter 提交于
Correct the copyright header on four files.
-
由 Neal Gafter 提交于
-
由 Dustin Campbell 提交于
Ensure that calls into EnvDTE.CodeModel work even if the underlying FileCodeModel has not been realized When calling into an EnvDTE.CodeModel API, the caller must pass the file name of the file to be operated on. For example: var ns = codeModel.AddNamespace("MyFile.cs", "MyNamespace"); However, the implementation EnvDTE.CodeModel would only ever succeed to find the FileCodeModel for "MyFile.cs" if had already been created and cached. If the FileCodeModel wasn't in the cache, the API that was called would throw. Ultimately, this comes down to a set of APIs with bad names that don't reflect that they only return cached values. This change renames those APIs to give them proper names (e.g. TryGetCachedFileCodeModelInstance) and adds an API that will retrieve a cached FileCodeModel or create a new one if needed.
-
由 Manish Vasani 提交于
Fix cast simplification to not offer cast removals for following cases: 1. Explicit numeric casts in explicit checked/unchecked context 2. Non-identity pointer-to-pointer conversions. Fixes #2691 Description: Fix is to bail out early for these cases. As we are now more conservative, we cannot regress in offering any additional incorrect cast removals. #2987 tracks improving on this conservative approach post 1.0 milestone. Testing Done: Existing cast simplification tests. Approved by MattGe.
-
由 Manish Vasani 提交于
1) Explicit numeric casts in unchecked context 2) Non-identity pointer-to-pointer conversions. Fixes #2691 Description: Fix is to bail out early for these cases. As we are now more conservative, we cannot regress in offering any additional incorrect cast removals. Testing Done: Existing cast simplification tests.
-
由 Paul Harrington 提交于
-
由 Paul Harrington 提交于
-
由 Paul Harrington 提交于
Fix NullReferenceException in DependentProjectsFinder when we have an InternalsVisibleTo attribute with a null constructor arg.
-
- 21 5月, 2015 20 次提交
-
-
由 Tom Meschter 提交于
Generate relative paths correctly. **Bug:** Fixes #1579. **Customer Scenario:** The customer wishes to use a shared rule set file in their project to control their diagnostics. The .ruleset file is at the root of their solution, so the customer adds it to their project as a linked file. They then set it as the active rule set by right-clicking on the file in Solution Explorer and selecting "Set as Active Rule Set". The file should become the active rule set for the project, turning various diagnostics on or off or altering their severity. Instead the customer gets an error in the Error List: "The file '..\\..\\..\\Rule.ruleset' cannot be found" and the rule set has no effect. **Fix:** When adding `..` to the relative path to backup to higher-level directories, we effectively add each one multiple times. The fix is to stop doing that. **Testing:** I manually tested the following variation on the original scenario: * Rule set file in the same directory as the project file * Rule set file one level above the project file * Rule set file two levels above the project file * Rule set file up two levels and then down in a subdirectory * Rule set file one level below the project file * Rule set file two levels below the project file * Rule set file on a different directory and verified that in each case the project file ends up with the correct path, and that the rule set takes effect as expected. I also added unit tests to exercise the affected code.
-
由 Ravi Chande 提交于
Use a ConditionalWeakTable for SyntaxContext cache
-
由 Dustin Campbell 提交于
Fix Code Model bug with adding attributes in presence of XML doc comments
-
由 Manish Vasani 提交于
Guard against concurrent callbacks into analyzers in IDE Customer scenario: We need to do so for couple of scenarios: 1. Different diagnostic clients might end up requesting diagnostics at the same time and hence end up attempting to invoke into the same analyzer simultaneously. 2. FixAll occurrences computes diagnostics in parallel, hence can causes concurrent callbacks. If the analyzer hasn't been written in a thread-safe way, then concurrent callbacks into it can cause analyzers to produce incorrect/misleading/duplicate diagnostics or the analyzer itself might throw and never execute again in the VS session. Fixes #2410 Testing: There is no functional change here, so existing tests provide adequate coverage. I manually verified that FixAll performance is acceptable for simplify name/remove unnecessary usings across projects/solution in Roslyn.sln Approved by MattGe.
-
由 AlekseyTs 提交于
Fixes #2662.
-
由 Ravi Chande 提交于
-
由 Neal Gafter 提交于
Make C# lexer resilient to binary data
-
由 AlekseyTs 提交于
Ensure anonymous types are always defined in a Global namespace.
-
由 AlekseyTs 提交于
Optimize away BoundReferenceAssignment in StackScheduler if the assigned local isn't used.
-
由 Matt Warren 提交于
-
由 Matt Warren 提交于
remove disposal logic from recoverable tree and text
-
由 Matt Warren 提交于
remove rule about no line between attributes
-
由 Neal Gafter 提交于
-
由 Neal Gafter 提交于
Fixes #2771
-
由 Tomáš Matoušek 提交于
Fix errors reported intermittently when changing the current IP by drag & drop right after edit
-
由 Jared Parsons 提交于
Use correct count in ReplaceSeparator
-
由 Tom Meschter 提交于
These unit tests will now assert that casing is unchanged by `FilePathUtilities.GetRelativePath(...)`.
-
由 Jared Parsons 提交于
The bounds checking code for the existing separator has no need to do an upper bound check on `index`. The IndexOf method will return -1 or a valid index into nodesWithSeps. Hence the comparison with `this.Count` here was both unnecessary and incorrect (should have been `nodesWithSeps.Count`). closes #2630
-
由 Tom Meschter 提交于
The `FilePathUtilities.GetRelativePath(...)` method is used in various places in the Workspaces and VS layers to generate a relative path from a starting directory to a target file or directory. However, it has a bug where it will generate an incorrect path if you need to go up more than one level from the starting directory to get to the target. For example, if the starting directory is `C:\Alpha\Beta\Gamma` and the target is `C:\Alpha\SomeFile.txt`, the correct relative path would be `..\..\SomeFile.txt`. Instead, we get `..\..\..\SomeFile.txt` (note the extra `..`). This commit fixes the issue and adds unit tests for this method.
-
由 Matt Warren 提交于
-
- 20 5月, 2015 1 次提交
-
-
由 Manish Vasani 提交于
We need to do so for couple of scenarios: 1. Different diagnostic clients might end up requesting diagnostics at the same time and hence end up attempting to invoke into the same analyzer simultaneously. 2. FixAll occurrences computes diagnostics in parallel, hence can causes concurrent callbacks.
-