The VS SDK team provided us with an updated NuGet that has better error
diagnostics during install / uninstall.  Going to change our VSI tests
to begin using build based deployment again for VSIX until they can get
the diagnostics that they need.  Once they have them will flip it back.

The VS SDK team is interested in tracking down the deployment errors
that we are seeing when deploying as a part of build.  This change adds
an option to make it easy to excercise that code path in builds.

Going to use this option to quickly toggle to the build based deployment
in order to mass test their fixes.

Our Test.cmd script and Microbuild test running got messed up during the
recent SDK change.  A series of conflicts were just merged incorrectly.

This moves the logic for testVsiNetCore into the BuildAndTest.proj file.
This matches the logic behavior for all of our other test runs.  It also
avoids us further complicating the necessary command line for calling
the BuildAndTest.proj file.

Eventually though want to move all of the test logic into a Powershell
file.  The MSBuild file at this point is approaching the complexity of a
full script but lacking the flexibility.  Should just convert it to a
script and move on.

The example ruleset provided contains some syntax errors, so copy/pasting wholesale somewhere can result in build errors when including it.

There was also a minor typo I found later in the file while reading through.

Simplify how we batch write to our persistence service.

Avoid inefficient use of ContainsKey

Make the SyntaxTreeIndex use a content based scheme for persisting data.

Don't crash when renaming a method to Finalize and there's a destructor present

Fixes #19008

	Expose 'use expression body' as an analyzer and a refactoring.

Dynamic Analysis Metadata spec

Provide an async codepath for sqlite writes.

This changes BuildBoss to flag the case where the Project element in a
ProjectReference doesn't match the actual GUID of the Project being
referenced.

Remove unnecessary delegate allocations in the analyzer driver

Remove unused private method