- 06 3月, 2015 1 次提交
-
-
由 John Hamby 提交于
This change set introduces the notions of registering compilation actions and code block actions into the diagnostics API. Compilation actions differ from compilation end actions in that they do not have access to per-compilation analyzer state and do not introduce action execution ordering constraints. Code block actions differ from code block end actions in that they do not have access to per-block analyzer state and do not introduce action execution ordering constraints. This change set also removes RegisterXEndAction methods on contexts other than the corresponding StartXAnalysisContext types. This change is intended to guide analyzer authors towards introducing analyzer state with appropriate lifetime. Some internal mechanism for the removed registration methods remains. This keeps the mechanism fully general and imposes a very marginal execution cost. The specific API changes: -- Removal of AnalysisContext.RegisterCompilationEndAction. CompilationStartAnalysisContext.RegisterCompilationEndAction remains. -- Removal of AnalysisContext.RegisterCodeBlockEndAction and CompilationStartAnalysisContext.RegisterCodeBlockEndAction. CodeBlockStartAnalysisContext.RegisterCodeBlockEndAction remains. -- Introduction of AnalysisContext.RegisterCompilationAction. -- Introduction of AnalysisContext.RegisterCodeBlockAction and CompilationStartAnalysisContext.RegisterCodeBlockAction. -- Renaming of CompilationEndAnalysisContext to CompilationAnalysisContext. -- Renaming of CodeBlockEndAnalysisContext to CodeBlockAnalysisContext.
-
- 28 2月, 2015 1 次提交
-
-
由 beep boop 提交于
Been almost a month since the code formatter was run so this change was a bit larger than would be expected for a normal (weekly) update. Diffs mostly around: - Whitespace changes - Missing copyright headers - Missing visibility modifiers
-
- 25 2月, 2015 2 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
1) Don't crash command line builds when reporting analyzer diagnostics. Reporting analyzer diagnostics may involve invoking user code for LocalizableString message, which may throw while finding resources or for other unknown reasons. We catch exceptions from these callbacks and report a diagnostic with the inner exception message. I verified that this addressed the crash seen in #271 and #813 and we started seeing this new info diagnostic. 2) Workaround for #271: The underlying cause of the crash is that our assembly resolver/CLR is unable to fallback to the main assembly for resources and ends up looking for the satellite resource assembly. We had seen this crash quite a while back, but it went away and this seems to have come up again. Workaround, as applied back then, is to mark the analyzer assembly with NeutralResourcesLanguageAttribute. I verified that adding this attribute to our core analyzer assemblies caused the resource to be correctly found and we don't even see the exception diagnostic from (1) above, but instead the actual diagnostic reported by the analyzer.
-
- 24 2月, 2015 1 次提交
-
-
由 Manish Vasani 提交于
Fix ReportDiagnosticAnalyzer meta-analyzer to handle broken code case where there are multiple overrides of DiagnosticAnalyzer.SupportedDiagnostics property
-
- 18 2月, 2015 1 次提交
-
-
由 Vladimir Reshetnikov 提交于
-
- 16 2月, 2015 1 次提交
-
-
由 Jared Parsons 提交于
The code base no longer uses StyleCop. Removing lingering references to it from the code base.
-
- 01 2月, 2015 1 次提交
-
-
由 beep boop 提交于
Background: As discussed in the dev team all hands all code under the GitHub dotnet foundation is using a single process for contribution, API review, infrastructure and coding style. The idea is to present a unified view to our customer and give them a single story for contributing to any project under the dotnet foundation. https://github.com/dotnet/corefx/wiki/Contributing#c-coding-style The coding style transition is automated using a Roslyn based rewrite tool: https://github.com/dotnet/codeformatter This will be applied in stages across our developer tree. Right now the focus is on the Open directory as this is what is being presented on github. Code owners will be contacted before the transition happens. Note: this is a soft style requirement. There are no build errors that come from this change. (changeset 1408227)
-
- 28 1月, 2015 2 次提交
-
-
由 RoslynTeam 提交于
-
由 RoslynTeam 提交于
-
- 24 1月, 2015 1 次提交
-
-
由 RoslynTeam 提交于
-
- 18 1月, 2015 2 次提交
-
-
由 mattwar 提交于
-
由 RoslynTeam 提交于
-- Rename DiagnosticDescriptor.HelpLink to HelpLinkUri. -- Make DiagnosticDescriptor implement IEquatable<DiagnosticDescriptor> (because it already overrides Equals and GetHashCode). -- Make CodeAction.GetOperationsAsync return an ImmutableArray instead of an IEnumerable. -- Rename CodeFixContext.RegisterFix methods to "RegisterCodeFix". -- Rename CodeFixProvider.ComputeFixesAsync to "RegiserCodeFixesAsync". -- Replace CodeFixProvider.GetFixableDiagnosticsIds method with a FixableDiagnosticsIds property. (changeset 1399202)
-
- 15 1月, 2015 2 次提交
- 14 1月, 2015 3 次提交
-
-
由 RoslynTeam 提交于
-
由 jaredpar 提交于
This moves our settings / targets files into the Open directory. These files are a referenced by virtually all of the projects in the Open directory and are a necessary part of the build process. Making this change is a necessary step in removing the project scrubber. (changeset 1396832)
-
由 RoslynTeam 提交于
-