Enable skipped tests.
 (changeset 1285056)

Bugfix 797286 DoStatement and CatchDeclaration were not part of the control statements that were affected by formatting options.

Fixed it. (changeset 1284836)

The definition part of the method, rather then the implementation part, was passed to the filter.
 (changeset 1284114)

We have two identical and trivial implementations of IMethodImplementation which are basically a tuple of implemented and implementing methods.. We could just make this a struct.
 (changeset 1283966)

Fix a couple project files to use the LKG compiler, not the locally installed compilers. (changeset 1283963)

Bugfix 962416 - Checked and Unchecked Statements not considered as Control statement. Fixed it. (changeset 1283915)

Since some of our recent ETA failures have not been diagnosable from looking at crashdumps alone, I'm enabling a circular buffer for our Logging instrumentation (the using (Logger.LogBlock.... statements). This will place a TaoEvents.etl file beside Tao.exe which can be used to see the last events leading up to a crash or hang. Note that for an in-process logging buffer to work, RoslynEventSource has to be initialized before TraceEventNativeMethods.EnableTraceEx2 can be called.  (changeset 1283451)

Since some of our recent ETA failures have not been diagnosable from looking at crashdumps alone, I'm enabling a circular buffer for our Logging instrumentation (the using (Logger.LogBlock.... statements).  This will place a TaoEvents.etl file beside Tao.exe which can be used to see the last events leading up to a crash or hang.  Note that for an in-process logging buffer to work, RoslynEventSource has to be initialized before TraceEventNativeMethods.EnableTraceEx2 can be called. (changeset 1283444)

The additional files and options passed through the new switches to csc\vbc are passed to the analyzers in this change. All the I*Analyzer interfaces now a AnalyzerOptions parameter which contains the additional streams and options.

Most of this change is adjusting all the implementors of these interfaces to take the new option. The only real changes are :

     - The command line compiler now pass the arguments to both the command line AnalyzerDrivers.
     - Adding a test that ensures that all interfaces get the options passed to them. (changeset 1283206)

Implements parser support for the new #Enable / #Disable feature in VB along with changes required for lighting up following IDE features: classification, keyword recommender, formatting.

Speclet - http://roslyn.codeplex.com/discussions/543476. Feature is equivalent to the #pragma warning feature in C#.

ToDo: Changes to actually suppress / unsupress diagnostics in the compiler are NYI. IDE support for the new directives should be mostly complete except for keyword highlighting which I intend to look into in a subsequent change. (changeset 1283171)

If somebody calls an Async method of Roslyn on a UI thread or equivalent, we don't want to schedule parts of the underlying implementation on the UI thread. Otherwise, doing .Result on the task from the UI thread may or may not deadlock, leading to instability. (changeset 1283155)

CR: ngafter; vladres; tomat
 (changeset 1282962)

Optimizer was ignoring break labels on switch statements. That could result in invalid optimizations that would be prohibited by the label.
VB had the same issue.

Normally break/continue kind of labels are represented by separate label statements after containing construct is lowered, so visiting just label statements in optimizer is sufficient.
However, switch statements do not get lowered (because they may be emitted as IL switch opcode) and therefore break label stays with its owner and needs to be recorded by the optimizer when containing switch statement is visited. (changeset 1282939)

TestBase.CompilerServerExecutable was incorrectly assigning basicCompilerExecutable instead of compilerServerExecutable
TestBase.MSBuildExecutable was incorrectly attempting to locate MSBuild.exe (changeset 1282519)

TestBase.CompilerServerExecutable already contains the full path. So KillCompilerServer() was redunantly prepending BinariesDirectory. (changeset 1282512)

Portable compilers don't need them anymore, except for a few of them that are used in for validation and changing extension of file names (embedded resources, netmodules, output name override).
 (changeset 1282511)

Roslyn.Test.Utilities.TestBase - Comparison should have been FileVersionInfo.GetVersionInfo().FileVersion
CSharpCommandLineTests - Reference to TestBase.FrameworkDirectory should have been RuntimeEnvironment.GetRuntimeDirectory
CSharpCommandLineTests - GetDefaultResponseFilePath() should have been using Path.GetDirectoryName() not Path.GetFullPath()
BasicCommandLineTests - GetDefaultResponseFilePath() should have been using Path.GetDirectoryName() not Path.GetFullPath()

 (changeset 1282478)

Some redundant code was merged down into Roslyn.Test.Utilities.TestBase.
CompilerServerTests now inherits from Roslyn.Test.Utilities.TestBase.
CSharpCommandLineTests and BasicCommandLineTests have also been updated to reflect these changes. (changeset 1282394)

Diagnostic analyzers need to be able to look at non-code files from a project (like web.config) to produce issues. They also need to be able to see project-level options. The IDiagnosticAnalyzer API will pass these files and options to the analyzers. So all analyzer hosts need to be able to pass these values through. This change adds the plumbing needed in csc\vbc by adding two switches /additionalfile and /option.

This is part 1 of the change to parse the commandline arguments. Passing to the analyzer will come in a follow up change. (changeset 1282218)

Support Uncomment Selection command when there is no selection, or it is a subset of the block comment. (changeset 1282151)

An expression body is an alternative to a block on certain members (properties, methods, operators, and conversions), which uses the lambda => to define an expression as the body of the member. (changeset 1281748)

Splits Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp and Microsoft.CodeAnalysis.VisualBasic into portable and desktop assemblies.

Existing Core\Source, CSharp\Source and VisualBasic\Source directories are renamed to Core\Portable, CSharp\Portable and VisualBasic\Portable.
New sibling Desktop folders are added and non-portable source is moved there.
"System.Runtime" references has to be removed in order for the portable project system magic to automatically add facade references.
 (changeset 1281686)

The PEWriter used to calculate sizes of metadata tables, rows and columns 3 times during emit. Under certain circumstances the result of the first one was different from the other two which might have lead to writing invalid values to PE headers.
This change factors various sizes related to metadata tables to a separate class that is immutable, calculated once and then passed around.
 (changeset 1281677)

First unit test - summing two locals.

Bonus:  Reuse a lot of utility code from the C# tests.

CR: chucks (changeset 1281544)

Adding additional info to exception text to help debug an intermittent unit test failure. (changeset 1281496)

Change TextTracker to use weak event so if Disconnect does not get called (if workspace is not shutdown manually) then TextContainer won't keep workspace alive.

Chaned Dispose to call ClearSolutionData, so users using Dispose pattern are certain to have cleaned up any held resources. (changeset 1281426)

Support breakpoints on Autoprop initializer and add the corresponding sequence points. (changeset 1281420)