- 05 6月, 2015 5 次提交
-
-
由 Manish Vasani 提交于
Gracefully bail out on extension method rewrite within conditional access expressions Fixes #2593 User scenario: User types a conditional access expression with a subsequent extension method invocation. For example, "a?.Method().ExtensionMethod()". Attempting to perform any simplification (cast simplification, simplify name) or refactorings (inline temporary) causes a exceptions in the simplification engine and all these IDE services are disabled for the project. Issue description: We are not handling conditional access expressions, and hence member access or invocations with null "left of dot" nodes, in our expander. Additionally, performing extension method expansion (to a static method invocation with receiver replaced as the first argument to invocation) is non-trivial. Fix description: This change makes a defensive fix by: 1. Guarding against null reference exceptions. 2. Bailing out on extension method rewrite within conditional access expressions. Approved 6/4 by ML Shiproom.
-
由 AlekseyTs 提交于
Include ContentType into assembly qualified type name emitted for an attribute argument.
-
由 Tomáš Matoušek 提交于
Report rude edit when a partially executed active statement is edited
-
由 Charles Stoner 提交于
Include accessible private members from outer types in Intellisense [stabilization branch] Port f9bd1d1f to stabilization branch
-
由 Tomas Matousek 提交于
-
- 04 6月, 2015 15 次提交
-
-
由 Charles Stoner 提交于
Conflicts: src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/SymbolCompletionProviderTests.vb
-
由 AlekseyTs 提交于
Addresses DevDiv 1169511.
-
由 Matt Warren 提交于
Enable xaml project test
-
由 David Poeschl 提交于
-
由 Matt Warren 提交于
-
由 Manish Vasani 提交于
Fix ITypeSymbolExtensions.IsOrDerivedFromExceptionType to handle type parameters constrained on Exception type or its subtype. Fixes #3254
-
由 Tom Meschter 提交于
Fix a NullReferenceException when setting diagnostic severity. **Bug:** Fixes #3098. **Customer Scenario** 1. Customer adds the NuGet package for Microsoft.AnalyzerPowerPack, System.Runtime.Analyzers, or System.Runtime.Interop.Analyzers (really, any package containing FxCop rules implemented as Roslyn analyzers). 2. In the Solution Explorer, the customer expands the References | Analyzers | Microsoft.AnalyzerPowerPack.Common node. 3. User right-clicks on CA2229 and selects "Set Rule Set Severity" | Error. 4. The effective severity of the rule changes to Error. 5. User right-clicks again and this time selects "Default" for the severity, intending to reset it to its default value. 6. The severity is not adjusted, and instead the following dialog pops up: ![image](https://cloud.githubusercontent.com/assets/235241/7825354/dbe7155e-03c0-11e5-819b-5beac1ffd2ad.png) Note that VS does not crash, and after dismissing the dialog VS continues to function. **Fix Description** It is possible to have multiple `<Rule>` elements with the same ID in a rule set file, so long as they specify the same Action. This is likely to happen with former FxCop rules--you'll end up with one copy under the "Microsoft.Analyzers.ManagedCodeAnalysis" analyzer (from FxCop) and one under "Microsoft.AnalyzerPowerPack.CSharp" or similar (from a Roslyn-based analyzer). When the user selects one of these rules in Solution Explorer and sets the severity to "Default" we need to find each rule with the matching ID, and remove them all from the rule set file. However, we remove the rules while we're in the middle of the enumeration, tripping up the enumerator and leading to `NullReferenceException`s. The fix is to first flatten the enumeration of items to be removed to a list, and then remove them. The first commit in this pull request implements the fix, the next two reorganize the code and add unit tests. **Testing Done** I added unit tests around the code in question, include one that fails without the fix. I also ran through the scenario described above and validated that the rule set was updated as expected after I implemented the fix.
-
由 Tomáš Matoušek 提交于
Replace public fields with properties in compiler API
-
由 Jason Malinowski 提交于
Deal with solutions with circular project references in MSBuildWorkspace
-
由 Dustin Campbell 提交于
Code Model: When setting the name of a CodeElement, ensure that its members are updated
-
由 Andy Gocke 提交于
Port PR #3237 to stabilization -- Catch exceptions when creating a stream for signing
-
由 Ravi Chande 提交于
Handle "Color color" from VB completion
-
由 Matt Warren 提交于
Remove tail recursion and enable cancellation
-
由 AlekseyTs 提交于
Do not cut short binding of “return” statement even if expression has syntax errors.
-
由 AlekseyTs 提交于
Check current language version for “Global” keyword only if it starts namespace name in namespace declaration.
-
- 03 6月, 2015 15 次提交
-
-
由 Charles Stoner 提交于
Conflicts: src/EditorFeatures/VisualBasicTest/Completion/CompletionProviders/SymbolCompletionProviderTests.vb
-
由 Charles Stoner 提交于
-
由 David Poeschl 提交于
Update stabilization cibuild scripts
-
由 David Poeschl 提交于
The cibuild scripts had diverged between stabilization and master. This change brings stabilization back in sync with master and makes a small change to ensure passing invalid commandline arguments returns a proper error code.
-
由 Jason Malinowski 提交于
If we have a solution with circular references, leave one as a metadata reference to prevent deadlocks when trying to get compilations.
-
由 Manish Vasani 提交于
Fix ITypeSymbolExtensions.IsOrDerivedFromExceptionType to handle type parameters constrained on Exception type or its subtype Fixes https://github.com/dotnet/roslyn/issues/3254 User scenario: User writes code where they have explicit casts to a type parameter deriving from Exception type or its subtype. We will offer incorrect cast removal fixes to remove these explicit casts. Removing such casts will cause their code to not compile. Even worse, if they apply a FixAll occurrences code fix, then all such casts across their (document/project/solution) will be removed, causing tons of compile errors. Fix description: IsOrDerivedFromExceptionType was only checking for base types of the given type symbol to detect if the type is an Exception type. We also need to handle type parameters which are constrained by Exception or its subtypes. Testing: Added regression tests + existing tests.
-
由 Tom Meschter 提交于
Add unit tests to cover modifying rule set documents.
-
由 Tom Meschter 提交于
Extract the code to modify rule sets to a helper type.
-
由 AlekseyTs 提交于
Addresses DevDiv 1179899.
-
由 David Poeschl 提交于
Pass correct itemIDs to IVsSymbolicNavigationNotify
-
由 Tom Meschter 提交于
Fixes #3098. It is possible to have multiple `<Rule>` elements with the same ID in a rule set file, so long as they specify the same Action. This is likely to happen with former FxCop rules--you'll end up with one copy under the "Microsoft.Analyzers.ManagedCodeAnalysis" analyzer (from FxCop) and one under "Microsoft.AnalyzerPowerPack.CSharp" (from a Roslyn-based analyzer). When the user selects one of these rules in Solution Explorer and sets the severity to "Default" we need to find each rule with the matching ID, and remove them all from the rule set file. However, we remove the rules while we're in the middle of the enumeration, tripping up the enumerator and leading to `NullReferenceException`s. The fix is to first flatten the enumeration of items to be removed to a list, and then remove them.
-
由 Andrew Casey 提交于
Loosen check in CapturedVariableRewriter.RewriteParameter
-
由 Manish Vasani 提交于
Fixes #2593 User scenario: User types a conditional access expression with a subsequent extension method invocation. For example, "a?.Method().ExtensionMethod()". Attempting to perform any simplification (cast simplification, simplify name) or refactorings (inline temporary) causes a exceptions in the simplification engine and all these IDE services are disabled for the project. Issue description: We are not handling conditional access expressions, and hence member access or invocations with null "left of dot" nodes, in our expander. Additionally, performing extension method expansion (to a static method invocation with receiver replaced as the first argument to invocation) is non-trivial. Fix description: This change makes a defensive fix by: 1. Guarding against null reference exceptions 2. Bailing out on extension method rewrite within conditional access expressions. Long term fix would be to implement this feature in expand/reduce engine, but this should happen post 1.0 milestone. A separate issue will be opened to track this work. Testing: Added regression tests + existing tests.
-
由 Andrew Casey 提交于
When we added support for transparent identifiers, we loosened the existing check so that they wouldn't be flagged as erroneous. We should have gone further and indicated that all anonymous types (i.e. including user-declared ones) are okay. Because of the way its check is structured, VB is unaffected. Fixes #3231
-
由 Andy Gocke 提交于
This change is meant to address crashes like the ones in bug 1140649. The crashes seem to happen due to exceptions thrown while getting a temporary output stream to write the PE file to. I have been unable to reproduce the conditions for the crash themselves -- they only seem to happen on a Japanese language Windows with a Japanese language copy of Visual Studio. This fix addresses their symptom by wrapping the CreateInputStream call during signing with a try/catch and then surfacing the exception as a diagnostic for signing failure. We cannot currently add any more localized resources to stabilization, so this fix is meant to be as targeted as possible and can only deliver information through existing resource strings. (cherry picked from commit 801a10a5)
-
- 02 6月, 2015 5 次提交
-
-
由 Ravi Chande 提交于
Fixes #3086.
-
由 Dustin Campbell 提交于
-
由 AlekseyTs 提交于
Check current language version for “Global” keyword only if it starts namespace name in namespace declaration. Addresses DevDiv 1129404.
-
由 Dustin Campbell 提交于
Add unit tests for PR #3242 that correctly trigger the failure when the change is not present, but pass when it *is* present.
-
由 Manish Vasani 提交于
Add an analyzer to catch incorrect usage of CodeAction.Create API for fixers that support FixAllProvider
-