* Enable switching bitness of interactive host

* Improve integration test error reporting

* Update integration test

* Move VS specific targets to VisualStudio.targets

* Move optimization targets to RepoToolset/OptimizationData.targets

* Move SourceLink targets to RepositoryInfo.targets

* Remove workarounds for fixed issues

* Move workrounds to Workarounds.targets

* Clean up binding redirect generation properties

* Remove unused targets

* Normalize PushToBlobFeed parameters to values used by RepoToolset.

Even though Roslyn can only every be deployed where at least net461 or netcoreapp2.0 is available Roslyn cannot depend on netstandard2.0 assemblies. This is due to the setup of Visual Studio which has a minimum target of net46 and hence only deploys netstandard1.3 facades. In order to prevent netstandard2.0 versions of NuGet references to deploy, at build or test, we must limit the desktop target framework used in our projects to net46.

There is nothing functionally wrong with having our tests target net461. At the same time though it would mean our tests were running against the netstandard2.0 version of references, such as System.Collections.Immutable, which is not what we deploy against. Hence not testing what we ship which creates a small but real hole.

* moving methods around to clean things up.

* more clean up

* added comment

* more code re-arrange

* revert some clean up back since that requires some changes I dont want to do for clean up

* optimize text change synchronization

previously, all files were synced between VS and OOP by file. it might use memory map file to sync, but it regardless always synched whole file.

this optimization add special care on text change case. now it will sync only text change rather than whole file when conditions are met.

this should remove most of cases where we need to sync whole file while typing.

adding this so that we can move editor centric features to OOP (features that respond to typing)

previously OOP would only hosts features such as FAR, full solution diagnostics, LUT and etc. where synching a file is not big cost compared to works features doing and doesn't require to sync file per each key stroke.

* address PR feedback

* workaround this bug - https://github.com/dotnet/roslyn/issues/26305

this will be removed once the bug is fixed

* add callstack on debug to make investigation easier

* if GetPinnedScopeAsync throws cancellation exception, connection can be leaked not disposed.

fixed the issue and added test

* make sure cancellation is thrown in test

* PR feedbacks

* more feedbacks

* address PR feedback

Closes #25560

* enable logAnalyzerExecutionTime on IDE so that we can start track analyzer perf

* removed unnecessary ICodeAnalysisDiagnosticAnalyzerExecutor interface.

it was added when OOP is first introduced to make sure VS.Next dll won't get loaded to VS process if OOP is not enabled.

when it is enabled by default, rather than removing the interface, implementation just moved down to feature layer to reduce code churn.

now, I am properly removing unnecessary abstraction.

* take Executor out of test MEF composition

* added IRemoteDiagnosticAnalyzerService interface

* made initial version working.

* added tests

* add tracking for inproc only analyzers

* pass in diagnostic analyzer service

* added open file performance tracking as well.

* added PII test

* dont hash analyzerId when it is reported by internal user

* added link to LOF wiki

* made blame to track open files as well.

* forgot to add return in if statement

* reduce threshold to 100ms

decide to start from lower threshold and then iterate rather than start from higher threshold

* added a way to log real time perf data in local machine with explicit option which can be used to train formula later

* addressed ivan's feedbacks

* renamed to ExpensiveAnalyzerInfo

* addressed PR feedbacks

* more renames

* addressed PR feedbacks.

renamed as much as I can find.

* listener can be null in unit test

* addressed PR feedbacks

* first refactoring to add connection pool

* pool added

* removed usage of KeepAliveSession which solely used as performance benefit favoring perf over complexity.

now with pool, there is no perf advantage by KeepAliveSession. it should be only used when one wants to make connection stateful.

* change remote call signature since solution is now set automatically

* fixed test failures

* made some constant an options. and made pool off by default

handle pool shutdown better

* now turn it on by default

* PR feedbacks

* address more PR feedbacks

* more comments

* renamed ConnectionPool to ConnectionManager. people seems confused by name too much. pool is just one of thing it does, it owns connection management in general.

* PR feedbacks

* change Contract.Fail to Contract.Require so that it doesn't crash VS when OOP is killed explicitly by users.

* PR feedbacks

* address feedbacks

* put finalizer under debug flag

* Active Statement Handling

* Start active statement tracking on background thread

* Ensure XAPI is initialized before calling Concord APIs.

* Fix up and add comments

* Call UninitializeThread in VisualStudioActiveStatementProvider

* Fixes

* PR feedback

* Use dispose pattern for debugger thread initialization

* Finish test

* PR feedback

* Do not track active statements in projects that do not support Roslyn EnC service (e.g. F#)

* Update comment.

* EnC: Report diagnostics for unexpected recoverable exceptions.

* Tweak NFW reporting

* Account for workspace changes in ActiveStatementTagger

* Unsubscribe event in dispose

* Fix initialization of non-remappable regions for unchanged AS in updated method

* Keep non-remappable regions from previous edit session if no edits were made.

* Update xlfs

* Avoid double-free on cancellation

* Avoid calling DkmWorkList.Cancel for now

* Handle active statement without location

* Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock

This lock is only being used to protect access to an instance which contains
internal synchronization.

* Better handle surrounding directives when inlining a local variable.

* Add tests.

* Share code between VB and C#.

* Reduce allocations in UnboundLambda

Fixes #23463

* Restore ReturnInferenceCacheKey as the key for _returnInferenceCache

* Update code to more closely follow patterns of the original code

* Cleanup from code review

* basic fix for intellisense in Immediate window

* better comments and cleanup

* Add basic integration tests

* cleanup inproc Immediate window integration test helper

* fix incorrect comment

* address PR feedback

* create Immediate window on ImmediateWindow_InProc.GetText()

* Verify MSBuild version in Developer CMD prompt

Roslyn is designed to have the simplest possible contribution story:
clone then build. Every pre-req needed is either located on the machine
or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if
needed.

The one case which causes a problem is the VS command prompt. In this
case MSBuild is pre-installed on the machine and may or may not be
suitable for building Roslyn.

Previously when building from a VS command prompt we just used whatever
MSBuild was provided. The assumption being a developer command prompt
was an explicit statement of whath MSBuild you wanted to use. Based on
all of our customer reports though this does not seem to be the
assumption that consumers of our repo have. The build gave them no
explicit errors about the provided toolset and hence when the build
failed they assigned flakiness to our repo.

Going forward we are applying the same version validation to MSBuild
when provided via a developer command prompt. If it doesn't match we
will refuse to build asking the user to upgrade VS or build from a
normal command prompt.

* Remove unneeded debugging line

* Comment about pre-release

* Added minimum version

* Add Omit If Default style option

* Add space to be like test without the omit

* Add/Remove without needing a property

* Reformat

* PR feedback

* Fix VB diagnostic based on feedback

* Handle case of NotApplicable modifier and field declaration list

* Fix tests

* PR feedback

* PR feedback

* PreviewCodeAction was overriding ComputeOperations but returning a post-processed operation from original action. This results in another PostProcess being called on the codeaction. If postprocess was overriden in originalaction that'll be ignored the second time (#23920)

* Support negative null-check when we are suggesting to inline type checks

Fixes #21097
Fixes #24286

* fix a case where persistent storage registration fails and some clean… (#24458)

* fix a case where persistent storage registration fails and some clean up code around it.

* added readonly

* address PR feedback

* removed comments no longer relevant

* renamed lock name

* moved waiter from diagnostics.dll to features.dll where all interfaces are defined. (#24512)

* put listener change back in (https://github.com/dotnet/roslyn/pull/24120)

* leave old types in legacy folder until partner teams move to new interface

* added legacy waiter to support partner teams

* Remove methods indirecting access to _metadataFileNameToConvertedProjectReference

This field is documented as being written and read from any thread,
but in practice all uses are guarded by an AssertIsForeground(). Thus
we can get rid of the helper methods that are trying to "help" by
locking before accessing the fields, making it really hard to track all
the real uses of it.

* Make method static that doesn't need state

* add a comment to address PR feedback

* Fix up tests of P2P to metadata reference conversion

It turns out we had some tests, but the tests were disabled. This was
because the tests weren't working properly anyways: they were calling
into UpdateProjectBinPath which only updated some (but not all) of
the project state. That was an internal helper method that shouldn't
be used by tests. Updating the tests to use
SetBinOutputPathAndRelatedData works better.

* Delete debug-only reference validation

This was some legacy code that tried to verify that the references
we have from the project system match up to what DTE and other sources
say. This was debug-only, and the actual asserts were commented out.
This is deadweight at this point, so delete it.

* added and cleaned up logs around build and live diagnostics. (#24551)

also added RoslynActivityLogger that can be enabled through project-system-tool

* Avoid closure allocations on the BindSyntaxTreeToId fast path

* CS1628 error text mentions in parameters; fixes #24584

* Small cleanup of completion logic.

* Move to xunit.console for CoreClr tests

Previously we were using xunit.console for desktop tests and dotnet-xunit for our
CoreClr tests. This change unifies us on top of xunit.console (now that it has a
netcoreapp2.0 version available).

* Move unix builds to xunit.runner.console as well

* Get actual directory name, not file

* Fix dir name issue

* fixed build break

* put listener change back in (https://github.com/dotnet/roslyn/pull/24120)

* leave old types in legacy folder until partner teams move to new interface

* added legacy waiter to support partner teams

* Add UseCultureAttribute to help with culture-dependent unit tests

* Disable NuGet package restore in Visual Studio for Roslyn.sln

* Add named argument for literal

* Fix behavior for NET46 and NETCOREAPP2_0

* Revert "moved waiter from diagnostics.dll to features.dll where all interface… (#24120)"

This reverts commit 823d9730.

* Add references to System.IO.Pipes.AccessControl (#24457)

When adding the reference to System.IO.Pipes.AccessControl for the
compiler server to use on CoreCLR, I unified the pathway for the desktop
and CoreCLR server access control code. This means that
System.IO.Pipes.AccessControl needed to be added as a dependent DLL for
desktop too, but I forgot to do that. This change adds
System.IO.Pipes.AccessControl as a dependent DLL in all the places where
the build task is deployed.

This reverts commit 823d9730.

* make sure OOP inherit same culture as VS otherwise culture sensitive resource such as xml doc comment will not work properly

* don't crash on expected issue

* moved waiter from diagnostics.dll to features.dll where all interfaces are defined.

* simplified listener and waiter and moved those in product.

* cleaned up a bit

* fixed some comments

* forgot to add new AsyncListenerProvider in test export composition

* fixed dead lock found on unit tests

* remove all waiters left

* added dispatcher event processing in one more place

* added a way to enable waiter through env variable in test such as DDRIT

* added env var support so that It can be used without internalvisibleTo us.

* dont wait for all waiters but only onces each test used to wait.

* removed dependency to Roslyn.Services.Test.Utilities in integration test. that dll is not in probing path.

* fixed test failures

* fixed bug in integration tests

* move call to enable waiter before creating workspace so that workspace event queue get proper async listener

* expose concret type as well so that it can be directly used in test for waiter

* addressed PR feedbacks.

* rename mess up

* extra ) left out

* fixed build failure

fixed issue where same analyzer reference is installed in both vsix and nuget. deduplication in inproc analyzer manager wasn't present in OOP case. (#23772)

this doesn't address our workitem to merge those two. that work is a separate work item. this just follow what we currently do in proc.