1. 01 3月, 2016 16 次提交
  2. 29 2月, 2016 4 次提交
    • B
      Merge pull request #9200 from balajikris/UseVar-updates · b4a10422
      Balaji Krishnan 提交于
      Use var codestyle updates
      
      Part of #9155
      
      Change summary:
      Implements a fix all provider for the codestyle, and adds corresponding tests.
      Fixes an oversight with previous implementation of detecting built-in types.
      b4a10422
    • B
      Rename. · 2e36a9dc
      Balaji Krishnan 提交于
      2e36a9dc
    • B
      Fix another missed case with the built-in type rule · 77936689
      Balaji Krishnan 提交于
      If the preference is set to "use explicit type for built-in type" and if
      the code is non-compliant (uses var), then we need to flag this case and
      offer a fix.
      
      Basically, this adds to my definition of IsInIntrinsicContext. It is now
      either that the declaration has a predefined type or the declaration
      type is inferred and the inferred type is an intrinsic type.
      
      For the purposes of this feature, we also consider string and object
      to be built-in types, in addition to the actual intrinsic types provided
      by the compiler.
      77936689
    • V
      Extra tests to cover combination of ref returns/locals and conditional access ( ?. ) operator. · 80b5bb11
      vsadov 提交于
      Covering tricky cases where the receiver is a byref and we do not know whether it is of a value or a reference type.
      Those are cases when we do not know statically whether to clone the receiver (to prevent NREs) or pass as byref (for sideeffects propagation into receiver instance).
      80b5bb11
  3. 27 2月, 2016 7 次提交
  4. 26 2月, 2016 8 次提交
    • H
      Merge pull request #9102 from huizhonglong/huizhonglong/get-support-for-squiggles · 75c6753f
      Heejae Chang 提交于
      Get support for squiggles and LB in "AnyCode" workspace
      75c6753f
    • H
      Merge pull request #9201 from heejaechang/fixfilter · baa1111a
      Heejae Chang 提交于
      disable entry filter definition for now.
      baa1111a
    • B
      Fix test baseline. · d83d1459
      Balaji Krishnan 提交于
      These tests were testing that replacement to var works where type is
      apparent. but they also had another rule that said prefer built-in
      types. so i update these tests to not use built-in types and replace
      them with their framework counterparts. That way we're now clearly
      testing if the fix works where type is apparent.
      d83d1459
    • H
      disable entry filter definition for now. · 3143087f
      Heejae Chang 提交于
      the base type we need to use EntryFilterDefinition is exchange type that needs to be moved to immutable dll.
      
      for more detail see https://github.com/dotnet/roslyn/issues/9096
      3143087f
    • B
      Fix a bug with built-in type detection scenario. · 176410b8
      Balaji Krishnan 提交于
      The user option gets style preference for built-in types but the
      implementation checked only for built-in types used _with_ literals on
      the right hand side. I guess I had two different choices in mind - for
      built in types overall, or where we use literals in the right hand side
      and implemented half of both.
      
      Anyway, this clears that up - the option gets the preference for
      built-in types and the implementation checks for predefined types (not
      literals alone).
      176410b8
    • B
      Implement Fix All for Prefer Implicit/Explicit type · 657c54df
      Balaji Krishnan 提交于
      Implement a fix all provider for `Prefer Implicit / Explicit type` code
      style. We simply use the default batchfixer here to fix all nodes which
      don't comply with the user settings.
      
      Notes:
      
      1. we do not differentiate between Notification styles when fixing all
      non-compliant nodes. i.e., say 2 different locations violate the user
      preference, but one has notification level 'warn', while the other has
      notification level 'info', invoking fix-all here will fix both the
      nodes.
      
      In other words, fix-all doesn't differentiate between two nodes that
      have different notification levels or severity levels.
      
      2. this is a given, but still noting it down. we do differentiate
      between nodes with different style preferences. For e.g: say the user
      prefers explicit type for built-in types but implicit type everywhere
      else, the batch fixer would fix only nodes that do not comply with the
      preferences.
      
      3. the current implementation fixes all occurrences of the same kind of
      violation - using explicit type when implicit is preferred or
      vice-versa, however, it does not fix all violations between kinds
      (implicit -> explicit, explicit -> implicit). This is because my current
      implementation has a different diagnostic for each kind of violation.
      Having a single diagnostic and fixer would have been better for this.
      I'll add this to my todo list.
      657c54df
    • H
      Revert the changes on InternalsVisibleToSlnx · d9be35a1
      Huizhong Long 提交于
      d9be35a1
    • A
      Merge pull request #9043 from vslsnap/merge-master-into-future20160223-160016 · 6796d05f
      Artur Spychaj 提交于
      Merge master into future
      6796d05f
  5. 25 2月, 2016 5 次提交