made error list to report Project ID Guid to error list.

we decide to move away from IVsHierarchy and instead use Project Id Guid. we just need some kind of ID to distinguish between different projects. IVsHierarchy is just not right one to use for that purpose.

Make constructor for Location internal

Fixes #1587

Don't recommend type keywords in cref type args

Don't suggest type arguments in VB Crefs

Fix Locals in async lambdas...

Brace Completion honors the Block IndentStyle

We shouldn't ignore custom debug info for a method just because it doesn't contain import records.  It may still contain info about local variable scopes, dynamic info, etc...

Note:  VB did not have a problem with this scenario, but I added a unit test for good measure.

(fixes #2240)

Use IEditorFormattingService to format on commit

Fixes #1468.

Reenable some msbuild workspace tests

Tweak the location of "Add Analyzer"

Bug1735

Enable SmartToken formatting for expression valued properties

The current code attempts to load an arbitrary type from the
FixedBufferAttribute, which represents the type of pointer which
is returned by the fixed buffer field in an unsafe struct. This is
a problem because it is not done with assembly identity unification
and the unification may depend on the current compilation, even though
the type is in metadata.

However, the type of the fixed buffer field is limited to SpecialTypes,
so rather than trying to do unification we can simply load the special
type of the field directly.

Fixes #2385

Reset ExpressionCompiler error message on each retry

The expression compiler was returning a non-null error string in cases
where it succeeded on retry.

Fix usage() in cibuild.sh

Do not accept user custom cultures for /preferreduilang switch.

Tweak the location of the "Add Analyzer" menu items.

Right now the "Add Analyzer" menu items are located immediately below
the "Add Reference" menu item in the top-level Project menu, the project
context menu, and the References node context menu. This places "Add
Analyzer" above "Add Service Reference" and "Add Connected Service".

Logically, references, service references, and connected services are
more closely associated than analyzers. This change moves the "Add
Analyzer" menu item below the others in all of these menus.

Fixes #1289.

Previously, if the user committed completion with semicolon (or another
auto-format triggering character), the completion commit code would run,
followed by the autoformat code. Both features run in places where
multiple edits happen sequentially, so they use
AutomaticCodeChangeMergePolicy when creating undo transactions. However,
this meant that commit followed by format-on-typechar would only produce
one undo transaction.

To avoid this, when committing, completion queries the relevant
IEditorFormattingService to determine if the commit character should
result in formatting, and then uses IEditorFormattingService to format
within a separate undo transaction with the default merge policy (the
command handler for format-on-typechar does essentially the same thing).

This results in two items in the undo stack: one for committing
completion, and one for the format. When the normal formatting command
handler runs, the formatter doesn't produce any changes, so it does
nothing.

Fixes #714.

refactored esent code to support project k and save project name along with project path. this is slightly different than saving context but should fulfill the need.

we will move away from IVsHierarchy and start to use ProjectIdGuid instead.

Fixes #1587

Location is currently a public abstract class. However, since Location is something that can be provided to a Roslyn Diagnostic (via Diagnostic.Create()) supporting arbitrary derived Location types means that Roslyn's analyzer and fixer engines would need to be resilient against arbitrary implemntations that can throw exceptions.

This change makes it impossible to inherit Location externally so that we don't have to do complicated work to guard against such implementations.

There are no known external inheritors of Location at the moment (as far as we are aware). Plus we always have the option to ease this restriction and allow inheritance in the future if we find that there are legitimate use cases for it.

Skip test failing on Mac (#2391)

Handle cancellation tokens correctly in 'fix all occurences'

Skip failing VB emit tests (#2375).

Use the correct cancellation token in 'fix all occurences' and also bail on cancellation in more places in the 'fix all occurences' code path.