- 15 3月, 2018 2 次提交
-
-
由 Julien Couvreur 提交于
-
由 Julien Couvreur 提交于
-
- 14 3月, 2018 6 次提交
-
-
由 Jared Parsons 提交于
Fix our coreclr job definition
-
由 Jared Parsons 提交于
The intent was to create a debug and release leg for our CoreClr tests. Our groovy code though gave both jobs the same name and Jenkins let the last one win. Hence we've only ever been running release CoreClr legs. This changes the definition to give each a separate name.
-
由 Heejae Chang 提交于
fix codeFix info bar behavior and fix AutoProperty to only offer refactoring when it is on right context (#25363) * it looks like codefix info bar has been broken for a while, (since 2016 - https://github.com/dotnet/roslyn/commit/eb5d3f83c07e2494dd5901c07fe8950e23e95b7e#diff-69343eea131fc14c4f6cff1408eb016a) this fixes it to behave correctly. * fix AutoProperty to offer the fix only when it is on right context. * added test * wrong cancellation token is used. it cause refactoring to not cancellable
-
由 Jared Parsons 提交于
Move to the 2.1 SDK
-
由 Jinu 提交于
Use-auto-prop should not be offered if accessors differ in accessibility
-
由 Heejae Chang 提交于
* fixed MEF composition issue. <ImportMany> got left out when listener were changed. and it caused VBSnippetInfo to left out on MEF composition. * removed obsolete waiter types.
-
- 13 3月, 2018 6 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Jared Parsons 提交于
-
由 Julien Couvreur 提交于
-
由 Jason Malinowski 提交于
Refactor CodeModel hookup
-
由 Andy Gocke 提交于
Merge ref reassignment into 15.7
-
由 Jared Parsons 提交于
Fix netcoreapp2.0 use in TestUtilities
-
- 12 3月, 2018 2 次提交
-
-
由 Andy Gocke 提交于
-
由 Andy Gocke 提交于
Add some more tests for semantic model and IDE
-
- 11 3月, 2018 1 次提交
-
-
由 Dustin Campbell 提交于
Add Project.OutputRefFilePath and ProjectInfo.OutputRefFilePath
-
- 10 3月, 2018 22 次提交
-
-
由 Jared Parsons 提交于
This is referenced in the TestUtilities.csproj but for some reason not explicitly copied to the output folder here. Manually adding for now. https://github.com/dotnet/sdk/issues/2035
-
由 Jason Malinowski 提交于
This fails because in unit tests (unlike before) we are now creating a ProjectCodeModel. And now we're calling OnSourceFileRemoved when we try removing files, but the logic to create an actual CodeModelProjectCache is going to fail. If we don't have a cache, that's fine for these because we're only trying to update documents we've already handed out. If we don't have a cache, there's no documents to fix.
-
由 Jason Malinowski 提交于
-
由 Jared Parsons 提交于
-
由 Jason Malinowski 提交于
Hey, if the only thing they're doing now is new ProjectCodeModel, then we can do that in the base types where we're running unit tests anyways. It's harmless unless somebody actually asks for code model.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
It's the only remaining stuff in CSharpProjectShimWithServices, so just move it down a layer.
-
由 Jason Malinowski 提交于
VisualStudioWorkspace had a virtual method to send a call over to the code model logic. Since we now have the requisite interface callable directly, we should just call it directly. It also saves us the trouble of passing a DocumentId only to re-decompose the type again.
-
由 Jared Parsons 提交于
This moves Roslyn to use the 2.1 SDK. This may appear to be moving the SDK version backwards from 2.2 to 2.1. In reality though it is a move forward. There was a brief time when the SDK switched their versions to 2.2 before reverting back to 2.1. Roslyn took a dependency on SDK in that small window. More details available here: https://github.com/dotnet/announcements/issues/57
-
由 Jason Malinowski 提交于
Our CodeModel implementation would go to AbstractProjects and then see if the implemented a special interface IProjectCodeModelProvider to fetch their ProjectCodeModel. This abstraction was pretty leaky: since we're already assuming carnal knowledge of AbstractProject, we can just make it a property that might be null and be done with it. This means we can push some code that is in very derived types (and duplicated) down into a single shared type. At this point, all project system calls flow through IProjectCodeModel, and the only tangling back to AbstractProject is just to do the lookup from project -> IProjectCodeModel. We can now introduce an interface IProjectCodeModelFactory that just maintains that mapping and then suddenly things are really clean.
-
由 Jason Malinowski 提交于
This interface is able to live in our ServicesVisualStudio project and that's what the project systems are able to interact with. This makes the API more like an "optional service" that they can create. Down the road, we can just have an IProjectCodeModelFactory that keeps the implementation entirely separated out.
-
由 Shyam-Gupta 提交于
Merge dev15.7-preview1 to dev15.7.x
-
由 Jason Malinowski 提交于
Now that there's nothing being brought by the inheritence model, we can seal the type.
-
由 Jason Malinowski 提交于
Rather than using inheritence, we only need one factory method. By favoring composition here this will set us up to remove a bunch of derived types. This commit is admittedly strange, as in some cases we now have a child type being created in derived types of AbstractProjectCodeModel. This is just to move things around, and it'll get better in the next commit.
-
由 Dustin Campbell 提交于
-
由 Jared Parsons 提交于
The Roslyn code base defaults to enabling the `<DisableImplicitFrameworkReferences>` property and instead specifies manual references. This is mostly an artifact of our code base evolution from the project.json days where implicit references weren't an option. This means that even though TestUtilities specified netcoreapp2.0 as a TF it was still mostly targeting netstandard1.3. This is because implicit references weren't expanded and we were manually adding only a subset of the available packages. Enabled implicit references here, conditioned the explicit ones to netstandard1.3 and now we can remove a number of `#if` uses. closes #25228
-
由 Sam Harwell 提交于
-
由 Jason Malinowski 提交于
This was being used directly in a lot of places, but I think it's a bit eaiser to follow object relationships if all creation methods go through AbstractProjectCodeModel, and from there might get forwarded. A fair number of checks were being made of whether the CodeModelCache was null; I don't believe these make sense. Once the underlying _codeModelCache type is made non-null, it is never set to null, and the only way it could fail to create in the first place is if the project was never in the ProjectTracker. Given we only produce these once we already have a live AbstractProject, that's not possible.
-
由 Dustin Campbell 提交于
-
由 AlekseyTs 提交于
We can rely on IFormattable instead
-
由 Dustin Campbell 提交于
This change adds an OutputRefFilePath path to the workspace API for the compiler's /refout feature.
-
由 Dustin Campbell 提交于
Adjust indent block operations used for VB smart indent in argument lists
-
- 09 3月, 2018 1 次提交
-
-
由 Tomáš Matoušek 提交于
* Extract common code to a helper method
-