- 16 3月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 14 3月, 2018 2 次提交
-
-
由 Heejae Chang 提交于
fix codeFix info bar behavior and fix AutoProperty to only offer refactoring when it is on right context (#25363) * it looks like codefix info bar has been broken for a while, (since 2016 - https://github.com/dotnet/roslyn/commit/eb5d3f83c07e2494dd5901c07fe8950e23e95b7e#diff-69343eea131fc14c4f6cff1408eb016a) this fixes it to behave correctly. * fix AutoProperty to offer the fix only when it is on right context. * added test * wrong cancellation token is used. it cause refactoring to not cancellable
-
由 Heejae Chang 提交于
* fixed MEF composition issue. <ImportMany> got left out when listener were changed. and it caused VBSnippetInfo to left out on MEF composition. * removed obsolete waiter types.
-
- 13 3月, 2018 3 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Julien Couvreur 提交于
-
由 Cheryl Borley 提交于
Fixes #22278 by restricting the keywords that will trigger the see langword refactoring. Also, prevent see lang refactoring from being offered when already in an XML attribute
-
- 07 3月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* enable logAnalyzerExecutionTime on IDE so that we can start track analyzer perf * removed unnecessary ICodeAnalysisDiagnosticAnalyzerExecutor interface. it was added when OOP is first introduced to make sure VS.Next dll won't get loaded to VS process if OOP is not enabled. when it is enabled by default, rather than removing the interface, implementation just moved down to feature layer to reduce code churn. now, I am properly removing unnecessary abstraction. * take Executor out of test MEF composition * added IRemoteDiagnosticAnalyzerService interface * made initial version working. * added tests * add tracking for inproc only analyzers * pass in diagnostic analyzer service * added open file performance tracking as well. * added PII test * dont hash analyzerId when it is reported by internal user * added link to LOF wiki * made blame to track open files as well. * forgot to add return in if statement * reduce threshold to 100ms decide to start from lower threshold and then iterate rather than start from higher threshold * added a way to log real time perf data in local machine with explicit option which can be used to train formula later * addressed ivan's feedbacks * renamed to ExpensiveAnalyzerInfo * addressed PR feedbacks * more renames * addressed PR feedbacks. renamed as much as I can find. * listener can be null in unit test * addressed PR feedbacks
-
- 06 3月, 2018 1 次提交
-
-
由 Cheryl Borley 提交于
-
- 03 3月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* updated matrix for unreachable code case * more unreachable tests * updated comments * add support for local function
-
- 01 3月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
Fixed a bug where errors from previous analyzer leaking to next analyzer for Workspace Analyzers (#25108) * fixed issue where object got reused between analyzer typescript team found a bug where error from different analyzer is leaked to other analyzer. * added unit test to prevent regression on leaking errors from previous result to next one. * removed duplicated analyzer I added from some testing.
-
- 24 2月, 2018 1 次提交
-
-
由 Omar Tawfik 提交于
-
- 16 2月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* first refactoring to add connection pool * pool added * removed usage of KeepAliveSession which solely used as performance benefit favoring perf over complexity. now with pool, there is no perf advantage by KeepAliveSession. it should be only used when one wants to make connection stateful. * change remote call signature since solution is now set automatically * fixed test failures * made some constant an options. and made pool off by default handle pool shutdown better * now turn it on by default * PR feedbacks * address more PR feedbacks * more comments * renamed ConnectionPool to ConnectionManager. people seems confused by name too much. pool is just one of thing it does, it owns connection management in general. * PR feedbacks * change Contract.Fail to Contract.Require so that it doesn't crash VS when OOP is killed explicitly by users. * PR feedbacks * address feedbacks * put finalizer under debug flag
-
- 15 2月, 2018 10 次提交
-
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
case 'type constraint': no fix offered case 'reference constraint': C# use '==null' instead of 'is null' default: C# 'is null', VB 'IsNothing'
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
-
由 Martin Strecker 提交于
-
由 Cyrus Najmabadi 提交于
Produce warning for VB code. Fix spelling mistake. Add loc files. Fall back to tuples if they're available when making a hashcode. Use System.HashCode if its available. Use 64bit math when computing VB hashcodes in checked contexts. Use full 32 bits for vb hash. Cleanup
-
由 Cyrus Najmabadi 提交于
Move checking of structure-options to a common location (so it will be picked up by all roslyn languages).
-
- 13 2月, 2018 2 次提交
-
-
由 Heejae Chang 提交于
we should remove these once partner moved to new API.
-
由 Heejae Chang 提交于
* removed dead code * added a way to order Document/ProjectDiagnosticAnalyzer. this is to let partner team such as typescript and F# to be able to order their analyzers * use => instead of {get;} = * PR feedbacks
-
- 10 2月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* connected diagnostic service to task status center * PR feedback updated some variable name and string * fixed test break. task status center and service provider doesn't exist in unit test * made GetProject and GetDocument to have same behavior on given ProjectId/DocumentId * addressed PR feedback * forgot to remove optional * moved diagnostic progress reporter out of error list and made its own thing * removed unnecessary service provider * removed ?. and adjust ordering * removed comment * removed debug only info * address PR feedbacks * update on VoidResult * removed blank line * more feedbacks
-
- 09 2月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* fixed a bug on solution crawler progress report. found case where retry can mess up Start/Stop call. instead trying being smart to reduce Start/Stop call, made it simpler and rely on ref counting on reporter. and the fact that all enqeued work must run at some point. * updated comment * renamed and added comments
-
- 06 2月, 2018 1 次提交
-
-
由 Cheryl Borley 提交于
-
- 02 2月, 2018 1 次提交
-
-
由 Cheryl Borley 提交于
-
- 01 2月, 2018 8 次提交
-
-
由 Heejae Chang 提交于
also added RoslynActivityLogger that can be enabled through project-system-tool
-
由 Heejae Chang 提交于
* put listener change back in (https://github.com/dotnet/roslyn/pull/24120) * leave old types in legacy folder until partner teams move to new interface * added legacy waiter to support partner teams
-
由 Oren Novotny 提交于
-
由 Oren Novotny 提交于
-
由 Oren Novotny 提交于
-
由 Oren Novotny 提交于
-
由 Oren Novotny 提交于
-
由 Oren Novotny 提交于
-
- 31 1月, 2018 1 次提交
-
-
由 Julien Couvreur 提交于
-
- 30 1月, 2018 1 次提交
-
-
由 Julien Couvreur 提交于
-
- 27 1月, 2018 2 次提交
-
-
由 Julien Couvreur 提交于
-
由 dotnet bot 提交于
* Add UseCultureAttribute to help with culture-dependent unit tests * Disable NuGet package restore in Visual Studio for Roslyn.sln * Add named argument for literal * Fix behavior for NET46 and NETCOREAPP2_0 * Revert "moved waiter from diagnostics.dll to features.dll where all interface… (#24120)" This reverts commit 823d9730. * Add references to System.IO.Pipes.AccessControl (#24457) When adding the reference to System.IO.Pipes.AccessControl for the compiler server to use on CoreCLR, I unified the pathway for the desktop and CoreCLR server access control code. This means that System.IO.Pipes.AccessControl needed to be added as a dependent DLL for desktop too, but I forgot to do that. This change adds System.IO.Pipes.AccessControl as a dependent DLL in all the places where the build task is deployed.
-