When our projects were last updated to a newer version of Microsoft.Net.ToolsetCompilers, NuGet didn't replace the old version--it just put the new version next to it. Every project ended up referencing both versions, and which set of compiler binaries "won" depended on the order they appeared in the project file. So different projects built with different compilers.

This change strips out all references to the old version. (changeset 1352054)

Remove type constraint on ReplaceNodes API that forces the type of the replacement node to be of the same type as the node to be replaced. (changeset 1352036)

C#: Report a use-site error if it could be a reason for failing to implement a member of an interface. (changeset 1352026)

Add a pre-build script to MicroBuild to have the build servers restore the NuGet packages before building. (changeset 1351423)

C#: Request use-site diagnostics while checking if type caught or thrown derives from System.Exception and report it (the use-site diagnostics) if the check failed. Fixes #132. (changeset 1351406)

This change captures a telemetry data point the first time the Analyzers node or a child analyzer node is expanded in Solution Explorer. The intent is to capture data on how many users interact with this part of Solution Explorer.

Note that for any given node we only capture a data point the first time it is expanded. Collapsing and re-opening the node will not cause further data points to be captured, nor will adding or removing analyzers.

The data point also captures data on the number of analyzers, and the number of diagnostics in an analyzer. (changeset 1351286)

MemberSemanticModel: Acquire nodeMapLock for the entire duration of binding with IncrementalBinder followed by the guardedNodeMap population. This ensures consistency between parent/child statement nodes stored in the map. (changeset 1351235)

changed to use formatedsymbol rather than putting specific error case in ConvertSymbolToString (changeset 1351207)

Rename hasn't yet been updated to handle universal projects/linked files.  This fixes one area where we were crashing when asserting that only a single project was being processed by rename when renaming private members. (changeset 1351196)

CR feedback on the allowing assigning to readonly properties in constructors change. (changeset 1351156)

added 104 as one of special case where we use fully qualified name for symbol in the error message (changeset 1350987)

     This is to help try to debug/log things happening on the TypeScript side.  The current VersionStamp.ToString
     is too coarse grain, and makes it hard to determine order when lots of VersionsStamps appear the same in the
     log (but are actually diferent).

***NO_CI***
 (changeset 1350565)

Fix relative path references to System.Collections.Immutable in CSharp and Basic portable workspaces. (changeset 1349685)

Previously the user had to pass both of these objects to CompilationOptions and the compiler had to call first the resolver to resolve the path specified in #r:

string ResolveReference(string reference, string baseFilePath)

and then the provider to create the reference:

PortableExecutableReference GetReference(string resolvedPath, MetadataReferenceProperties properties)

With this change the compiler simply calls on MetadataReferenceResolver:

ImmutableArray<PortableExecutableReference> ResolveReference(string reference, string baseFilePath, MetadataReferenceProperties properties)

Notice that now the resolver may return multiple references. This is needed to support #r of NuGet packages.

We used reference resolvers and providers in many ways for multiple purposes. I left behind the metadata file resolvers and providers to avoid making too many changes, but made them internal. In some cases the usage is legitimate, but still an implementation detail. More cleanup will also be possible once we remove the old scripting API. For now I have worked around all these dependencies.
 (changeset 1349333)

This change splits the Workspaces layer into two parts, mirroring the Portable/Desktop split that the compilers did. The core parts of the Workspaces layer (managing documents and projects, formatting, some refactoring, code fixes) is kept in the portable subset, with a few non-portable pieces remaining, notably MSBuild support.

This change has a major impact on how MEF now works in Roslyn. Traditional MEF (“MEFv1”) is not portable, and so we must move the Workspaces layer over to using the Microsoft.Composition NuGet package (“MEFv2”) which is. The APIs are distinct in that each has its own namespace, but the concepts are more or less identical. It requires some care though: the workspaces layer is simple in that it only references MEFv2, but higher layers have to reference both versions to use metadata attributes. Exports using metadata attributes from the editor (say, ContentTypeAttribute) must use MEFv1 attributes to export, whereas exports for the workspaces layer must use MEFv2 attributes. The rule is subtle and yet simple, and so a diagnostic is provided which catches any offenses to prevent confusion.

This also has some impact in how we create MEF hosts: if you wish to host just the base workspaces layer, we can use MEFv2 to compose everything. The HostServices implementation (MefV1HostServices) that consumes a MEFv1 ExportProvider. If you’re in Visual Studio, you can use this implementation to get the full set of host services provided in Visual Studio.

Otherwise, most of the changes in here are minor: we react to some APIs that have been moved/renamed in the portable subset we are targeting, and also align our various exception helper utilities with the compiler’s precedent. (changeset 1349276)

The service no longer derives directly from MetadataReferenceProvider. Instead the service exposes API to get metadata references and an instance of compiler reference provider. (changeset 1349108)

Fix bug 990618: Fix spelling of SyntaxKind.BeginCDataToken from "<[CDATA[" to "<![CDATA[". Also fix broken link in VisualBasicSyntaxGenerator.vbproj, removes some redundant code and fixes casing in some VB identifiers. (changeset 1348971)

Implements CR feedback for EmitOptions change: rename EmitOptions.OutputName to OutputNameOverride and adds TolerateErrors and IncludePrivateMembers.  (changeset 1348868)

We insert a null check into the code generated for a delegate
conversion, so that Nothing is converted to Nothing rather
that throwing a null exception.

Note that we continue to generate the incorrect null-throwing
code for conversions appearing in expression trees. We do that
because we don't want to break backward compatibility
(there is no way to translate into the null-check version). (changeset 1348760)

Fixing file IO race condition by always removing test files in-between compilations. (changeset 1348724)

Diagnostic.Severity property used to denote different things for compiler and user diagnostics. For compiler diagnostics, this property denotes the error code severity, i.e. the default severity of the diagnostic. For warnings as errors, this property still returned DiagnosticSeverity.Warning and the consumer had to check for the IsWarnAsError property to get the effective severity. For user diagnostics, this property denotes the effective severity based on the compilation options.

This change makes the following changes:
1) Change Diagnostic.Severity to always represent the effective severity of the diagnostic for both user and compiler diagnostics. So for warn as error, this will return error severity.
2) Introduce Diagnostic.DefaultSeverity to represent the default severity of the diagnostic. This is the error code severity for compiler diagnostics and diagnostic descriptor severity for user diagnostics.
3) Change IsWarningAsError property to return true iff Diagnostic.DefaultSeverity = Warning and Diagnostic.Severity = Error. (changeset 1348667)

     Moves options that were previously on CompilationOptions but were not used until emit phase to EmitOptions: fileAlignment, baseAddress, highEntropyVirtualAddressSpace, subsystemVersion, runtimeMetadataVersion. They hold on values written to various PE headers. We can now easily add other similar PE flags to EmitOptions, which is a common customer request, without affecting code that works with compilation options in other layers (workspaces, project system, etc.).

     Removes EmitMeadataOnly method and instead adds a MetadataOnly flag to EmitOptions. Removes MetadataOnlyEmitOptions - they were not used and can now be easily added as bools to EmitOptions.

     Moves pdbFilePath and outputName from parameters of Emit to EmitOptions.

IDE: remove tracking of options that were moved to EmitOptions, since the IDE doesn't care about options that don't affect compilation. (changeset 1348623)

Renamed the event and property accessor blocks to be consistent with each other and the accessor statements they parent. (changeset 1348603)

Refactors the DoLoopBlockSyntax kinds to be more useful to consumers. Specifically rather than merely identifying whether the loop has a top condition, bottom condition , or no condition, and requiring in the former two cases the caller to inspect the WhileOrUntilClause to determine how to interpret the condition this kind of the block now reflects this and which of the five forms a Do loop may take in VB. This is consistent with the pattern we use for MethodBlocks which have kinds aligned with the kinds of their method statements which are themselves aligned with the method keyword (i.e. Sub or Function). (changeset 1348593)