Co-authored-by: NManish Vasani <mavasani@microsoft.com>
Co-authored-by: NAndrew Hall <ryzngard@live.com>
Co-authored-by: NFred Silberberg <frsilb@microsoft.com>
Co-authored-by: NSam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: NJason Malinowski <jason@jason-m.com>
Co-authored-by: NTomas Matousek <tomat@microsoft.com>
Co-authored-by: NCyrus Najmabadi <cyrus.najmabadi@gmail.com>
Co-authored-by: NJason Malinowski <jason.malinowski@microsoft.com>
Co-authored-by: NSam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: NDavid Barbet <dabarbet@microsoft.com>
Co-authored-by: Nmsftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com>
Co-authored-by: NNeal Gafter <neal.gafter@microsoft.com>
Co-authored-by: NYoussef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: NTomáš Matoušek <tmat@users.noreply.github.com>
Co-authored-by: NRikki Gibson <rigibson@microsoft.com>
Co-authored-by: NFredric Silberberg <frsilb@microsoft.com>
Co-authored-by: NBen Lichtman <belichtm@microsoft.com>
Co-authored-by: NBen Lichtman <uniqueiniquity@users.noreply.github.com>
Co-authored-by: NChris Sienkiewicz <chsienki@microsoft.com>
Co-authored-by: NAllison Chou <allichou@microsoft.com>
Co-authored-by: NDavid Wengier <david.wengier@microsoft.com>
Co-authored-by: NDavid Maas <contact@pathogenstudios.com>
Co-authored-by: NDavid Wengier <dawengie@microsoft.com>
Co-authored-by: NShen Chen <cos_ifne@hotmail.com>
Co-authored-by: NShyam Namboodiripad <gnamboo@microsoft.com>
Co-authored-by: NShen Chen <Cosifne@users.noreply.github.com>
Co-authored-by: NJulien Couvreur <jcouv@users.noreply.github.com>
Co-authored-by: NDavid Wengier <git@wengier.com>
Co-authored-by: NMarco Goertz <mgoertz@microsoft.com>
Co-authored-by: NCharles Stoner <chucks@microsoft.com>

Co-authored-by: NSam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: NManish Vasani <mavasani@microsoft.com>
Co-authored-by: NDavid Barbet <dabarbet@microsoft.com>
Co-authored-by: NJoey Robichaud <jorobich@microsoft.com>
Co-authored-by: NCyrus Najmabadi <cyrus.najmabadi@gmail.com>
Co-authored-by: NDavid Wengier <david.wengier@microsoft.com>
Co-authored-by: NShen Chen <cos_ifne@hotmail.com>
Co-authored-by: Nmsftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com>
Co-authored-by: NSam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: NFredric Silberberg <frsilb@microsoft.com>
Co-authored-by: NGen Lu <gel@microsoft.com>
Co-authored-by: NPetr Onderka <gsvick@gmail.com>
Co-authored-by: NTomáš Matoušek <tmat@users.noreply.github.com>
Co-authored-by: NYoussef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: NCristiano Suzuki <crsuzuki@microsoft.com>
Co-authored-by: NRikki Gibson <rigibson@microsoft.com>
Co-authored-by: NJoey Robichaud <joseph.robichaud@microsoft.com>
Co-authored-by: NYair Halberstadt <yairhalberstadt@gmail.com>
Co-authored-by: NAllison Chou <allichou@microsoft.com>
Co-authored-by: Nmeziantou <meziantou@live.fr>
Co-authored-by: NVritant Bhardwaj <vrbhardw@microsoft.com>
Co-authored-by: NJulien Couvreur <jcouv@users.noreply.github.com>
Co-authored-by: NShen Chen <shech@microsoft.com>
Co-authored-by: NShen Chen <Cosifne@users.noreply.github.com>
Co-authored-by: NChris Sienkiewicz <chsienki@microsoft.com>
Co-authored-by: NJinu <jinuj@microsoft.com>
Co-authored-by: NMarius Ungureanu <therzok@gmail.com>
Co-authored-by: NJason Malinowski <jason.malinowski@microsoft.com>
Co-authored-by: NBen Lichtman <belichtm@microsoft.com>
Co-authored-by: NBen Lichtman <uniqueiniquity@users.noreply.github.com>
Co-authored-by: NDavid Wengier <dawengie@microsoft.com>

Closes #46431

We had left this as a legacy mode for users who were running into
issues. We recently reset the option for anybody using 16.7 builds
after fixing some underlying issues, and we haven't heard any new
issues.

For reasons that aren't entirely clear, when we create a preview of
a code fix, we remove and re-add documents that are being changed when
we produce the PreviewWorkspace. This process had an bug which meant
that the file path of an .editorconfig got dropped, so the resultant
.editorconfig document path was null. This later caused a crash if
the diagnostic engine, when processing the PreviewWorkspace's
new solution, tried asking for a Compilation, since the null path would
get passed to AnalyzerConfig.Parse(), and it would throw.

This was exposed by #45076; until then if you had a preview of just
an .editorconfig file, nothing would actually be analyzed and so
nothing asked for the Compilation. The crash is "fixed" by #44331 in
that asking for a Compilation no longer results in a call to
AnalyzerConfig.Parse(); you have to ask for a Compilation and then do
something with a semantic model. By luck, that doesn't happen in the
common repro, but more obscure things absolutely could still fail.

This is being tested by the integration test being added in #46639. We
don't really have a good unit tests here as far as I can tell, but even
then a unit test really doesn't validate any of the end-to-end here.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1162464