1. 08 12月, 2017 15 次提交
  2. 07 12月, 2017 25 次提交
    • S
      Merge pull request #23458 from sharwell/check-syntax-before-options · 4e44b22e
      Sam Harwell 提交于
      Perform a lightweight syntax check before getting document options
      4e44b22e
    • S
      2466e512
    • J
      Testing theory about %TEMP% · 879ccf0d
      Jared Parsons 提交于
      VS should be inheritting the %TEMP% value we are setting. On the off
      chance it gets the original value though lets copy the props / targets
      files there to see if this is the cause of the hang.
      879ccf0d
    • O
      Move C# tests to testing metadata emitted attributes through `CompileAndVerify` (#22896) · d13df4a3
      Omar Tawfik 提交于
      * Refactored synthesized attributes tests
      
      * Remove rest of calls to CompilationUtils.GetSynthesizedAttributes()
      
      * Fix EE tests
      
      * Fix [Dynamic] tests
      
      * Clean up
      
      * Remove EmitMetadataTestBase.ValidateDeclSecurity(Compilation)
      
      * Remove C# GetDefaultPEBuilder
      
      * Fix Assembly Attributes tests
      
      * Clean up
      
      * Address PR Comments
      
      * Clean up
      d13df4a3
    • J
      Fix xml doc files · 4b7def5e
      Jared Parsons 提交于
      The XML doc files for multi-targetted builds were clashing with each
      other. Both were being written to the raw obj directory. Needs to be
      written to the obj directory with the target framework suffix to avoid
      the clash.
      4b7def5e
    • F
      Updated button text and appearance. · b432b7de
      Fredric Silberberg 提交于
      b432b7de
    • H
      we called work done too early. (#23623) · c08bd5b8
      Heejae Chang 提交于
      previously, we set all work as done when we pass out last work from the queue without waiting that work to be done.
      
      now, we raise works as done only when last item passed out are actually done.
      c08bd5b8
    • J
      Test theory new props caused int failure · dfe65aaa
      Jared Parsons 提交于
      dfe65aaa
    • A
      b5c8c9a3
    • T
      Merge pull request #23620 from tmeschter/MarkInternalToolSetNonShipping · 949c9b4f
      Tom Meschter 提交于
      Mark Toolset projects non-shipping
      949c9b4f
    • J
      Further isolate our msbuild test files · 42912c91
      Jared Parsons 提交于
      This disables a number of places where local developer state could
      influence the result of our MSBuild tests. These are locations where
      MSBuild will wildcard import any files it finds. Using the test
      Directory.Build.props file to disable all these extensibility points.
      42912c91
    • J
      Deploy Dir.build.props / targets in tests · bd5b037e
      Jared Parsons 提交于
      Our MSBuild tests layout project / solution files on disk and then uses
      MSBuild to evaluate them. During this evaluation MSBuild will search for
      Directory.Build.props / targets files on the path just as it will for a
      normal command line build.
      
      On Jenkins our Directory.Build.props / targets is in the search path of
      MSBuild and gets picked up during testing. This was causing our tests to
      fail as we unconditionally override a number of properties in our core
      targets files.
      
      To insulate against this we now deploy and empty version into the
      directory where we generate our solutions.
      bd5b037e
    • J
      Fix deployment of ilasm · 36728509
      Jared Parsons 提交于
      The assembly name of the deployment project was clashing with the ilasm
      exe we were trying to deploy. Gave it an explicit name to remove the
      clashing values.
      36728509
    • J
      Fix publish dir name when no runtime identifier · a07040f0
      Jared Parsons 提交于
      Needed to specify the targetframework portion of the path in the same
      way we specify the runtime identifier portion. Should get simpler when
      we just embrace the layout the SDK is aiming for here.
      a07040f0
    • J
      Generate xml doc files during build · 53003376
      Jared Parsons 提交于
      53003376
    • J
      Fix publish to include runtime identifier in dir · 5111dc0a
      Jared Parsons 提交于
      The publish directory needs to have the runtime identifier prepending to
      the publish directory name. Previously out setting of `<OutputPath>`
      happened early enough that the default logic kicked in. Now though it
      happens too late. Copied the logic which used to set this for us and
      filed a bug to undo all of this later.
      5111dc0a
    • J
      Remove unneeded file SettingsSdk.props · ad01004f
      Jared Parsons 提交于
      ad01004f
    • J
      Add BuildUtil to Roslyn.sln · 669d5ad4
      Jared Parsons 提交于
      This is a standard tool in our repo. Looks like it was just omitted by
      accident when it was originally authored.
      669d5ad4
    • J
      Fix dir structure of BuildUtil · 1c015a71
      Jared Parsons 提交于
      1c015a71
    • J
      Move a fet left over items to new format · 39a96cc7
      Jared Parsons 提交于
      39a96cc7
    • J
      BuildBoss needs to handle empty xmlns · c255441a
      Jared Parsons 提交于
      Our project files are now a mix of empty XMLNS and official MSBuild
      XMLNS. BuildBoss needs to handle both cases.
      c255441a
    • J
      Generated move to the minified MSBuild syntax · a019054f
      Jared Parsons 提交于
      a019054f
    • J
      Reorganize the central build logic · 399f4b3f
      Jared Parsons 提交于
      The combination of the minified MSBuild syntax and Directory.Build.props
      / targets file will change when in the build process our central build
      files are executed. For instance Imports.targets will now be run much
      later in the build after Sdk.targets. Where before, when it manually
      invkoed Sdk.targets it was able to run both before and after it.
      
      To keep our build functioning the same way we need to move around some
      of the logic within our build files so that it executes in the same
      relative order as it did before
      399f4b3f
    • J
      User Roslyn analyzers in all projects · 749ad035
      Jared Parsons 提交于
      The build system used to allow projects to opt out of anaylzers by
      setting the property `$(UseRoslynAnalyzers)` to false before importing
      Settings.props. This meant it occured at the top of the file above all
      other elements, including the main property group block.
      
      This doesn't really have an equivalent approach in the new SDK. There
      is no way to pass a property value from the project file to the
      Directory.Build.props file as it's implicitly imported.
      
      The correct approach in the new SDK would be to do the following:
      
      1. Define `$(UseRoslynAnalyzers)` in main property group block
      1. Use the Roslyn analyzers as a `<PackageReference>` declaration in the
      `Imports.targets` file and have it condition on `$(UseRoslynAnalyzers)`
      not being false.
      
      Doing that is a pretty siginificant rework of our build though. As a
      test I just disabled the analyzers everywhere and found we had a total
      of three warnings. Decided to just fix those as it was very straight
      forward to do.
      749ad035
    • J
      Properly label ILAsm project as exe · c781532a
      Jared Parsons 提交于
      It had conflicting TargetFramework and OutputType annotations
      c781532a