1. 15 3月, 2016 4 次提交
  2. 11 3月, 2016 6 次提交
    • D
      Merge pull request #9660 from DustinCampbell/issue-8412 · 44b03197
      David Kean 提交于
      Fix crash in Inline Rename
      44b03197
    • D
      Fix spelling mistakes in unit test names · 62a8a4ef
      Dustin Campbell 提交于
      62a8a4ef
    • D
      Fix crash in Inline Rename · ffb63164
      Dustin Campbell 提交于
      As the types into an Inline Rename field, the Rename engine attempts to resolve conflicts at each reference. It does this by expanding nodes are the references and then simplifying them down to the smallest node that does not change semantics.
      
      During this process, one of the expansion steps is to add explicit types to lambda parameters that were defined without types. However, the expander wasn't rewriting lambdas with multiple parameters correctly. Essentially, the rewriter assumed that, when replacing a node within a `SeparatedSyntaxList<T>`, the identities of other nodes within the list would not change. However, that's not the case. So, it would successfully replace the first parameter within a lambda's parameter list. However, when it attempted to replace the second parameter, the *original* second parameter could no longer be found in the `SeparatedSyntaxList<T>` because the identity of the second parameter in the list had changed. At this point, `SepratedSyntaxList<T>.Replace(...)` would throw an `ArgumentOutOfRangeException` and VS would crash.
      
      The user scenario is that typing within an Inline Rename field can cause Visual Studio to simply crash, resulting in potenal data loss.
      
      The fix changes the rewriter to not pass the original parameters to `SeparatedSyntaxList<T>.Replace(...)`. Instead, it passes the parameters that are contained when the new list as it builds it up.
      
      This is a regression introduced after Update 1 with PR #6432.
      ffb63164
    • D
      Add failing unit tests for #8412 · 8b547268
      Dustin Campbell 提交于
      8b547268
    • D
      Merge pull request #9578 from tmat/SRM120 · 6049f4f0
      David Kean 提交于
      Update System.Reflection.Metadata to 1.2.0 release
      6049f4f0
    • D
      Merge pull request #9010 from dpoeschl/Fix8139 · b8d7a15f
      David Kean 提交于
      [Stabilization, Crash] Rename: Don't restrict rename project search set for explicit interface implementations
      b8d7a15f
  3. 10 3月, 2016 18 次提交
  4. 09 3月, 2016 4 次提交
  5. 08 3月, 2016 8 次提交