1. 16 9月, 2018 1 次提交
  2. 29 8月, 2018 1 次提交
  3. 28 8月, 2018 1 次提交
    • M
      Address PR Feedback: · a6db5441
      Manish Vasani 提交于
      1. Break the analyzer into two separate diagnostics for flagging unused and unread members. Latter rule has no code fix.
      2. Remove all UI option elements for the added diagnostics and turn the rules off by default for now.
      3. Bail out for invalid operations and syntax errors.
      4. Handle doc comments and nameof - report unread member diagostics instead of unused member diagnostics if referenced in non-read/write context.
      a6db5441
  4. 25 8月, 2018 2 次提交
    • M
      Address PR feedback · c1c54cc9
      Manish Vasani 提交于
      c1c54cc9
    • M
      Add analyzer/fixer to flag and remove unused private members (fields/methods/properties/events) · 76f4c480
      Manish Vasani 提交于
      Analyzer flags two cases: members with no read/writes and members with only writes.
      
      1. Members with no read or writes: `Type '{0}' has an unused private member '{1}' which can be removed.`
      2. Only writes: `Type '{0}' has a private member '{1}' which can be removed as the value assigned to it is never used.`
      
      Code fix removes the unused member declaration.
      Fixes #24225
      
      Open questions:
      1. Current analyzer design uses a single code style option for all members and both the above kinds of unused members. We can potentially have multiple options, but this should probably be done based on feedback.
      2. Should the analyzer use different diagnostic IDs for the above two kinds of unused members? This will mean that the FixAll experience will need multiple iterations for removing unused members.
      3. Should we update the code fix (or have an additional code fix) that also updates the write references for the case (2) above? Or is it better to leave the references to break the code so the user can analyze if the value being assigned can also be removed. The PR current chooses the latter approach as it is more conservative and unlikely to cause silent breaks.
      76f4c480
  5. 15 8月, 2018 1 次提交
  6. 21 7月, 2018 1 次提交
  7. 14 7月, 2018 1 次提交
  8. 27 6月, 2018 1 次提交
  9. 08 6月, 2018 2 次提交
  10. 18 5月, 2018 1 次提交
  11. 04 5月, 2018 1 次提交
  12. 01 5月, 2018 1 次提交
  13. 26 4月, 2018 1 次提交
  14. 12 4月, 2018 2 次提交
  15. 10 4月, 2018 1 次提交
  16. 08 4月, 2018 2 次提交
  17. 06 4月, 2018 2 次提交
  18. 29 3月, 2018 1 次提交
  19. 28 3月, 2018 1 次提交
  20. 19 3月, 2018 1 次提交
  21. 16 3月, 2018 2 次提交
  22. 13 3月, 2018 1 次提交
  23. 23 2月, 2018 1 次提交
  24. 17 2月, 2018 1 次提交
  25. 16 2月, 2018 1 次提交
    • T
      Redesign active statement handling during debugging (#24428) · 11c4bb2f
      Tomáš Matoušek 提交于
      * Active Statement Handling
      
      * Start active statement tracking on background thread
      
      * Ensure XAPI is initialized before calling Concord APIs.
      
      * Fix up and add comments
      
      * Call UninitializeThread in VisualStudioActiveStatementProvider
      
      * Fixes
      
      * PR feedback
      
      * Use dispose pattern for debugger thread initialization
      
      * Finish test
      
      * PR feedback
      
      * Do not track active statements in projects that do not support Roslyn EnC service (e.g. F#)
      
      * Update comment.
      
      * EnC: Report diagnostics for unexpected recoverable exceptions.
      
      * Tweak NFW reporting
      
      * Account for workspace changes in ActiveStatementTagger
      
      * Unsubscribe event in dispose
      
      * Fix initialization of non-remappable regions for unchanged AS in updated method
      
      * Keep non-remappable regions from previous edit session if no edits were made.
      
      * Update xlfs
      
      * Avoid double-free on cancellation
      
      * Avoid calling DkmWorkList.Cancel for now
      
      * Handle active statement without location
      11c4bb2f
  26. 14 2月, 2018 1 次提交
  27. 10 2月, 2018 1 次提交
    • H
      connected diagnostic service to task status center (#24690) · 45f6e9bc
      Heejae Chang 提交于
      * connected diagnostic service to task status center
      
      * PR feedback updated some variable name and string
      
      * fixed test break.
      
      task status center and service provider doesn't exist in unit test
      
      * made GetProject and GetDocument to have same behavior on given ProjectId/DocumentId
      
      * addressed PR feedback
      
      * forgot to remove optional
      
      * moved diagnostic progress reporter out of error list and made its own thing
      
      * removed unnecessary service provider
      
      * removed ?. and adjust ordering
      
      * removed comment
      
      * removed debug only info
      
      * address PR feedbacks
      
      * update on VoidResult
      
      * removed blank line
      
      * more feedbacks
      45f6e9bc
  28. 02 2月, 2018 2 次提交
  29. 27 1月, 2018 1 次提交
  30. 25 1月, 2018 1 次提交
  31. 19 1月, 2018 3 次提交