- 25 2月, 2015 28 次提交
-
-
由 Heejae Chang 提交于
make sure we cancel outside of enumeration
-
由 Andrew Casey 提交于
Add explicit null checks during module lookup
-
由 Andrew Casey 提交于
Improve exception filter parsing error recovery
-
由 Andrew Casey 提交于
When we originally introduced exception filters to C#, we used the if keyword in the filter clause. To avoid confusion with regular if statements, we switched to using the when (contextual) keyword. Unfortunately, the if syntax was around long enough that code with that syntax was stored in the source server database. Now, when you try to debug such files, they parse very badly. In particular, there is a file in the debugger in which thousands of lines of text become skipped text trivia and the resulting syntax tree results in an InsufficientExcecutionStackException whenever that file is displayed. This makes it very difficult to inspect older dumps. A simple solution is to allow the if keyword and replace it with a when keyword with an error attached. With this change applied, the debugger crash is resolved.
-
由 Andrew Casey 提交于
We got a release-build dump with a NRE in a location that didn't make sense. Based on our best guess of what happened (something that should be impossible) add some explicit checks so that we'll get a clearer stack trace if it happens again. No tests since we still believe this is impossible.
-
由 Heejae Chang 提交于
-
由 Kevin Halverson 提交于
Disabling test: ConditionalMemberAccessRace002
-
由 Kevin Halverson 提交于
Failing due to #836
-
由 Paul Harrington 提交于
Reduce allocations from the ConcurrentDictionaries in TypeSymbol interface implementation maps.
-
由 Manish Vasani 提交于
Address couple of issues related to analyzers: 1) Don't crash command line builds when reporting analyzer diagnostics. Reporting analyzer diagnostics may involve invoking user code for LocalizableString message, which may throw while finding resources or for other unknown reasons. We catch exceptions from these callbacks and report a diagnostic with the inner exception message. I verified that this fixes the crash seen in #271 and #813 and we started seeing this new info diagnostic. 2) Workaround for #271: The underlying cause of the crash is that our assembly resolver/CLR is unable to fallback to the main assembly for resources and ends up looking for the satellite resource assembly. We had seen this crash quite a while back, but it went away and this seems to have come up again. Workaround, as applied back then, is to mark the analyzer assembly with NeutralResourcesLanguageAttribute. I verified that adding this attribute to our core analyzer assemblies caused the resource to be correctly found and we don't even see the exception diagnostic from (1) above, but instead the actual diagnostic reported by the analyzer.
-
由 Jason Malinowski 提交于
Disable tests related to GitHub issue #204
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Jason Malinowski 提交于
-
由 Manish Vasani 提交于
Fix #565: Syntax node actions are not called for field declarations in compiler analyzer driver if the declaration defines multiple variables Simplify logic for execution of syntax node actions for field declarations: If there are multiple decls, execute syntax node actions for entire field decl (and its descendants) when processing symbol declared event for first field within it, and skip syntax node actions for rest of fields defined within that declaration. Current logic is unnecessarily complex in that it tries to execute syntax node actions for individual variable declarators when processing corresponding field symbol declared event, and executes the node actions for shared nodes (e.g. defining type syntax node) when processing first field symbol, and caused this bug to sneak through. Added regression tests for compiler driver (VB and C#) and IDE driver.
-
由 Manish Vasani 提交于
Fix #671 to handle broken code case where there are multiple overrides of DiagnosticAnalyzer.SupportedDiagnostics property
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
1) Don't crash command line builds when reporting analyzer diagnostics. Reporting analyzer diagnostics may involve invoking user code for LocalizableString message, which may throw while finding resources or for other unknown reasons. We catch exceptions from these callbacks and report a diagnostic with the inner exception message. I verified that this addressed the crash seen in #271 and #813 and we started seeing this new info diagnostic. 2) Workaround for #271: The underlying cause of the crash is that our assembly resolver/CLR is unable to fallback to the main assembly for resources and ends up looking for the satellite resource assembly. We had seen this crash quite a while back, but it went away and this seems to have come up again. Workaround, as applied back then, is to mark the analyzer assembly with NeutralResourcesLanguageAttribute. I verified that adding this attribute to our core analyzer assemblies caused the resource to be correctly found and we don't even see the exception diagnostic from (1) above, but instead the actual diagnostic reported by the analyzer.
-
由 Kevin Halverson 提交于
Refactor ResultProvider (incorporating Concord API changes)...
-
由 Kevin Halverson 提交于
1. DkmClrValue.InspectionContext has been removed, so a separate instance needs to be passed to all the methods that need it. 2. DkmClrValue.EvaluateDebuggerDisplayString is now async. In order to avoid complicated plumbing of completion routines through result expansion, I've moved the creation of DkmEvaluationResults from *Expansion to the ResultProvider. Expansion now produces EvalResultDataItems that contain all the information necessary to produce DkmEvaluatoinResults in a single place, just before returning from the ResultProvider entry points. New async plumbing/Exception handling is localized to the entry points. 3. There are several places that the API now allows passing format specifiers. We do not intend to support those scenarios in C#/VB, so we will ignore them.
-
由 Paul Harrington 提交于
Use TryGetValue followed by TryAdd to avoid delegate allocation.
-
由 Balaji 提交于
Make OutliningSpan Creation not assume MultiLine Comment always end with...
-
由 Dustin Campbell 提交于
Make VB Remove Unnecessary Cast a bit smarter in interpolations
-
由 Balaji Soundrarajan 提交于
Fixes #791: The code '\*' is parsed as MultiLine Comment even with the presence of the corresponding '*\' in some cases. Hence, OutLining Span creator should not assume that '*\' will always be present for Multiline Comment and handle the creation appropriately
-
由 Andrew Casey 提交于
-
由 Dustin Campbell 提交于
-
由 Tom Meschter 提交于
Handle AssemblyResolve events when the requesting assembly is unknown
-
- 24 2月, 2015 12 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Fix for #565: Syntax node actions are not called for field declarations in compiler analyzer driver if the declaration defines multiple variables Simplify logic for execution of syntax node actions for field declarations: If there are multiple decls, execute syntax node actions for entire field decl (and its descendants) when processing symbol declared event for first field within it, and skip syntax node actions for rest of fields defined within that declaration. Current logic is unnecessarily complex in that it tries to execute syntax node actions for individual variable declarators when processing corresponding field symbol declared event, and executes the node actions for shared nodes (e.g. defining type syntax node) when processing first field symbol.
-
由 Manish Vasani 提交于
Fine tune analyzer re-analysis trigger during compilation end action computation. This gets us to the behavior before AnalyzerManager refactoring where we won't perform force analysis of all documents for compiler diagnostic analyzer end action diagnostics. @heejaechang this should fix the performance regression.
-
由 David Poeschl 提交于
Remove open deployment dependence on telemetry
-
由 David Poeschl 提交于
Fix for internal TFS bug 1128536 When open-only builds of Roslyn are deployed to the RoslynDev hive, there is no telemetry service hooked up, so we no longer assume one exists.
-
由 Andy Gocke 提交于
-
由 Andy Gocke 提交于
This moves the existing tasks into the source repository for Roslyn, as Roslyn owns the C# and VB MSBuild tasks.
-
由 Paul Harrington 提交于
Avoid over-allocation in VB TypeSymbol's ImplementationForInterfaceMemberMap
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Paul Harrington 提交于
Avoid over-allocation in C# TypeSymbol's InterfaceInfo map.
-
由 Andrew Casey 提交于
Remove workaround for DevDiv #1004487.
-