Warn when inlining a temporary into a conditional

Make sure we Dispose() the options processor of CPS projects

* Update dependencies from https://github.com/dotnet/arcade build 20190904.31

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19454.31

* Update dependencies from https://github.com/dotnet/arcade build 20190905.21

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19455.21

Fix violations of xUnit analyzers

Added comments here and there.

Adjust inconsistent accessibility checks to properly handle protected types declared within interfaces. (#38451)

Fixes #38398.

Fix underselection problem in invertlogical refactoring.

Add comment to document the use of the variables in the signed build yml

Use shim for c#/vb liveshare gotodef, leave typescript as custom impl…

Adjust dependency tracking for types with respect to added ability to nest types into interfaces. (#38494)

Adjust dependency tracking for types with respect to added ability to nest types into interfaces.

Related to #34704.

**We used to have the following rules:**

"When a class B derives from a class A, it is a compile-time error for A to depend on B. A class **directly depends on** its direct base class (if any) and **directly depends on** the ~~**class**~~ within which it is immediately nested (if any). Given this definition, the complete set of ~~**classes**~~ upon which a class depends is the reflexive and transitive closure of the **directly depends on** relationship."

It is a compile-time error for an interface to directly or indirectly inherit from itself.
The **base interfaces** of an interface are the explicit base interfaces and their base interfaces. In other words, the set of base interfaces is the complete transitive closure of the explicit base interfaces, their explicit base interfaces, and so on.

**Since we added ability to nest types into interfaces, we are adjusting them as follows:**

When a class B derives from a class A, it is a compile-time error for A to depend on B. A class **directly depends on** its direct base class (if any) and **directly depends on** the _**type**_ within which it is immediately nested (if any).

When an interface IB extends an interface IA, it is a compile-time error for IA to depend on IB. An interface **directly depends on** its direct base interfaces (if any) and **directly depends on** the type within which it is immediately nested (if any).

Given these definitions, the complete set of **types** upon which a type depends is the reflexive and transitive closure of the **directly depends on** relationship.

- Fixes https://github.com/dotnet/roslyn/issues/38443
- Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/951410

Co-Authored-By: NDavid <dibarbet@gmail.com>

Don't offer Introduce local for expression statement if expr. stm is assignment.

Some violations were us approximating theories, so this just converts
to using theories.

Exclude textual changes made in unchangeable document

Nullable annotations refactoring helpers & bits and pieces elsewhere

Disposer cleanup for pooled objects.

Collapse redundant types in the server part 2

Co-Authored-By: NSam Harwell <sam@tunnelvisionlabs.com>

I'm not sure if this is exactly where we want to do the caching, so I've
taken the opportunity to make all the non-core AnalyzerConfig APIs internal.
There are no existing consumers depending on them, so this is not a breaking
change.

Fixes #38426

VB: Check for script context in '#R' directive recommender

This flags call to Assert.IsType/Assert.IsNotType where the given type
is an abstract type. In those cases IsNotType passes (but doesn't
ever assert anything) and IsType will always fail.

Co-Authored-By: NCyrusNajmabadi <cyrus.najmabadi@gmail.com>