1. 29 5月, 2015 1 次提交
  2. 28 5月, 2015 2 次提交
  3. 27 5月, 2015 7 次提交
    • H
      Merge pull request #3045 from heejaechang/vsixfix2 · 83c9c9bd
      Heejae Chang 提交于
      changed sign method from vsix to vsixSHA2
      83c9c9bd
    • T
      Merge pull request #3047 from tmeschter/Fix3020 · 707645ff
      Tom Meschter 提交于
      Prevent spurious warnings about missing dependencies.
      
      **Bug:** Fixes #3020.
      
      **Customer Scenario**
      1. User adds any analyzer assembly that includes a code fix to their project (e.g.,  Microsoft.CodeAnalysis.FxCopAnalyzers.dll or Microsoft.CodeAnalysis.CSharp.FxCopAnalyzers.dll).
      2. Users saves their project and restarts VS.
      3. User reopens the same project.
      4. User gets spurious warnings about 'System.Composition.AttributedModel' not being found and analyzers possibly not working. Closing and reopening the project sometimes helps, but more often than not the warnings show up.
      
      **Fix Description**
      The fix updates the `AnalyzerDependencyChecker` to allow whitelisting arbitrary sets of assemblies, not just those already loaded. This is used to then whitelist all assemblies with a name starting with "System" on the assumption that even if they are not already loaded they will in fact be found if needed. If an analyzer reference appears on any whitelist we won't report it as missing, even if we don't know where it is.
      
      **Testing**
      I tested the customer scenario listed above, and also tested that missing assemblies that *don't* start with 'System' as still reported.
      707645ff
    • A
      Merge pull request #3037 from AlekseyTs/Issue2903 · 8ea2a5ed
      AlekseyTs 提交于
      Respect ParamArray attribute in source on a delegate parameter.
      8ea2a5ed
    • K
      Merge pull request #3052 from KevinH-MS/stabilization · a143c903
      Kevin Halverson 提交于
      Fix DataTips in Web apps...
      
      (fixes #2916)
      a143c903
    • K
      Fix DataTips in Web apps... · e77b1373
      Kevin Halverson 提交于
      We were previously attempting to match spans in the subject buffer with "Length == 1".  This was incorrect, because the input span is always expected to be zero length in GetDataTipText.  I've fixed the check and added an Assert to this effect.
      e77b1373
    • N
      Merge pull request #3048 from gafter/sandstone-stabilization · 1d6bac73
      Neal Gafter 提交于
      Remove an unused test resource.
      1d6bac73
    • T
      Merge pull request #3029 from tmeschter/Fix2707 · d2308b2f
      Tom Meschter 提交于
      Reload analyzers with loading errors.
      
      **Bug:** Fixes #2707.
      
      **Customer Scenario**
      User adds an analyzer to their project in VS without first adding all of the dependencies. E.g., they add Microsoft.CodeAnalysis.CSharp.FxCopAnalyzers without first adding Microsoft.CodeAnalysis.FxCopAnalyzers.
      
      The Error List will show various warnings about missing analyzer assemblies and being unable to load diagnostic analyzers from Microsoft.CodeAnalysis.CSharp.FxCopAnalyzers. This is correct and expected.
      
      The user then adds the missing analyzer assembly, expecting the warnings to go away and the diagnostics to start working. Instead, the warnings remain, and the diagnostics still do not work.
      
      **Fix**
      The issue is that an `AnalyzerFileReference` only looks for
      `DiagnosticAnalyzers` once, and caches the results. So even though we
      add the missing dependency and *could* load the types, we don't actually
      try.
      
      The fix is in the logic to add a new analyzer assembly in VS. In
      addition to pushing a new `AnalyzerFileReference` down to the workspace,
      we examine the list of existing analyzers. For each one with load
      errors we remove the existing `AnalyzerFileReference` and add a new one.
      
      **Testing**
      I ran through the Customer Scenario described above.
      d2308b2f
  4. 26 5月, 2015 2 次提交
  5. 24 5月, 2015 3 次提交
    • J
      Merge pull request #3044 from jmarolf/FxCopStable · c452b514
      Jonathon Marolf 提交于
      renaming the fxcop binaries and making them portable.
      c452b514
    • D
      Merge pull request #3057 from dpoeschl/FixNavigationBarCrashPort · 25f9ecef
      David Poeschl 提交于
      Stabilization Port -- NavBar: Guard against symbol navigation on non-symbol items
      25f9ecef
    • D
      NavBar: Guard against symbol navigation on non-symbol items · 1303ece0
      David Poeschl 提交于
      Fixes internal TFS bug #1174848
      
      When a Navigation Bar item is chosen, like the NavigationBarSymbolItem
      representing a particular member, we present the set of chosen items
      (for project, type, and member) as base NavigationBarItems with the text
      display properties & tracking spans *copied* out of the real
      NavigationBarSymbolItem to remove any display indentation and to make
      sure the Navigation Bar does not hold on to old symbols, etc.
      When the Navigation Bar is expanded, we present real
      NavigationBarSymbolItems again and when they are chosen we perform the
      appropriate symbolic navigation.
      
      However, there is a moment after an item is chosen where we have
      replaced the real NavigationBarSymbolItem with its NavigationBarItem
      copy, but the Navigation Bar is still allowing clicks to the item to
      count as navigation (rather than expansion of the collapsed list). When
      this happens, we see NavigateToItem called on a base NavigationBarItem
      and crash because we believe it will be a NavigationBarSymbolItem.
      
      The base NavigationBarItem was being used for multiple purposes, so this
      change makes it abstract and introduces NavigationBarPresentedItem for the
      purposes described above and NavigationBarActionlessItem which can be used
      for items that legitimately produce no action when selected (used in some
      VB event scenarios). The NavigationBarController now rejects any attempts
      to select a NavigationBarPresentedItem so that the
      INavigationBarItemService implementers will not have to deal with them.
      
      VB was already avoiding this problem by typechecking the
      NavigationBarItem, and this change also applies the same type check to
      C#.
      1303ece0
  6. 23 5月, 2015 25 次提交