1. 23 5月, 2015 20 次提交
  2. 22 5月, 2015 19 次提交
  3. 21 5月, 2015 1 次提交
    • T
      Merge pull request #2946 from tmeschter/Fix1579 · a5497dc3
      Tom Meschter 提交于
      Generate relative paths correctly.
      
      **Bug:** Fixes #1579.
      
      **Customer Scenario:**
      The customer wishes to use a shared rule set file in their project to control their diagnostics. The .ruleset file is at the root of their solution, so the customer adds it to their project as a linked file. They then set it as the active rule set by right-clicking on the file in Solution Explorer and selecting "Set as Active Rule Set".
      
      The file should become the active rule set for the project, turning various diagnostics on or off or altering their severity. Instead the customer gets an error in the Error List: "The file '..\\..\\..\\Rule.ruleset' cannot be found" and the rule set has no effect.
      
      **Fix:**
      When adding `..` to the relative path to backup to higher-level directories, we effectively add each one multiple times. The fix is to stop doing that.
      
      **Testing:**
      I manually tested the following variation on the original scenario:
      
      * Rule set file in the same directory as the project file
      * Rule set file one level above the project file
      * Rule set file two levels above the project file
      * Rule set file up two levels and then down in a subdirectory
      * Rule set file one level below the project file
      * Rule set file two levels below the project file
      * Rule set file on a different directory
      
      and verified that in each case the project file ends up with the correct path, and that the rule set takes effect as expected.
      
      I also added unit tests to exercise the affected code.
      a5497dc3