1. 14 2月, 2020 1 次提交
  2. 12 2月, 2020 3 次提交
  3. 11 2月, 2020 2 次提交
  4. 08 2月, 2020 3 次提交
  5. 07 2月, 2020 2 次提交
    • J
      Use NETCOREAPP · 2f302873
      Jared Parsons 提交于
      This changes all of our uses of `NETCOREAPP3_1` to `NETCOREAPP`. There
      is no value in distinguishing the exact .NET Core version we use in our
      source tree as we only target one version. Also going forward it's not
      expected that our .NET Core specific code will be version specific. If
      that arises we can go back to version specific defines for those cases.
      
      This also removes the last references to `netcoreapp1.1`,
      `netcoreapp2.1` and `netcoreapp3.0` from our code.
      2f302873
    • G
      Fix SourceBuild · e3815c3f
      Gen Lu 提交于
      e3815c3f
  6. 06 2月, 2020 6 次提交
  7. 05 2月, 2020 7 次提交
  8. 04 2月, 2020 6 次提交
  9. 02 2月, 2020 1 次提交
  10. 01 2月, 2020 1 次提交
  11. 31 1月, 2020 8 次提交
    • S
      Make ValueText return empty instead of null · 10f524e8
      Sam Harwell 提交于
      Closes #41304
      10f524e8
    • S
      Remove unnecessary using directive · 852d37e7
      Sam Harwell 提交于
      852d37e7
    • J
      Change annotation on WithSpecificDiagnosticOptions · 96cad612
      Jason Malinowski 提交于
      This API has always accepted null as a shortcut for an empty array, so
      this annotates it accordingly.
      96cad612
    • J
      Fixup nullable annotation · 5a0b78c9
      Jared Parsons 提交于
      Had to clean up a few nullable annotations now that we are compiling
      agaist `netcoreapp3.1` and hence get the full value of the framework
      annotations.
      
      This is also problematic though because there are now two places where
      the compiler can see nullable attributes that are directly used by the
      developer. For example `NotNullWhenAttribute`. This is both defined in
      our assemblies for non-netcoreapp target frameworks and provided by the
      SDK when targeting `netcoreapp3.1`.
      
      This causes a problem for assemblies which have the following
      characteristics:
      
      1. Target `netcoreapp3.1`
      1. Reference an assembly targeting `netstandard2.0` which uses our
      nullable attributes definition
      1. Has IVT into (2) above
      
      These properties essentially define all of our unit test assemblies. In
      that environment it's not possible to use nullable attributes in code
      because the compiler can't disambiguate which definition of
      `NotNullWhenAttribute` to use. This meant I had to temporarily remove a
      few attributes until we can complete #40766.
      5a0b78c9
    • J
      PR feedback · e1155098
      Jared Parsons 提交于
      e1155098
    • J
      Fixed build correctness · 5184394d
      Jared Parsons 提交于
      5184394d
    • J
      PR feedback · 5b6d3ee9
      Jared Parsons 提交于
      5b6d3ee9
    • J
      Clean up remaining test failures · 453cadbc
      Jared Parsons 提交于
      453cadbc