* Add reproducer for #34872

* Fix bug and add test

* WIP

* Test similar scenario in VB

* Add void check in ClassifyConversionFromType, update tuple tests

* Cleanup

* Don't emit readonly attributes on members within readonly structs

* Check ContainingType.IsReadOnly before EnsureIsReadOnlyAttributeExists just for consistency

Improve diagnostic messaging for unused value assignment and unused p…

* Symbol display for readonly members

* Add coverage

* Test malformed properties and events

* Show readonly keyword on non-field members in QuickInfo

* Use IsDeclaredReadOnly for symbol display (WIP)

* Update based on design and fix some test failures

* Add readonly keywords to various IL tests

* Fix more tests, respond to feedback

* Fix compile error

* Don't display readonly keyword for implicit readonly getters from source

* Don't show readonly keyword for members contained within a readonly struct

* Move from extension methods to private statics

Merge release/dev16.1 to master

* Nullable Deconstruction in foreach loops:
- Visit deconstruction in foreach loops, rather than handling it directly
- Add tests

Implements a design change where overrides are allowed to change the
type of the member as long as there is an implicit nullable reference
conversion from the overriding type to the overridden type according to
the nullable variance rules.

Fixes #23268
Fixes #30958

Fix yaml to pick up full branch name

Related to #32054.

* Support TimeTravelTraceInterop in function resolver.

- The function resolver isn't loaded when the base monitor is
TimeTravelTraceInterop, which needs it to resolve function for function
breakpoint.
- To add TimeTravelTraceInterop to the right vsdconfigxml file, I also
need to update some package so that it can be built.

* Address PR feedback.

- PrivateVisualStudioPackage isn't necessary since I set PrivateAssets=true in the package reference.

Closes #28834.
Closes #30061.

Fixes #35203

1. Improve the message for unused value assignment diagnostic to make it clear that we are flagging an unnecessary assignment, not an unused variable
2. Add descriptions for unused value assignment and unused parameter diagnostics to allow users to specify special discard symbol names that are respected by the analyzer. There are various cases where user wants to retain unused parameters (signature compat, documentation) and unnecessary assignments to locals (ease of debugging), but do not want to blanket suppress these diagnostics.

Fix typo in OptProf test name

IntelliCode duplicate items inhibit Ctrl+Space

Use new CoreFX API for creating NamedPipeServerStreams

Fix typo in the test class name
https://devdiv.visualstudio.com/DevDiv/_git/VS?path=%2Fsrc%2FTests%2FManagedLangs%2FOptProfTests.cs&version=GBmaster&line=15&lineStyle=plain&lineEnd=16&lineStartColumn=1&lineEndColumn=1

Avoid caching VS completion item

Add import completion telemetry

Fix razor completion

Allow `ignore spaces around declaration` to work when `preserve single line statements` is set to false (#34959)

* Add tests for 31868

* interim fix

* Fix check for flag

* perf tweak to run OpenFileOnly analyzers only for open files even if full solution analysis is on but run for closed files for fix all.

also made add using test to excerice OOP code properly

* addressed PR feedbacks

* added more comments

- Allow ```base(object)``` in interfaces
- System.Object members should be available of off ```base(<some interface type>)```.

🔼 Compute indices when OOP is disabled

The default behavior for the NamedPipeServerStream API is to take a pipe
name and then construct a named pipe in the background using that name.
In Windows this involves creating a file in a special namespace in the
file system. On Unix, named pipes are implemented using Unix Domain
Sockets, which are actual files, and the CoreFX behavior is to create
them in the temporary directory. Unfortunately, Unix Domain Sockets also
often have a max path length limitation and the temporary directory
could be arbitrarily long, meaning that any attempt to create a named
pipe may fail on Unix.

To remedy this, CoreFX introduced an API which allows you to pass a full
path instead of just a pipe name. If a fully-qualifed path is passed,
the new behavior is used. We can use this functionality to improve
reliability of pipe name creation by using the "/tmp" directory on Unix,
which by the POSIX specification is always required to be a valid
temporary directory, and by using a fixed-length pipe name that is lower
than any known Unix Domain Socket path length restriction.

This should fix the issue for good.

Fixes #24137

Ensure unimplemented interface members are reported even in presence of unification warnings (#35422)

This reverts commit 0eb155df.