We believe failing to do so is resulting in an ObjectDisposedException:

at Microsoft.VisualStudio.Debugger.Clr.DkmClrAppDomain.get_Id()
at
Microsoft.CodeAnalysis.ExpressionEvaluator.DkmUtilities.<>c__DisplayClass2_0.<GetModulesInAppDomain>b__0(DkmClrModuleInstance
module)
at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
at
Microsoft.CodeAnalysis.ExpressionEvaluator.DkmUtilities.GetMetadataBlocks(DkmClrRuntimeInstance
runtime; DkmClrAppDomain appDomain)
at
Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.CSharpInstructionDecoder.GetCompilation(DkmClrModuleInstance
moduleInstance)
at
Microsoft.CodeAnalysis.ExpressionEvaluator.FrameDecoder`5.GetNameWithGenericTypeArguments(DkmInspectionContext
inspectionContext; DkmWorkList workList; DkmStackWalkFrame frame; Action`1
onSuccess; Action`1 onFailure)
at
Microsoft.CodeAnalysis.ExpressionEvaluator.FrameDecoder`5.Microsoft.VisualStudio.Debugger.ComponentInterfaces.IDkmLanguageFrameDecoder.GetFrameName(DkmInspectionContext
inspectionContext; DkmWorkList workList; DkmStackWalkFrame frame;
DkmVari...

...because of an invalid identifier.  Since the ResultProvider controls
everything else about the full name, it is only identifiers that can
contain invalid syntax.

Note that this will generally suppress Add Watch on descendents of
affected nodes as well (since the structure is mostly recursive).

Fixes #3272.

It's confusing for new users to have the Roslyn solutions nested
inside the src/ directory and there's really no good reason those where
there in the first place. This moves them to the root directory, except
for the Toolset.sln solution, which is only for building Roslyn in CI
scenarios and has been moved to the build/ directory.

Fixes a typo in the summary of SyntaxGenerator.ThrowStatement

The VsSdk changed to specifically exclude System.Collections.Immutable and
System.Reflection.Metadata from the output vsix so we'll have to mark them
<ForceIncludeInVSIX>true</ForceIncludeInVSIX>.

(fixes #3687)

Issue: NulReferenceException encountered when attempting to get QuickInfo for a JS script block in a .cshtml document.
Fix: Check to see if the linkedDocument supports syntax tree before attempting to retrieve the syntax root.  If it doesn't return the default SyntaxToken.

also increase higher priority queue timeout to 800ms.

document.Project.LanguageServices.GetService().GetAdditionalReferencesAsync(document, symbol, cancellationToken)
throws a null reference exception.

Adding the null check to support this scenario.

It turns out my test wasn't doing what I thought it was (it was parsing as SourceCodeKind.Regular).  We don't want to treat top level statments in scripting as a containing member for the purposes of calculating the current block.

Fix the binding redirection range. For official builds we were only
redirection version 0.7.0.0 to version 1.1.0.0, rather than redirecting
everything in the range 0.7.0.0-1.1.0.0.

Also, since the old version bounds are always going to be the same, we
should just define them once.

Previously, I didn't realize that GlobalStatements in C# were separate from top level declarations with an initializer.  The old code handled GlobalStatements, but it was doing a lot of unnecessary work.  Also, I didn't have tests for this case.

Add DiagnosticDescriptor.GetEffectiveSeverity(CompilationOptions) API to get the effective severity of diagnostics created based on the descriptor for the given compilation options.

This change also removes the clone of this functionality in the IDE layer used by the solution explorer rule severity display and error list/diagnostic service. It now uses this public API.

Fixes #2598

These methods are an implementation detail and do not have pdb information associated with them.  Therefore, you cannot navigate to their implementation, and we should hide them in the Call Stack Window.

It doesn't make sense to have both ReferenceOutputAssembly=false and
IncludeOutputGroupsInVSIX=BuildProjectOutputGroup.  (The upshot is that
the affected references end up in the VSIX unsigned.)

Reduces the number of unsigned assemblies (exes remain but are handled
differently).

In a switch's default clause that is unexpected, for example, we should
    throw ExceptionUtilities.UnexpectedValue(value);
Long ago this was a standard but we've drifted from it.
Closes #3495

Currently, we report analyzer diagnostics and the exception diagnostics for any exceptions produced by the analyzer at the same time. However, reporting the analyzer diagnostics itself (i.e. GetMessage invocation) may cause an exception and add to the exception diagnostics. We ended up not reporting these exception diagnostics.

Fix is to delay reporting the analyzer exception diagnostics, until we have reported all analyzer diagnostics.

Fixes #1759

When we optimistically load a "LINQ library", prefer to load System.Linq (and then fall back to System.Core if that fails).

Fixes #2985.

Fixes #3337 (errorlog JSON output should escape backslashes)

The analyzer can report three different diagnostics, but currently only
returns two from the `SupportedDiagnostics` property.