1. 20 7月, 2019 1 次提交
  2. 23 1月, 2019 1 次提交
    • M
      Add bail out cases for unused members analyzer · ab7a6536
      Manish Vasani 提交于
      1. Usages as an argument to `nameof`: We have multiple reports of these being false positives in presence of reflection based usages and in variour test frameworks. Fixes #32488.
      2. Presence of 'dynamic' in C# - Conservatively bail out in presence of any dynamic operations. Fixes #32522.
      ab7a6536
  3. 15 12月, 2018 1 次提交
  4. 07 12月, 2018 2 次提交
  5. 06 11月, 2018 1 次提交
    • M
      Workaround in RemoveUnusedMembersDiagnosticAnalyzer for VB handles clause · ad24a9cb
      Manish Vasani 提交于
      Fixes #30895
      
      This analyzer does not function correctly in presence of VB handles clause due to IOperation bugs #30978 and #30979. This change adds a temporary workaround to the analyzer to handle this case specially.
      
      TODO: File a bug to track reverting the temporary workaround once #30978 and #30979 are fixed.
      ad24a9cb
  6. 10 10月, 2018 3 次提交
  7. 14 9月, 2018 3 次提交
  8. 29 8月, 2018 2 次提交
  9. 28 8月, 2018 1 次提交
    • M
      Address PR Feedback: · a6db5441
      Manish Vasani 提交于
      1. Break the analyzer into two separate diagnostics for flagging unused and unread members. Latter rule has no code fix.
      2. Remove all UI option elements for the added diagnostics and turn the rules off by default for now.
      3. Bail out for invalid operations and syntax errors.
      4. Handle doc comments and nameof - report unread member diagostics instead of unused member diagnostics if referenced in non-read/write context.
      a6db5441
  10. 25 8月, 2018 2 次提交
    • M
      Address PR feedback · c1c54cc9
      Manish Vasani 提交于
      c1c54cc9
    • M
      Add analyzer/fixer to flag and remove unused private members (fields/methods/properties/events) · 76f4c480
      Manish Vasani 提交于
      Analyzer flags two cases: members with no read/writes and members with only writes.
      
      1. Members with no read or writes: `Type '{0}' has an unused private member '{1}' which can be removed.`
      2. Only writes: `Type '{0}' has a private member '{1}' which can be removed as the value assigned to it is never used.`
      
      Code fix removes the unused member declaration.
      Fixes #24225
      
      Open questions:
      1. Current analyzer design uses a single code style option for all members and both the above kinds of unused members. We can potentially have multiple options, but this should probably be done based on feedback.
      2. Should the analyzer use different diagnostic IDs for the above two kinds of unused members? This will mean that the FixAll experience will need multiple iterations for removing unused members.
      3. Should we update the code fix (or have an additional code fix) that also updates the write references for the case (2) above? Or is it better to leave the references to break the code so the user can analyze if the value being assigned can also be removed. The PR current chooses the latter approach as it is more conservative and unlikely to cause silent breaks.
      76f4c480