1. 31 1月, 2020 10 次提交
    • J
      Responded to PR feedback · 7273097f
      Jared Parsons 提交于
      7273097f
    • J
      Restore TF order · 84525615
      Jared Parsons 提交于
      84525615
    • J
      Remove unnecessary 2.1 install · 5b54fdcc
      Jared Parsons 提交于
      5b54fdcc
    • J
      Clean up remaining test failures · 453cadbc
      Jared Parsons 提交于
      453cadbc
    • J
      Fix MS.VB reference · a3add60f
      Jared Parsons 提交于
      The TPA now considers the output directory as a trusted place for
      loading assemblies. To the point it will prefer certain DLLs in the
      output directory over equal ones that ship with the runtime.
      
      This broke a number of VB tests here because we unconditionally
      referenced the desktop version of Microsoft.VisualBasic. This got copied
      to the output directory, included in the TPA and hence loaded during
      test execution. This breaks tests because they require the .NET Core
      version of Microsoft.VisualBasic.
      
      Conditioned the reference to be desktop only so it's not present on our
      .NET Core builds
      a3add60f
    • J
      Remove RoslynNetCoreTargetFramework · 72b58c94
      Jared Parsons 提交于
      Decided to remove the property based approach to specifying a target
      framework to just specifying `netcoreapp3.1` directly. The reason for
      this is the following:
      
      The advantage of the property is it makes it "easy" to change to a new
      target framework in the future. That benefit is actually pretty minimal.
      A simple find and replace operation is **extremely** effective in our
      code base (it's less key strokes than this message). Hence the benefit
      is minimal.
      
      The downside of the property is that our code doesn't look like customer
      code. Or rather it diverges from the practices that we publish. In
      general I prefer to keep our code as standard as possible unless there
      is a good reason to deviate. There just doesn't seem to be one here.
      72b58c94
    • J
      Test Work · 5ecae05e
      Jared Parsons 提交于
      5ecae05e
    • J
    • J
      Move to target netcoreapp3.1 · 98da1837
      Jared Parsons 提交于
      Change Roslyn to target netcoreapp3.1 when building .NET Core assets.
      
      Previously the code targetted a mix of netcoreapp2.1 and netcoreapp3.0.
      The mix is due to default interfaces only being supported on
      netcoreapp3.0 and hence our testing needed to use that. Yet at the same
      time we were required to ship the compiler in SDKS that targetted
      netcoreapp2.1. Now we can universally target netcoreapp3.1.
      98da1837
    • J
      Use 3.1 SDK for build · 71f7b042
      Jared Parsons 提交于
      71f7b042
  2. 30 1月, 2020 13 次提交
  3. 29 1月, 2020 17 次提交