Address CR feedback: Rename a bunch of async methods in the AnalyzerDriver to have "Async" suffix. (changeset 1312696)

Porting the "Dictionary initializer" from an old feature branch related to the now cut ".$" operator.

===
Introducing Dictionary initializers

The syntax is like this:

        var l = new Cls1()
        {
            ["aaa"] =
            {
                ["x"] = 1,
                ["y"] = 2
            },
            ["bbb"] =
            {
                ["z"] = 42
            }
        };

===
Also fixes #13
***NO_CI***
 (changeset 1312685)

re-ordered a parameter and added LogMessage to LogBlockEnd. (changeset 1312594)

now we have AggregateLogger that we can combine multiple logger together more cleanly. (changeset 1312345)

Reduce the variety of optimization related compilation option values used in tests to: Release, DebuggableRelease and Debug.

By default tests should use Release, which enables all optimizations.
PDB tests should mostly use Debug.
We should have targeted tests for DebuggableRelease, for optimizations that are selectively disabled to improve debuggability of release builds.

   (changeset 1312277)

Fix is to ensure that we call symbol analyzers only for user defined source symbols. (changeset 1311956)

Fix for bug 995206: Crash (KeyNotFoundException) in Microsoft.CodeAnalysis.SemanticModelWorkspaceService.SemanticModelWorkspaceServiceFactory.SemanticModelService.CompilationSet.RemoveOldTreeFromMap

Fix the scenario where a document ID exists in old project but not in the new project. Don't assume that the new map has a key for all the documents in the old compilation.

 (changeset 1311724)

our Logger used to get both FeatureId and FunctionId. FeatureId used to be used to control a group of functionId.

now, I am flattening them so that we can group functionId by its name rather than using both FeatureId and FunctionId. (changeset 1311395)

We were constructing the binder chain using the source symbol original definitions.  Instead, we should have been constructing them using the source symbols constructed with the target type parameters.  Otherwise, source type parameters can end up in the bound tree (e.g. from the return type of another method in the source type). (changeset 1311390)

1) Remove references to projects that are very, very gone.
2) Delete comments that were no longer attached to what the used to be attached to. (changeset 1311189)

Some cleanup of IL temps created when emitting addresses. Results of EmitAddress should not be ignored.

Generally C# allows only taking address of expressions that are "addressable". In rare cases an expression is not directly addressable and a temp must be created. However generally we know exactly the lifetime of such reference and the corresponding temp.
Not knowing the life-time and leaking a local intentionally is extremely rare and only happens in specific kinds of synthesized code, so we know it is safe thing to do.

In all other cases the temp is either unexpected (assert was added) or its lifetime is known (release code was added).
 (changeset 1311067)

MSBuild unconditionally overwrites the value of BuildDependsOn in Microsoft.Common.CurrentVersion.targets:
  <PropertyGroup>
    <BuildDependsOn>
      BeforeBuild;
      CoreBuild;
      AfterBuild
    </BuildDependsOn>
  </PropertyGroup>

So NuGet.targets needs to be included after Microsoft.Common.CurrentVersion.targets.  Otherwise, the RestorePackages build target won't run.

 (changeset 1311037)

Fix for bug 997372:Test MultipleSimultaneousCompiles fails on the build machines due to harcoded analyzer driver timeout

Remove timeouts that were added to AnalyzerDriver for debugging a deadlock, these were not intended to be part of product code. (changeset 1310948)

and add parameters to the API for upcoming anticipated changes to support reference assemblies. (changeset 1310516)

     (Bug #774305) (changeset 1310427)

Convert short-lived synthesized local variables defined in bound sequences to long-lived spill variables during stack spilling.
The goal is to establish an invariant that short-lived synthesized locals are not hoisted to state machine fields.

In addition, synthesized local variables now capture the source file and line where they were created in debug builds, so that it's easier to track them thru bound tree rewriting. (changeset 1310349)

Switch the command line compilers to use the newly implemented event queue based AnalyzerDriver for executing diagnostic analyzers. This change primarily (a) Fixes AnalyzerDriver.AnalyzeDeclaringReference to correctly compute the syntax nodes to be analyzed by syntax and code block analyzers (b) Port all unit tests to use the new driver (c) Delete the current AnalyzerDriver. (changeset 1308719)

Refactor ObjectDisplay.FormatPrimitive boolean parameters into an options enum and add support for displaying Type suffix characters after numeric values that may optionally include them.
***NO_CI***
 (changeset 1307280)

     Example:
         static void Test<T>(T[] x) where T : IDisposable
         {
             x[0]?.Dispose();
         }

     note that T is not necessarily a class here!!
     The tricky part of this change is to make sure that sideeffects from the call are applied to the receiver. I.E. in the struct case we must not perform the call on a copy of the receiver.
     We should not be Disposing a copy in the example.

Also fixes #184 - null propagating operators should not be allowed in expression trees.
 (changeset 1310269)

Fix for bug 908658: DiagnosticAnalyzerDriver calls OnCodeBlockStarted/Ended on more Syntax/MethodKinds than AnalyzerDriver does

Ensure that the IDE and compiler analyzer driver execute code block analyzers for identical symbol kinds. (changeset 1310061)

The completion list should show instance members inside of static members when in a nameof expression (changeset 1310030)

PERF: Remove allocations coming from a string.Split call in VB's OptionsValidator.IsValidNamespaceName (changeset 1309815)

Disallow string literals in #pragma warnings directives and allow identifiers instead. Also stop validating warning ids supplied in #pragma warning directives. These were both decisions that were made at a design meeting a few weeks back. The corresponding VB changes (for #Disable) have already been implemented - this change implementss the same for C#.

Note: Parsing / lexing of identifiers inside #pragma warning directives is identical to that inside #define directives except for the following difference. Inside #define, very long identifiers are truncated to 128 characters to maintain backwards compatibility with previous versions of the compiler (Dev12-). Since support for identifiers inside #pragma warning directivess is new, we don't have any backwards compatibility constraints for this. So we preserve the identifier exactly as it appears in source. (changeset 1309687)

A new approach that replaces changesets #1306929 and #1306961.  Instead of forcing a new concept into the binder-proper, just accept that some symbols in the EE (specifically, lambdas, range variables, and labels) will have "incorrect" containing symbols in EE scenarios.  There do not seem to be any negative consequences to the "incorrectness".

Clean up the EE binders now that the new concept has been eliminated.

CR: chucks; ngafter (changeset 1309568)

Add an additional test for bug fix 914236. Shyam pointed out that this scenario did not work prior to the fix for this bug. (changeset 1309536)

A small enhancement to formatting accessor declarations inside Auto properties. We now format the whole accessor list, on semicolon after an accessor declaration, as long as the declaration is complete is in a single line. (changeset 1309519)

Fix for bug 914236: ISyntaxNodeAnalyzer.AnalyzerNode is never invoked in command line compiler, unless the syntax nodes of interest are within executable code blocks

Ensure that we execute syntax node analysis for global nodes which are not under any declarations (usings, assembly attributes, preprocessor statements, etc.) (changeset 1309366)

When a project is renamed, we need to fetch updated display names and file paths for it. We leave the project ID as is, with the debug path which is still the old string, since we have no good way to change that.

If this change works, DustinCa should get the credit since he wrote most of this. (changeset 1309226)