- 10 5月, 2019 8 次提交
-
-
由 Andy Gocke 提交于
A PROTOTYPE comment snuck its way into master. It described some a possible interpretation for the editorconfig parser on line continuations, but I don't think we should do it, so the correct fix is to remove the comment.
-
由 Fred Silberberg 提交于
Refactor ApplyConversion into VisitConversion
-
由 Julien Couvreur 提交于
-
由 Fredric Silberberg 提交于
-
由 Fredric Silberberg 提交于
-
由 Fredric Silberberg 提交于
Refactored parameter names, updated tests, and added assertions for assumptions.
-
由 Fredric Silberberg 提交于
Refactored some common code into a helper and corrected some small nits.
-
由 Fredric Silberberg 提交于
Refactors out ApplyConversion into a more aptly named VisitConversion. Adjusts the parameters to take the node being converted, and optionally the original boundconversion. When the boundconversion is passed it, the calculated nullability is now tracked through nested levels of conversions between the top-level boundconversion and the underlying converted node. Removed TrackInferredTypesThroughConversions, as this is now being handled by VisitConversion. This PR additionally fixes a conversion issue where user-defined conversions that added nullability were not then marking the result type of that conversion as nullable.
-
- 09 5月, 2019 4 次提交
-
-
由 Charles Stoner 提交于
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.1 to master
-
由 Jason Malinowski 提交于
Fix having the wrong syntax trees after adding an .editorconfig
-
由 Gen Lu 提交于
Fix logging for option value change
-
- 08 5月, 2019 6 次提交
-
-
由 Heejae Chang 提交于
* made error navigation and deduplication a bit better with mapped span error such as // A.cs having // #line 2 RandomeFile.txt // ErrorHere // #line default previously, we didn't do the de-dup correctly and navigate correctly. now, it at least do that better. but there is still question wehther current behavior is what we want or not. * added test * made local function static
-
由 Jason Malinowski 提交于
Synchronize AnalyzerConfig documents when creating OOP solutions
-
由 Julien Couvreur 提交于
-
由 Jason Malinowski 提交于
Ensure we set _isSubscribedToSolutionEvents
-
由 Neal Gafter 提交于
Fixes #31685
-
由 Charles Stoner 提交于
-
- 07 5月, 2019 13 次提交
-
-
由 Charles Stoner 提交于
-
由 Rikki Gibson 提交于
* Add reproducer for #34872 * Fix bug and add test * WIP * Test similar scenario in VB * Add void check in ClassifyConversionFromType, update tuple tests * Cleanup
-
由 Jason Malinowski 提交于
If we don't set this, we'll subscribe to solution events multiple times which isn't great. Our event handler is idempotent so it'll still do the right thing, but we'll just be wasting extra time processing notifications that won't do anything. Fixes https://github.com/dotnet/roslyn/issues/35372
-
由 Rikki Gibson 提交于
* Don't emit readonly attributes on members within readonly structs * Check ContainingType.IsReadOnly before EnsureIsReadOnlyAttributeExists just for consistency
-
由 Julien Couvreur 提交于
-
由 Manish Vasani 提交于
Improve diagnostic messaging for unused value assignment and unused p…
-
由 Rikki Gibson 提交于
* Symbol display for readonly members * Add coverage * Test malformed properties and events * Show readonly keyword on non-field members in QuickInfo * Use IsDeclaredReadOnly for symbol display (WIP) * Update based on design and fix some test failures * Add readonly keywords to various IL tests * Fix more tests, respond to feedback * Fix compile error * Don't display readonly keyword for implicit readonly getters from source * Don't show readonly keyword for members contained within a readonly struct * Move from extension methods to private statics
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.1 to master
-
由 Ivan Basov 提交于
-
由 Julien Couvreur 提交于
-
由 Chris Sienkiewicz 提交于
* Nullable Deconstruction in foreach loops: - Visit deconstruction in foreach loops, rather than handling it directly - Add tests
-
由 David Poeschl 提交于
-
由 AlekseyTs 提交于
-
- 04 5月, 2019 9 次提交
-
-
由 Andy Gocke 提交于
Implements a design change where overrides are allowed to change the type of the member as long as there is an implicit nullable reference conversion from the overriding type to the overridden type according to the nullable variance rules. Fixes #23268 Fixes #30958
-
由 Jason Malinowski 提交于
It's not as important as the others because the file ordering doesn't matter in the same way, but it's good to have for consistency.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
We had APIs for add/remove, but didn't actually add the collection type yet.
-
由 Jason Malinowski 提交于
-