- 28 10月, 2016 2 次提交
-
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
-
- 27 10月, 2016 5 次提交
-
-
由 CyrusNajmabadi 提交于
-
由 CyrusNajmabadi 提交于
-
由 Ty Overby 提交于
add test for symbol on result of typeof
-
由 Phil 提交于
Cached lambdas were being used in situations where the return type was different. This forces building a new lambda body and binding for those cases.
-
由 Neal Gafter 提交于
* Skip enclosing parens in ancestors to find the when clause of a switch case * Adjust instrumentation for when clause to include the when keyword Fixes #14707
-
- 26 10月, 2016 6 次提交
-
-
由 Charles Stoner 提交于
-
由 Omar Tawfik 提交于
-
由 Jared Parsons 提交于
-
由 VSadov 提交于
-
由 Neal Gafter 提交于
Fixes #14696
-
由 AlekseyTs 提交于
Type comparison should ignore insignificant differences like tuple name mismatch, etc. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=269808.
-
- 25 10月, 2016 5 次提交
-
-
由 Omar Tawfik 提交于
-
由 Neal Gafter 提交于
Fixes #14636
-
由 Omar Tawfik 提交于
-
由 Jared Parsons 提交于
-
由 Ty Overby 提交于
* harden CompileMethod * add test * reword comment
-
- 24 10月, 2016 4 次提交
-
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
This should either be defined globally or not at all. Repeating all the logic on a local level is just wasted time.
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
When a machine.config or app.config is corrupted it's possible for `ConfigurationManager.AppSettings` to throw an exception. The compiler server was not tolerant of such a failure and as a result would terminate immediately after startup. The compiler workflow is generally very tolerant of failures in the server. It is an optimization only, and any crashes, bad results, etc ... are ignored and the workflow will fall back to the command line. Failing on startup is one case the workflow does not handle well right now. The workflow does not distinguish between a crash at startup and a very slow JIT situation (as is the case with old, single core machines). As such it ends up adding an unnecessary 25 second delay to the compilation. Issue #14265 tracks fixing this delay but it won't make RC. Up until now only one incident of corrupted app settings was reported and it was considered an extremely unlikely problem (as it would break a lot of apps). Going through VS feedback last night I found one other incident which could would be explained by this problem. Hence it's possible this is more likley than originally thought (although still very rare) and decided to put it into RC. closes #14288
-
- 22 10月, 2016 4 次提交
-
-
由 Jared Parsons 提交于
-
由 Charles Stoner 提交于
-
由 Jared Parsons 提交于
TLDR: artifacts are going to move around in Binaries\Debug and the directory is going to get a lot bigger. At a high level build projects can be classified into three categories based on how they write output: - incorrect: a given output path is written to more than once with different contents - less correct: a given output path is written to more than once but always with the same content - correct: a given output path is written to exactly once Today the roslyn build is decidedly “incorrect” as pretty much every file is written directly into Binaries\Debug. This means it ends up writing pretty much every Visual Studio SDK DLL twice: once for Dev14 and once for Dev15. For example at various points in the build Binaries\Debug\Microsoft.VisualStudio.Text.Data.dll may refer to Dev14 and at others it’s Dev15. If this seems like a scary proposition for a build that’s because it is indeed scary and it has real consequences. By now pretty much everyone on the team has hit the build race condition that is dragging down our PRs. The general fix here is to move build outputs into separate directories. Instead of building to $(Configuration) projects now build into say $(Configuration)\Exes\$(MSBuildProjectFileName). This will have a substantial increase in the size of Binaries. We will be looking into ways to reduce that. In the short term though build stability far outweighs the size increase. This change takes us most of the way to "correct". There are several places I had to compromise in order to get this initial change in: - UnitTests still build to a common output folder (one for Dev14, another for Dev15). Pulling unit tests apart is going to take a bit of work. - Every project has a <RoslynProjectType> entry. This will go away in the future for most projects. It's temporarily needed so I can fix roslyn-internal in parallel without taking down the build. - VSL.Imports.targets is messy. Unavoidable for now due to the above. It will get cleaner as I iterate on this. None of these are relevant to the underlying race condition. Hence it's okay to push them off.
-
由 AlekseyTs 提交于
Fixes #10929.
-
- 21 10月, 2016 3 次提交
-
-
由 AlekseyTs 提交于
Fixes #14510.
-
由 AlekseyTs 提交于
The code is related to the feature of supporting explicit parameter-less constructors in structures, which was removed. Also, the code in IsDefaultValueTypeConstructor helper wasn't properly handling constructed or retargeted symbols. Fixes #14541.
-
由 AlekseyTs 提交于
-
- 20 10月, 2016 3 次提交
-
-
https://devdiv.visualstudio.com/DevDiv/_workitems?id=278481由 AlekseyTs 提交于
Also added some checks that should help to figure out how to reproduce the crash.
-
由 Andy Gocke 提交于
Previously iterator validation was only run in MethodCompiler for blocks which pass through that code path, resulting in missed local functions inside lambda blocks, which don't pass through BindMethodBody. Fixes #13937
-
由 Neal Gafter 提交于
Fix a crash in compiling pattern switch when certain combinations of type patterns appear together (#14585) Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=273713
-
- 19 10月, 2016 5 次提交
-
-
由 Omar Tawfik 提交于
-
由 Ravi Chande 提交于
This reverts commit 63872019.
-
由 Neal Gafter 提交于
* Enable finding the breakpoint location for a pattern switch case (#14426) Fixes #12378 * Tests for IDE breakpoints for deconstruction foreach statement Fixes #14439 * Implement and test sequence and break points for deconstruction foreach Fixes #14439 * Implement and test sequence and break points for expression-bodied ctor, dtor, and accessors Fixes #14438 * Enable setting a breakpoint in a local function Fixes #14437 * Add support for /instrument codecoverage for new language features Fixes #14337
-
由 Andy Gocke 提交于
Local functions previously used the local function name but, as local functions are not members, this was inappropriate. Fixes #13268
-
由 Neal Gafter 提交于
Also move the lowering in pattern switch to the lowering phase. As a result of this, the decision tree is now a very transient data structure and is no longer stored in the bound tree. Fixes #14296 Fixes #12175
-
- 18 10月, 2016 3 次提交
-
-
由 AlekseyTs 提交于
Fixes #14255. Also fixes #14530.
-
由 Andy Gocke 提交于
This package now only supports the TFM. This is because the purpose of the package to layout a .NET Core executable, which requires the netcoreapp references, including CoreCLR itself. There are also numerous references that are now provided by inheritance from the compiler itself, so those references have been removed from the Microsoft.Net.Compilers.netcore nuspec. Fixes #12674
-
由 Jason Malinowski 提交于
These changes don't matter for command line builds, but the project system interprets empty property groups to define which configuration/ platform combinations exist. Thus, those should line up with the intent of the project. If there was ambiguity, I've resolved in favor of the project.json statement of the world since that's what was actually happening.
-