Fix bug 529880: fix incorrect parsing (leading to a crash) of FULLWIDTH COLON (U+FF1A) when it appears immediately after an XML name in VB. Now it is always parsed as a statement separator in this context (if possible), that agrees with the native VB compiler. Also adds some tests for the REM keyword in XML name context. (changeset 1269793)

I did some experiment and it looks like using concurrent dictionary makes write about 100% faster and read about 50% faster in heavily concurrent sencario.

since RecordingObjectBinder is used for syntax node serialization and deserialization which can be quite heavily concurrent, this should help us to get those tree from tree storage faster.

 (changeset 1269787)

Simplification to Predefined Type keyword within Member Access Expression was missing a Symbol check in addition to the Type Check. Fixed in both VB and C# (changeset 1269571)

956667 : Simplification to Predefined Type keyword within Member Access Expression was missing a Symbol check in addition to the Type Check. Fixed in both VB and C#

953535 : Introduced a new formatting rule to handle spacing within the Conditional Expression (changeset 1269369)

Support for initialization scope and constructor initializer scope in SemanticModel. (changeset 1268942)

When collecting SQM data, the compilers try to include the set of diagnostic codes that the user has supplied options for. For example, warnings that have been suppressed, warnings that should be treated as errors, etc. We only intend to collect data for compiler diagnostics, and the code assumes that all diagnostic IDs take the form "CS1009" or "BC1009".

Now that we support rule set files for third-party diagnostics this assumption is no longer correct. If we're collecting SQM data and a rule set includes a setting for a diagnostic with the ID "MyDiagnostic" (for example), we'll try to parse "Diagnostic" as a uint and crash the compiler.

The fix is to filter out everything that doesn't match the expected format. (changeset 1267569)

Example:
Namespace N1
Class C
End Class
$$
End Namespace

Typing at $$ makes the syntax tree incomplete and the token at $$ gets attached to the EndBlock. However, the IDE needs to think of this as being attached to the surrounding namespace declaration to be able to recommend keywords that apply here.

This change handles such error cases to provide better keyword recommendation.

More examples:

Namespace N1
End Namespace
$$

Module M1
End Module
$$

End Class
$$

Namespace N1
End Class
$$
End Namespace

and so on. Added tests for all such cases. (changeset 1267530)

Add support for a custom PreviewOperation CodeActionOperation: This enables clients to display custom WPF controls in the preview dialog. This preview control might have custom description, hyperlinks and other custom controls appropriate for the code action preview. (changeset 1267319)

The current implementation of MultiByteEncoding is not portable. This change replaces it with a simpler string serialization technique.

The problem is with GetBytes(char*, int, byte*, int) -- we needed to override this method in order to avoid buffer allocation. But the base method is currently not exposed in portable profile.
We don't actually need to define an ecnoding to serialize strings. We can serialize strings to byte array manually and then write the bytes direaction to the strream.

Taking it one step furtehr we can also avoid using a custom string serialization format as well. Instead we chack if the string being serialized is UTF8-encodable. We already have a helper in MetadataHelpers that answers that question. If it is we use UTF8 encoding, otherwise we use UTF16 encoding. Invalid Unicode characters are rare so we don't need to optimize the latter. (changeset 1267243)

Introduce option to prefer Intrinsic Predefined Type keyword instead of Expanded Syntax in Member Access Expression. The default value is True.

Option set to True:
class Program
{
    static void M()
    {
        var local = int.MaxValue;
    }
}

Option set to False:
class Program
{
    static void M()
    {
        var local = System.Int32.MaxValue;
    }
} (changeset 1265497)

The value of LanguageVersion.Experimental should be higher than any possible future language version.

Note that changing an enum name or value is a breaking change. When we ship C# 7 we can't change Experimental from 7 to 8.
 (changeset 1265449)

Renamed VB's CaseElse-, CaseValue-, CaseRelational-, and CaseRangeClause nodes/kinds to match .NET conventions for derived types - <Specialization>BaseName instead of their current BaseFirstWord<Specialization>BaseLastWord pattern. (changeset 1264911)

When collecting SQM data, the compilers try to include the set of diagnostic codes that the user has supplied options for. For example, warnings that have been suppressed, warnings that should be treated as errors, etc. We only intend to collect data for compiler diagnostics, and the code assumes that all diagnostic IDs take the form "CS1009" or "BC1009".

Now that we support rule set files for third-party diagnostics this assumption is no longer correct. If we're collecting SQM data and a rule set includes a setting for a diagnostic with the ID "MyDiagnostic" (for example), we'll try to parse "Diagnostic" as a uint and crash the compiler.

The fix is to filter out everything that doesn't match the expected format. (changeset 1264355)

this is to verify new tests, once it runs reliablely it will be removed from rolling perf and moved to daily perf machine. (changeset 1263718)

StackOverflowException in DataFlowPass.IsEmptyStructType for Structure S(Of T) with field of S(Of T)?

CheckStructureCircularity was not returning True in all cycle cases. (Compare with C# HasStructCircularity.)
 (changeset 1265250)

We just needed to override a few defaults on the MultiByteEncoding type.
Also, while testing this, I noticed that one of the tests that was supposed to be testing a long string was incorrect. (changeset 1263598)

An expression-bodied property is a property with an expression instead of accessors, i.e. syntax st. a property P written as

... type P { get { return e; } }

is equivalent to

... type P => e;

This feature is experimental and keyed on the Experimental LanguageVersion. (changeset 1263330)

Harden Parameter Modifier keywords (ByVal, ByRef, Optional, ParamArray) and Event Handling keywords (AddHandler, RemoveHandler, RaiseEvent) by not suggesting anything but ByVal within property or event Accessor declarations (changeset 1262475)

Ensure that we report warning when the argument for #pragma warning disable / restore is an empty string / string that only contains whitespace.

Also throw exception if someone tries to construct a DiagnosticDescriptor with null / empty string as Id. (changeset 1262338)

The compilers cannot currently resolve the same range of <Include> elements as FxCop. Consider the following:

  <Include Path="MinimumRecommendedRules.ruleset" Action="Default" />

FxCop knows to go look for MinimumRecommendedRules.ruleset among the rule sets installed with VS, as well as in any user-defined locations. Roslyn lacks this ability, and so some projects that previously built will now fail with an error about the file not being found.

For the moment, just work around the issue by ignoring any included files that can't be found. (changeset 1261868)

Disallow ComAliasNameAttribute from getting emitted on parameters in cases where user invokes implement interface refactoring to implement a COM interface. (changeset 1261481)

- Disallow field modifiers and field attributes on primary constructor parameters.
- Adjust scope of primary constructor parameters.
- Allow referencing non-ref/non-out primary constructor parameters in a lambda.
- Report appropriate diagnostics when a primary parameter is shadowed in a nested scope.
 (changeset 1261399)

The sequence point used to be on the "using" keyword while the break point spans around both "using" keyword and the expression. Here, we adjust sequence points to be aligned with break points. Also, we update unittests in a way that the markup can be used to identify a specific span which is verified. (changeset 1261135)

Preselect types and members based on the <completionlsit> documentation comment tag. (changeset 1261004)

Add zero-th entries to heaps even for delta metadata to avoid nil generation-relative handles, which are technically ok but confusing. (changeset 1260989)

     Before reading the contents of a .ruleset file, we validate it against a schema. This catches common problems, such as duplicate rule definitions.

     The issue here is that we will currently catch this:

     <Rules ... >
       <Rule Id="CA1011" Action="Warn" />
       <Rule Id="CA1011" Action="Error" />
     </Rules>

     but not this:

     <Rules ... >
       <Rule Id="CA1011" Action="Warn" />
     </Rules>
     <Rules ... >
       <Rule Id="CA1011" Action="Error" />
     </Rules>

     That is, the schema only enforces that a Rule is unique within a Rules element, not that it is unique across the whole ruleset. This causes a later compiler crash when we attempt to set the action for rule CA1011 and find that it has already been set.

     The fix here is to update the schema file to enforce uniqueness across the file. (changeset 1260974)

Introduce option to prefer intrinsic type keyword over expanded type. The default option is to prefer the intrinsic keyword

     Eg:
     1. With the option enabled[default]
     class Program
     {
         private int _member;
         static void M(int argument)
         {
             int local;
         }
     }

     2. With option disabled
     class Program
     {
         private System.Int32 _member;
         static void M(System.Int32 argument)
         {
             System.Int32 local;
         }
     } (changeset 1260681)

Stores Encoding on SourceText so that we can always calculate checksum of the underlying binary data, even if the SourceText wasn’t created from a Stream.

Adds WithRootAndOptions and WithFilePath methods to SyntaxTree and implements them for all subclasses. I decided to merge WithRoot and WithOptions to a single method WithRootAndOptions since setting one without the other doesn't make much sense (the options should correspond to the root node).

Propagates the Encoding throughout workspaces and services.
Refactors recoverable syntax trees so that they can implement With* methods.

Allow encoding on SourceText to be unspecified (null) and report an emit diagnostic when attempting to emit debug information for a syntax tree that is backed by encoding-less source text. If user creates a syntax tree from a string they previously read from a file and then try to emit debuggable compilation with such tree the original encoding of the file might not match the default UTF8 (they might different by presence of BOM, which is quite subtle). To avoid confusion we don't set UTF8 encoding by default. Instead we report the diagnostic and the user needs to explicitly provide an encoding to the syntax tree factory method.

Avoid leaking DecoderFallbackException out of EncodedStringText.Create. Throw InvalidDataException instead to reduce the amount of exceptions that the caller needs to deal with.

Also moves HasSameText extension method from Services to SourceText and optimizes the comparison for the case we the SHA1 checksums are available.
 (changeset 1260412)

#872954: Missing error "CS0523: Struct member '...' causes a cycle in the struct layout" for nested enum (changeset 1259966)