1. 06 3月, 2015 34 次提交
  2. 05 3月, 2015 6 次提交
    • T
      Only show check mark if the severities are the same · e9eb5717
      Tom Meschter 提交于
      If the user selects a bunch of diagnostics with differing severities in
      Solution Explorer, right-clicks,  and opens the "Set Rule Set Severity"
      submenu they will see a check mark next to every applicable severity.
      E.g., if one rule is an error and one is a warning, then both Error and
      Warn will be checked.
      
      The general feeling is that this will be confusing to users. Instead,
      only show a check mark when all the selected rules share the same
      severity.
      e9eb5717
    • D
      Fix issue introduced by recent change that breaks web scenario · adefc3f0
      Dustin Campbell 提交于
      Of course, a ContainedLanguage will never be an IProjectionBuffer. So,
      this method always returns an empty enumerable. Instead, the cast should
      be against _containedLanguage.DataBuffer.
      
      #hangsheadinshame
      adefc3f0
    • M
      e05b0465
    • M
      Fix execution of CompilationStartActions when only analyzer options for the... · 37f0a943
      Manish Vasani 提交于
      Fix execution of CompilationStartActions when only analyzer options for the project change, but the underlying compilation is identical.
      
      Our current assumption for executing CompilationStartActions is that they should be executed exactly once per-compilation per-analyzer. We cache the registered nested actions for every compilation in AnalyzerManager to ensure this. However, if user just changes an additional document for the project, then the analyzer options change, but the underlying compilation is unchanged. Project change causes IDE diagnostic service to clear all cached diagnostics, but when re-computing diagnostics, we end up skipping execution of CompilationStartActions and directly move to nested compilation actions. This can be troublesome in couple of ways. First, we will have duplicate callbacks for all nested actions for the initially invoked compilation start action. Second, and event worse, if the analyzer is reading the contents of the additional documents in the start action and caching them for later use by the nested actions, all the nested actions get stale contents for the additional documents. Apparently, Tom is the first one to go through this agony as the DeclarePublicAPI analyzer that he implemented exactly does the latter.
      
      Fix is to ensure that we execute compilation start actions for every unique compilation start analysis context, i.e. {compilation, analyzer options} tuple for every analyzer.
      37f0a943
    • T
      cedeba0a
    • T