1. 24 10月, 2019 10 次提交
    • J
      Switch all uses of TestHostDocument.TextBuffer to GetTextBuffer() · 5cd40392
      Jason Malinowski 提交于
      We had both a property and a method returning the same thing. This
      unifies to just the method.
      5cd40392
    • J
      Redo when we create text buffers in TestWorkspace · 17fde7a3
      Jason Malinowski 提交于
      With TestWorkspace we were creating text buffers for all types of
      documents up front, and by default opening all buffers in the workspace.
      This was problematic because if we're creating text buffers we should
      be ensuring the text buffer's options for using tabs and spaces matches
      the Workspace options, but the workspace sometimes wasn't available
      at those times. This is also unnecessarily expensive if you have test
      projects that aren't doing anything with editor experiences at all.
      
      Also, a complicated "create a separate document in the TestWorkspace for
      the cursor" was removed in favor of more direct code that just creates
      a buffer. Creating an entire TestDocument was funky since the document
      was never actually part of the workspace -- this revealed that it didn't
      seem we were ever disposing the views created.
      
      The "languageName" parameter to CreateProjectionBuffer was removed: it
      didn't logically make sense (the projection buffer created isn't in
      a Workspace, so it has no language name), but also wasn't being used
      for anything else.
      17fde7a3
    • J
      Switch EditorFactory methods over to taking a IContentType · 2ac6ac0c
      Jason Malinowski 提交于
      The overloads sometimes had exportProvider first and sometimes second.
      This was because if you always had it first and content type is passed
      as a string, you have ambiguity of how to handle the params array.
      Just passing in stuff explicitly makes this easier.
      
      Also replace a hand-written implementation of string.Join with
      string.Join.
      2ac6ac0c
    • J
      Convert token auto-formatting to use theories for tab/space tests · fca389f5
      Jason Malinowski 提交于
      Makes it easier to figure out when just one side is failing.
      fca389f5
    • J
      Allow ordering of document option providers · efcee766
      Jason Malinowski 提交于
      This is implemented by adding metadata to exports of
      IDocumentOptionsProviderFactories that specify the ordering like any
      other provider. Although I would love to simplify this by simply
      removing the factories entirely by simply having the Workspace
      constructor directly add the instances, Visual Studio for Mac is also
      exporting these so we'll maintain compat for now.
      efcee766
    • J
      Nullable annotate our extension ordering code and delete IOrderableMetadata · 21c8e2fa
      Jason Malinowski 提交于
      I expect that IOrderableMetadata existed back from a time where we
      were working with both MEFv1 interface metadata views and MEFv2
      concrete type views. Nothing today needs it anymore, so we can just
      delete it.
      21c8e2fa
    • J
      Fix document.GetOptionsAsync().WithChangedOption potentially throwing · f3ff7201
      Jason Malinowski 提交于
      If we both had a document-specific option provided and also tried
      to change the value, we'd end up throwing an exception.
      f3ff7201
    • J
      Add an overload to DocumentOptionSet.WithChangedOption · a968f8bc
      Jason Malinowski 提交于
      This adds a convenience overload where WithChangedOption can be more
      easily used with a PerLanguageOption, but also returns a strongly
      typed DocumentOptionSet so you don't lose the distinction.
      a968f8bc
    • J
      Update some comments to delete references to Visual Studio 2017 · 3a677853
      Jason Malinowski 提交于
      These no longer apply.
      3a677853
    • J
      Add some nullable annotations in options system · 0640c762
      Jason Malinowski 提交于
      There appeared to be one bug: if a document was opened that had a null
      file path, there was a risk that we would crash because we would be
      passing that around to the editor API in the legacy case.
      0640c762
  2. 23 10月, 2019 4 次提交
  3. 22 10月, 2019 12 次提交
  4. 21 10月, 2019 1 次提交
  5. 20 10月, 2019 2 次提交
  6. 19 10月, 2019 6 次提交
  7. 18 10月, 2019 5 次提交