1. 31 1月, 2020 1 次提交
    • J
      Fixup nullable annotation · 5a0b78c9
      Jared Parsons 提交于
      Had to clean up a few nullable annotations now that we are compiling
      agaist `netcoreapp3.1` and hence get the full value of the framework
      annotations.
      
      This is also problematic though because there are now two places where
      the compiler can see nullable attributes that are directly used by the
      developer. For example `NotNullWhenAttribute`. This is both defined in
      our assemblies for non-netcoreapp target frameworks and provided by the
      SDK when targeting `netcoreapp3.1`.
      
      This causes a problem for assemblies which have the following
      characteristics:
      
      1. Target `netcoreapp3.1`
      1. Reference an assembly targeting `netstandard2.0` which uses our
      nullable attributes definition
      1. Has IVT into (2) above
      
      These properties essentially define all of our unit test assemblies. In
      that environment it's not possible to use nullable attributes in code
      because the compiler can't disambiguate which definition of
      `NotNullWhenAttribute` to use. This meant I had to temporarily remove a
      few attributes until we can complete #40766.
      5a0b78c9
  2. 24 1月, 2020 3 次提交
  3. 23 1月, 2020 1 次提交
  4. 13 9月, 2019 1 次提交
  5. 02 4月, 2019 1 次提交
  6. 11 1月, 2019 1 次提交
  7. 14 12月, 2018 1 次提交
    • J
      Remove custom assembly resolution · e3af076a
      Jared Parsons 提交于
      The custom assembly resolution is no longer needed in our MSBuild task
      now that it has no project references and multi-targets to the important
      runtimes.
      
      This logic has actually been broken for some time now. More recent
      changes revealed it's just not necessary.
      e3af076a
  8. 05 12月, 2018 1 次提交
  9. 11 9月, 2018 1 次提交
    • C
      Compile Server Hash Check (#29711) · c48339b9
      Chris Sienkiewicz 提交于
      * Fix compiler server mismatched version:
      - Ensure compiler server returns correct response when providing an incorrect protocol value
      - Add test to check
      - Fix tests that break
      
      * Check compiler sha as part of build server protocol:
      - Add the CommitHashAttribute to the needed assemblies
      - Bump the protocol version to 3
      - Add a new CommitHash field to build request
      - Fill out the CommitHash from the CommitHashAttribute value when creating build requests
      - Check that the commitHash on a de-serialized build request matches the one compiled into the assembly
      - Return a new IncorrectHash response if hashes fail to match
      - Fail early on the client side if we can't get the hash
      c48339b9
  10. 11 8月, 2018 1 次提交
    • A
      Add a workaround for long pipe path names (#28841) · 161765c2
      Andy Gocke 提交于
      There's a problem on MacOS where the pipe name may be too long to
      use as a Unix domain socket. Unfortunately, there's no way in the
      version of CoreFX that we reference to override the path name
      used for the named pipe. If the path is too long then the compiler
      server spins infinitely trying to connect to a path.
      
      Since we can't use our own path, the best we can do right now is
      abort compiler server usage if the path would be too long. This
      commit adds a check on Unix machines running on CoreCLR to
      detect when the constructed path will be too long, and bail out
      if this is the case.
      161765c2
  11. 05 6月, 2018 1 次提交
  12. 15 2月, 2018 1 次提交
    • R
      Respect current Environment.NewLine in MSBuild task (#24812) · d379f47d
      Rainer Sigwald 提交于
      The compiler server uses `WriteLine` to generate its output stream,
      which uses the correct newlines for the current OS. When splitting
      the string back into lines in the MSBuild task, though, the split
      was done on Windows newlines.
      
      Fixes #24736 by using `Environment.NewLine` instead of `\r\n` to
      pass lines to MSBuild's logger, which expects errors one-per-line.
      d379f47d
  13. 05 1月, 2018 1 次提交
  14. 01 11月, 2017 1 次提交
  15. 30 10月, 2017 1 次提交
  16. 13 10月, 2017 1 次提交
  17. 10 10月, 2017 1 次提交
  18. 09 10月, 2017 2 次提交
  19. 05 10月, 2017 2 次提交
  20. 04 10月, 2017 1 次提交
  21. 13 9月, 2017 1 次提交
  22. 02 9月, 2017 1 次提交
  23. 24 8月, 2017 2 次提交
  24. 23 8月, 2017 2 次提交
  25. 29 6月, 2017 1 次提交
  26. 07 5月, 2017 1 次提交
  27. 03 5月, 2017 1 次提交
  28. 25 3月, 2017 1 次提交
  29. 22 3月, 2017 1 次提交
  30. 16 2月, 2017 1 次提交
  31. 18 12月, 2016 1 次提交
    • J
      Detect failed server connections in the bootstrap build · e4af938f
      Jared Parsons 提交于
      This change will cause our bootstrap build to fail if a threshold of server connection failures
      occur.  The threshold is chosen a bit arbitrarily as valid failures can occur.  But 15 seems like
      a number to warrant an investigation.  If this produces too many false positives it will be
      adjusted appropriately.
      e4af938f
  32. 10 12月, 2016 1 次提交
  33. 16 11月, 2016 1 次提交
  34. 28 10月, 2016 1 次提交