Changed generation of PrivateImplementationDetails to append module name only when dealing with netmudules.

The goal of module name apending is to avoid clashes when combining multiple netmodules into multifile assembly. When building a regular assembly, appending module name is not serving any purpose and just causes unnecessary metadata differences.

Also in this change - when we do apend the module name, replace '.' with '_' when that happens. For example when we build a netmodule and its name is Foo.Bar.dll
More complicated name mangling schemes were discussed, but at this point we will do a simple '.' --> '_' as the least destabilizing change which is still sufficient in the most common case of having dots in the module name.

Fixes #1430

Skip some failing unit tests in CSharpEditorServicesTest. Issue #1561 has been opened to track re-enabling these tests.

Skip some failing unit tests in CSharpEditorServicesTest. Issue #1561 has been opened to track re-enabling these tests.

AnalyzerDriver async

Minor cleanup for EnC unit tests...

- Remove spurious calls to SymReader.Dispose (per #1539, we'll just let the GC do its job)
- Collect VB tests into subfolder (similar to C#)

Workaround ISymUnmanagedReader bug

For some reason, the EnC code hangs when it tries to cast the symbol
reader returned by the debugger to ISymUnmanagedReader.  Until we get that
sorted out, put a workaround in place.

Pass PDB path to PeWriter so that creating debug directory is possible w...

Consume the new ISymUnmanagedReader3.GetSymAttributeByVersion API

SyntaxGenerator support for expression bodied props

Fix completion bugs #33 #1277 #1293

Removed async from ProcessEventAsync and added it to ProcessCompilationUnitCompleted where it was missing.

...added to ISymUnmanagedReader3.  Not having this API was causing
problems in EnC scenarios because (e.g.) the hoisted local scopes in state
machine methods always came from the unmodified method (version 1).

We're doing some rough mocking (since the co-class we use for testing
doesn't implement ISymUnmanagedReader3) to sanity test this change and a
more realistic integration test will follow.

We used to have multiple mechanisms - constructing a co-class directly
from a registered GUID, wrapping the co-class in SymReader (for some extra
constant mocking), wrapping the co-class in a TempPdbReader (IDisposable),
and wrapping a TempPdbReader in a DebugInfoProvider (trivial wrapper).

This change eliminates TempPdbReader and DebugInfoProvider and gives
SymReader exclusive access to the raw co-class.

This will be useful when we switch to ISymUnmanagedReader3, which the
co-class does not presently implement (but which SymReader can).

Pass PDB path to PeWriter so that creating debug directory is possible w/o availability of native PDB writer

The F5 scenario for OpenSourceDebugPackage was blocked because of the
following issues:

- The pkgdef was using 0.7.0.0 as the version instead of 42.42.42.42
- OpenSourceDebugPackage uses a different public key than the rest of
the code base and it was incorrectly listed in the pkgdef file.

Note: In order to ensure you can F5 after syncing to this fix please run
the following command in a VS command prompt:

> devenv /rootSuffix Roslyn /resetSkipPkgs

added more detail log to fully parsing

Specialize formatting of 'for ( ; ; )' to 'for (;;)'

Fix issues around NotConfigurable diagnostics:

1. NotConfigurable diagnostic shouldn't be reported if it is disabled ( fixes #1473 )
2. NotConfigurable enabled diagnostics implies analyzer is never suppressed. NotConfigurable disable diagnostics shouldn't participate in deciding whether or not analyzer is suppressed.

Fix syntax associated with bound block of foreach

Adjust Async rewrite to eliminate races in Conditional  Access.

Do not allocate too much for Guid stream

Conflicts:
	src/Workspaces/CSharpTest/Formatting/FormattingTests.cs

Trim the filepaths in FindRefs to avoid displaying so much redundant information.

Collect a trace during BasicPerfRenameRoslyn

This change removes two obsolete types:

- MetadataCache
- MetadataFileReference

This types were obsolete and used only in testing.

closes #913
closes #1475

1. NotConfigurable diagnostic shouldn't be reported if it is disabled (fixes #1473)
2. NotConfigurable enabled diagnostics implies analyzer is never suppressed. NotConfigurable disable diagnostics shouldn't participate in deciding whether or not analyzer is suppressed.

Update all projects to reference Microsoft.DiaSymReader 1.0.3-rc2...