The underlying debugger issue has been fixed, so the calls are not needed anymore. (changeset 1274269)

Add IVT for VB EE (ResultProvider) and change .targets so we don't "Import System.Linq" in projects that target .NET 2.0. (changeset 1274168)

Change CommandLineParser (and related types) so that all reference computations are accessible via public API's.

Change ProjectFileLoader to use CommandLineParser to compute same references as command line compiler. (changeset 1274050)

More:
- Skip checked/unchecked expressions (similar to parenthesized) when we are trying to determine if Declaration Expression is used as an argument.
- Fixes/unit-tests for SemanticModel APIs when Declaration Expressions are used inside an “expression bodied” property.  (changeset 1273421)

Port changeset 1271826 from C# to VB (Add light bulb support for adding global and local SuppressMessageAttributes for warning and info diagnostics) (changeset 1273323)

If you try to GTD on a global import alias declared in a VB project file, we null ref. This happens because the compiler synthesizes a SyntaxTree for that imports statement, but we assume that all symbols that have Locations have Locations in the current Solution. To avoid this, detect if the caret is on a alias with no locations in the solution, and in that case, GTD on the target instead. (changeset 1272875)

     The original bug had us trying to contruct a new method M in the scenario below.

     using System.Collections.Generic;
     class C
     {
         void M(IEnumerable<C> c)
         {
             new C().M((a,b) => c.Add)
         }
     }

     because c.Add doesn't exist we get null and pass it through, causing problems.  The GFU service could attempt to query the candidate symbols and try to find a reasonable resolution, but in this case there is none.

Note: This scenario cannot happen in VB currently.   VB and C# return different candidate symbols for the same case so:

Imports System.Collections.Generic

Class C
    Sub M(args As IEnumerable(Of C))
        Dim tmp = New C()
        tmp.M(Function(a, b) AddressOf args.Add)
    End Sub
End Class

does not have the necessary information for us to begin method generation.  Filed Bug #960755

 (changeset 1272810)

Address CR feedback for changeset 1272615 (Handle analyzer type load failures in a better way): Change the newly added diagnostic's severity to be an info rather than a warning.  (changeset 1272711)

Handle analyzer type load failures in a better way: If Assembly.LoadFrom throws a ReflectionTypeLoadException, our current behavior is to log a compiler warning and skip the analyzer assembly. However, this exception might be caused by some unrelated missing types in referenced assemblies and it is possible to continue looking for analyzers from the loaded types in the assembly. This change tweaks the behavior to now log a separate warning for a ReflectionTypeLoadException, and continues working with only the loaded types.  (changeset 1272615)

     Expression Evaluator Restructuring

 Change Description:

     Rename assemblies, namespaces, and folders

     Microsoft.CodeAnalysis.ExpressionEvaluator.ExpressionCompiler.dll
     [Shared ResultProvider dll not yet created]
     Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.ExpressionCompiler.dll
     Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.ResultProvider.dll
     Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator.ExpressionCompiler.dll
     [VB ResultProvider dll not yet created]
     Roslyn.ExpressionEvaluator.CSharp.ExpressionCompiler.dll
     Roslyn.ExpressionEvaluator.VisualBasic.ExpressionCompiler.dll
     Roslyn.ExpressionEvaluator.CSharp.ResultProvider.dll
     [VB ResultProvider test dll not yet created]

TODO: Address CR feedback separately. (changeset 1272594)

Update how the Syntax.xml.Generated.* files are included into the *CompilerSyntaxTests projects to eliminate build warnings in VS. They previously specified a <Link> location which now causes warnings due to recent build process restructuring changing the $(IntermediateOutputPath) location changing to be within the project directory. This change removes these <Link>s. (changeset 1272548)

removed assert since there is a chance where entry in the typemap might not be there yet in concurrent case

it is due to us using two concurrent maps, so it is possible for us to put one information in one map but not in the other one yet.

when we actually consume this binding object, we will never consume Record ang GetType/GetReader at the same time, so removing the assert should be safe. (changeset 1271843)

Add light bulb support for adding global and local SuppressMessageAttributes for warning and info diagnostics. Global SuppressMessageAttributes are assembly attributes generated in a separated GlobalSuppressions file. Local SuppressMessageAttributes are generated on the member declaration node containing the diagnostic location. (changeset 1271826)

For unrecognized locals, LocalDefinition.Type was incorrectly set to the type from the previous generation. Rather than attempting to map the type of an unrecognized local to the current generation, we simply copy the byte signature from the IL in the previous generation when emitting.
 (changeset 1271466)

Converts non-portable Compilation.Emits that accepts file paths to extension methods and removes SyntaxFactory.ParseFile.

Cleans up Emit methods on CSharpCompilation and VisualBasicCompilation.
Reorders parameters of Emit methods so that cancellation token is the last one to follow a common convention. (changeset 1271389)

The compiler used to use the metadata reference path to filter out duplicated references. Duplicate references were also filtered out based on assembly identity, if it the identity was strong.
This change removes the former mechanism in favor of the latter modified to work for weak-named identities as well.

As a result the compiler will no longer report CS1704/BC32208 in cases where two metadata references passed to the compilation that have different paths but the same weak name and version. Based on SQM data these errors were rarely reported anyways. In addition it is hard to make the compilers report these errors when building from VS. So the value of these errors is minimal.

The goal of de-duplication is mainly to support #r scenarios, where application of #r on the "same" reference should be idempotent. The definition of "same" is not based on file paths any more but on simple name and version (or strong name if the assembly is signed).

Also removes FilePath from Location. The value was not well defined and thus problematic for metadata locations. (changeset 1270403)

The suppress operation, when the 'Ignore spaces in declaration statement' is enabled, was passed wrong option (changeset 1270221)

Statically link in the C runtime to rcsc2 and rvbc2. This way you don't need to worry about whether or not it's going to be found at run time. (changeset 1270107)

tweaked some of recordingobjectbinder implementation. (changeset 1270066)

Fix bug 529880: fix incorrect parsing (leading to a crash) of FULLWIDTH COLON (U+FF1A) when it appears immediately after an XML name in VB. Now it is always parsed as a statement separator in this context (if possible), that agrees with the native VB compiler. Also adds some tests for the REM keyword in XML name context. (changeset 1269793)

I did some experiment and it looks like using concurrent dictionary makes write about 100% faster and read about 50% faster in heavily concurrent sencario.

since RecordingObjectBinder is used for syntax node serialization and deserialization which can be quite heavily concurrent, this should help us to get those tree from tree storage faster.

 (changeset 1269787)

Simplification to Predefined Type keyword within Member Access Expression was missing a Symbol check in addition to the Type Check. Fixed in both VB and C# (changeset 1269571)

956667 : Simplification to Predefined Type keyword within Member Access Expression was missing a Symbol check in addition to the Type Check. Fixed in both VB and C#

953535 : Introduced a new formatting rule to handle spacing within the Conditional Expression (changeset 1269369)

Support for initialization scope and constructor initializer scope in SemanticModel. (changeset 1268942)

When collecting SQM data, the compilers try to include the set of diagnostic codes that the user has supplied options for. For example, warnings that have been suppressed, warnings that should be treated as errors, etc. We only intend to collect data for compiler diagnostics, and the code assumes that all diagnostic IDs take the form "CS1009" or "BC1009".

Now that we support rule set files for third-party diagnostics this assumption is no longer correct. If we're collecting SQM data and a rule set includes a setting for a diagnostic with the ID "MyDiagnostic" (for example), we'll try to parse "Diagnostic" as a uint and crash the compiler.

The fix is to filter out everything that doesn't match the expected format. (changeset 1267569)

Example:
Namespace N1
Class C
End Class
$$
End Namespace

Typing at $$ makes the syntax tree incomplete and the token at $$ gets attached to the EndBlock. However, the IDE needs to think of this as being attached to the surrounding namespace declaration to be able to recommend keywords that apply here.

This change handles such error cases to provide better keyword recommendation.

More examples:

Namespace N1
End Namespace
$$

Module M1
End Module
$$

End Class
$$

Namespace N1
End Class
$$
End Namespace

and so on. Added tests for all such cases. (changeset 1267530)

Add support for a custom PreviewOperation CodeActionOperation: This enables clients to display custom WPF controls in the preview dialog. This preview control might have custom description, hyperlinks and other custom controls appropriate for the code action preview. (changeset 1267319)

The current implementation of MultiByteEncoding is not portable. This change replaces it with a simpler string serialization technique.

The problem is with GetBytes(char*, int, byte*, int) -- we needed to override this method in order to avoid buffer allocation. But the base method is currently not exposed in portable profile.
We don't actually need to define an ecnoding to serialize strings. We can serialize strings to byte array manually and then write the bytes direaction to the strream.

Taking it one step furtehr we can also avoid using a custom string serialization format as well. Instead we chack if the string being serialized is UTF8-encodable. We already have a helper in MetadataHelpers that answers that question. If it is we use UTF8 encoding, otherwise we use UTF16 encoding. Invalid Unicode characters are rare so we don't need to optimize the latter. (changeset 1267243)

Introduce option to prefer Intrinsic Predefined Type keyword instead of Expanded Syntax in Member Access Expression. The default value is True.

Option set to True:
class Program
{
    static void M()
    {
        var local = int.MaxValue;
    }
}

Option set to False:
class Program
{
    static void M()
    {
        var local = System.Int32.MaxValue;
    }
} (changeset 1265497)

The value of LanguageVersion.Experimental should be higher than any possible future language version.

Note that changing an enum name or value is a breaking change. When we ship C# 7 we can't change Experimental from 7 to 8.
 (changeset 1265449)

Renamed VB's CaseElse-, CaseValue-, CaseRelational-, and CaseRangeClause nodes/kinds to match .NET conventions for derived types - <Specialization>BaseName instead of their current BaseFirstWord<Specialization>BaseLastWord pattern. (changeset 1264911)