Make ICompilationFactoryService internal

Do not hoist ByRef locals used within iterator methods, even when building debug.

made hostanalyzermanager to use object as id type

Apply spacing rules to fixed, default, sizeof

Switch MSBuildWorkspace to use UTF-8 without BOM

CodeLens Object allocations

Added missing copyright headers

Fixes #2862.

Test for nullref while formatting properties

Fixes a couple of issues around import scope compilation

Update the VS AnalyzerDependencyChecker.

This commit updates the `AnalyzerDependencyChecker` type to reflect the
recent changes to require all analyzers and dependencies to be
specified, and the changes in how we load analyzer assemblies.

Now that we require all analyzers and dependencies to be specified, we
no longer look next to the specified analyzers to optimistically locate
dependencies. Instead, we only consider the list of passed-in analyzers
*plus* the assemblies already loaded into the `AppDomain`. The latter
avoids unhelpful warnings in the event that the analyzer assembly
includes a code fix that take a dependency on a Visual Studio assembly,
which of course can't be included in the list of analyzers. We now
create a warning when we identify a missing dependency.

We now also check analyzers themselves for conflicts (i.e., assemblies
at different paths with the same identity but different contents)
instead of just their dependencies.

Fixes #2684.
Fixes #2728.
Fixes #2738.

Minor cleanup of C#'s Syntax.xml

Improve rename conflicts in nameof

Disable the errant Debug.Assert call until #2866 is fixed.

Remove EOLN check from MarkupTestFile

Allow snippets in Inline Diff View

Fixes #1195 "Renaming a member to a name used within a nameof is a
conflict"

When a nameof expression is involved in a rename, conflicts are only
introduced if the nameof previously referenced a non-empty set of
symbols and the post-rename set of referenced symbols contains none of
the previously referenced symbols. This allows overloads to join or exit
the set of references without conflicts, but a conflict is still offered
if the nameof switches from referencing a method to referencing a local
(or similar).

No conflicts on same-named locals of delegate types

Use pkgdef matching the language

In unit tests, the `AnalyzerDependencyCheckingService` may be null.
Check for that case before attempting to use it.

Allocation reductions in formatting.

When running the `AnalyzerDependencyChecker` we need to apply assembly
binding redirects while checking for missing assemblies. Otherwise we'll
report an error that, for example, `System.Collections.Immutable
Version=1.1.34` cannot be found when it has instead been redirected to
`System.Collections.Immutable Version=1.1.36`.

Check analyzer consistency after solution load.

Right now we only invoke the `AnalyzerDependencyCheckingService` when
explicitly pushing a change in the set of analyzers down to the
workspace. As we batch up all changes during a solution load and wait to
push them to the workspace once at the end, we end up skipping this
check until the next time the user adds or removes an analyzer.

This change causes us to explicitly run the check when solution load
completes.

The following line inside GetAliasTarget was causing a deadlock in the
compiler:

bool won = ImmutableInterlocked.InterlockedInitialize(ref
_aliasTargetDiagnostics, newDiagnostics.ToReadOnlyAndFree());

The ToReadOnlyAndFree call caused any lazy diagnostics present in the
DiagnosticsBag to be promptly evaluated.  As a part of evaluation the
diagnostics could call back into other compiler code including
AliasSymbol.GetAliasTarget.  If that happened on the same AliasSymbol
instance the compiler would enter a deadlock as _aliasTarget had already
been set to a non-null value.

The CompareExchange of _aliasTarget is effectively a lock statement
ToReadOnlyAndFree is calling out to untrusted code.  The fix is to stop
doing this by just saving the DiagnosticBag directly vs. calling
ToReadOnlyAndFree.

This resolves DevDiv 1161400

Add a new command line compiler switch "/reportanalyzer" to report analyzer execution times

Fixes internal TFS bug #831378

Invoke snippets on the DataBuffer instead of the EditBuffer. Once
IVsExpansion.InsertExpansion/InsertNamedExpansion has been invoked
on the correct buffer, all remaining processing is the same
(formatting, end span tracking, and snippet functions all map their
given spans down to the subject buffer for processing).

fixed typos mentioned in #2786 and #2787

Fixes #1729

The C# implementation of IRenameRewriterLanguageService.LocalVariableConflict was returning conflicts any time a related invocation expression bound to a local/parameter, but this condition is not indicative of a conflict when the local/parameter is of a delegate type. This change prevents reporting this particular kind of conflict on references to locals & parameters of a delegate type.