- 29 2月, 2020 1 次提交
-
-
由 Manish Vasani 提交于
Move back the ContextQuery related extensions and corresponding SyntaxFact APIs up to the shared WorkspaceExtensions project
-
- 28 2月, 2020 4 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Split `ISyntaxKindsService` into two parts: 1. `ISyntaxKinds`: Pure data query interface, which already exists in CompilerExtensions shared project and can be used by analyzers. 2. `ISyntaxKindsService`: The `ILangaugeService` implementation of `ISyntaxKinds` Above split ensures that we can move the `ISyntaxKindsService` language service implementation down to the WorkspaceExtensions project, which in turn ensures that `GetLanguageService<ISyntaxKindsService>` will always succeed in our entire code base. This is currently not true in CodeStyle fixes layer due to the fact that the language service implementation is defined in Workspaces.csproj
-
由 Manish Vasani 提交于
Split ISyntaxFactsService into two parts: 1. `ISyntaxFacts`: Pure data interface to query about syntactic facts. This is moved to CompilerExtensions shared project and can be used by analyzers. 2. `ISyntaxFactsService`: Derives from ISyntaxFacts and ILanguageService and is present in the WorkspaceExtensions shared project. This enables Code fixes and Workspaces layer to access the same functionality via a language service, i.e. `GetLanguageService<ISyntaxFactsService>`. Note that we cannot use a partial declaration for `ISyntaxFactsService` instead of `ISyntaxFacts`. This causes `ISyntaxFacts` to be defined in both the CodeStyle analyzer and CodeStyle fixer assembly (former imports CompilerExtensions and latter imports WorkspaceExtensions), which leads to type conflicts. We also cannot follow the approach taken for `ISyntaxKindsSevice` as it defines the second partial declaration `ISyntaxKindsSevice` which sub-types `ILanguageService` in Workspaces project, leading to the language service not being defined in CodeStyle fixer assembly, which will cause any code fix requesting `GetLanguageService<ISyntaxKindsService>` to fail. The only feasible approach for us to have the functionality available in shared analyzer layer is to split out the pure data query part of the service to a separate type, as done in this PR. I will send a follow-up PR to also split `ISyntaxKindsService` similarly. Hoepfully, these two are the only language services that are commonly used by our analyzers, and we will not require any more such splits.
-
由 Manish Vasani 提交于
Workaround for https://github.com/dotnet/project-system/issues/5925 so resx files in shared projects are visible in Solution explorer
-
- 27 2月, 2020 3 次提交
-
-
由 jnm2 提交于
-
由 Tomáš Matoušek 提交于
* ProjectInfo argument validation * Clean up usage of ToImmutableReadOnlyListOrEmpty * Reorder With- methods * Clean up DocumentInfo and SolutionInfo * Renames * Correct nullability * Add more tests * Fix generator NRE * Rmeove unnecessary checks, dead code * Add more list tests, share test helpers
-
由 Cyrus Najmabadi 提交于
-
- 26 2月, 2020 1 次提交
-
-
由 Jared Parsons 提交于
-
- 21 2月, 2020 5 次提交
-
-
由 Sam Harwell 提交于
* CodeStyle+Workspaces -> CompilerExtensions * CodeStyle+Features -> Analyzers * CodeStyleFixes+Workspaces -> WorkspaceExtensions * CodeStyleFixes+Features -> CodeFixes
-
由 Sam Harwell 提交于
* CodeStyle+Workspaces -> CompilerExtensions * CodeStyle+Features -> Analyzers * CodeStyleFixes+Workspaces -> WorkspaceExtensions * CodeStyleFixes+Features -> CodeFixes
-
由 Sam Harwell 提交于
-
由 Manish Vasani 提交于
Explicitly specify Link attribute for embedded resources in shared project to workaround https://github.com/microsoft/msbuild/issues/5137 Verified that the resources generated in obj directly no longer include the full path.
-
由 Rikki Gibson 提交于
-
- 19 2月, 2020 1 次提交
-
-
由 Manish Vasani 提交于
Extracted from #41363 Third follow-up item from #41462 Apart from adding resx files, changes also include: 1. Moving resource strings duplicated across Workspaces and CodeStyle layer into the shared resx files 2. Source file changes to use the resource strings from the shared resx. We should no longer require use of `#if CODE_STYLE` in the shared layer for the purpose of resource strings.
-
- 15 2月, 2020 1 次提交
-
-
由 Julien Couvreur 提交于
-
- 13 2月, 2020 2 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
- 12 2月, 2020 3 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Manish Vasani 提交于
-
- 11 2月, 2020 3 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
- 08 2月, 2020 1 次提交
-
-
由 Manish Vasani 提交于
Extracts out the changes to core Workspace changes from https://github.com/dotnet/roslyn/pull/41363.
-