The CreateInstanceAndUnwrap call below is failing somewhat randomly in our test runs with an error claiming it can't load Roslyn.Test.Utilities.  So far we've been unable to actually catch this failure under a debugger because as previously stated the failure is random.  The only interesting data we have is that it's much more likely to fail in xUnit2 parallel mode than xUnit1.

     Looking at the code there seems to be an obvious explanation.  The Environment.CurrentDirectory value becomes the resolver path for the newly created AppDomain instance.  If this value doesn't point to the test binaries directory then it would explain the failure.  This is a process wide value that can easily be changed by other code.  Even if the code is careful to reset the value afterwards the intermediate value would be visible across AppDomains and cause this problem.

     A more stable value is AppDomain.CurrentDomain.BaseDirectory.  This value is AppDomain specific, immutable, and was already sufficient to load this particular assembly.
 (changeset 1409768)

Fix Bug 1070773  - option "NewLinesForBracesInObjectCollectionArrayInitializers" will handle Collection, Array and Object Initializers

Changing the New Line option "NewLinesForBracesInObjectInitializers" to "NewLinesForBracesInObjectCollectionArrayInitializers" which will now affect Collection Initializer and Array Initializers in addition to Object Initializers. Check Bug 853748 regarding this.

This change does not affect the Custom formatted Array Initializers and Collection Initializers since we have appropriate Suppress operation. (changeset 1409656)

When the expression compiler sees a diagnostic indicating that a reference should be added to the compilation, it should invoke DkmClrAppDomain.LoadAssembly so that the debugger can try to load and then re-invoke the expression compiler.

TODO: Make this work for WinMDs (1114866).

CR: ChuckS; KevinH; VladRes; PaNelson (changeset 1409642)

AttributeLists of the Parameter should be left untouched by the VB PrettyLister. The AttributeLists of the other statement is formatted in such way that the first attributeList of the lot is formatted with expected indentation and the rest of the attributeList anchors to the first attributeList and moves accordingly. (changeset 1409606)

This will ensure that case sensitive matches are placed above insensitive ones in the NavigateTo results list.
***NO_CI***
 (changeset 1409531)

this is compilation end analyzer. this is supposed to squiggle name and fade out whole code block when it detects unused declarations. but for now, it only reports the issue in error list and not in editor due to engine limitation.

we will use this analyzer to drive making compilation end analyzer experience better. so that we can get things like squiggle, fading out or code fix work with compilation end analyzer. (changeset 1409499)

Remove unnecessary references to Microsoft.VisualStudio.Composition.Configuration (changeset 1409457)

Move the .nuget folder to the correct directory in Open.  This was simply missed when moving other parts of the InteractiveWindow. (changeset 1409394)

now it should properly re-tag editor when there are severity changes due to rule set changes or other changes. (changeset 1409269)

Fix failing unit tests in Roslyn.Diagnostics.Analyzers.UnitTests.dll: Test had a comment that it needed to be updated once we move to a newer corlib which defines Array.Empty<T> (changeset 1409173)

there is no code change, just added some comments on why code bail out and use full semantic model rather than speculative semantic model in some situation. (changeset 1408980)

We have some project references between projects that are either completely unnecessary or almost so, which have the nice side effect of creating build warnings due to version mismatches. Remove most of them, and move a single unit test helper next to the unit tests that are using it. (changeset 1408938)

but we probably need to move to content based version rather than file stamp. (changeset 1408928)

The OpenSourceDebug package should reference MSBuild 14.0 since that's what the workspaces layer references, and that's what's loaded in VS when the code runs anyways. (changeset 1408875)

The EditorFeaturesTest.csproj file was pointing to the deleted References directory causing a git clone + build of Roslyn.sln to fail. Fixing up the project to point to DevEnvDir instead. (changeset 1408717)

The BasicIntellisense suite was broken due to a bug in BasicUndo.  This
was fixed in the most recent version.  Upgrading us to that to fix the
suite. (changeset 1408633)

Code in an #else block was not updated by the formatter resulting in a build break.  (changeset 1408230)

Our script for replaying TFS changes on our Git repo missed a few files in the last change.  TFS labeled these files as "undeleted" which the script doesn't appear to handle correctly.  This isn't surprising as this comes about when TFS applies a roll back of a roll back (not very common).

Manually adding these files to the Git repo to unblock the build.

     Background:

     As discussed in the dev team all hands all code under the GitHub dotnet foundation is using a single process for contribution, API review, infrastructure and coding style. The idea is to present a unified view to our customer and give them a single story for contributing to any project under the dotnet foundation.

     https://github.com/dotnet/corefx/wiki/Contributing#c-coding-style

     The coding style transition is automated using a Roslyn based rewrite tool:

     https://github.com/dotnet/codeformatter

     This will be applied in stages across our developer tree. Right now the focus is on the Open directory as this is what is being presented on github. Code owners will be contacted before the transition happens.

     Note: this is a soft style requirement. There are no build errors that come from this change.
 (changeset 1408227)

Treat static properties and fields like extension methods and search from namespaces that would resolve cases where the compiler partially binds to the wrong type.

Note: this does not happen in VB.  If VB cannot bind the return type of a property it does not attempt to bind inside the property. (changeset 1408173)

"When a file is replaced on disk its timestamp should be set to the most recent of its creation time and last write time. Also updating FileKey to use last-write-time, since that's what it's comment explicitly calls for." (changeset 1408149)

Bug-1116460 : Renaming the scripting assemblies and namespaces. Making corresponding changes in InstallDogfood and RoslynBuildAndTtest to account for new names (changeset 1408119)

     recent perf regression shows that we are allocating too much memory on one particular spot in the tree serialization.

     this change is to remove that bottleneck. basically, rather than creating temporary array just to pass it in to the serializer, it will iterate through elements itself and serialize each element. (changeset 1408094)

      Build new VSIX which contains just the interactive window
      Rename interactive window assemblies
      Include new VSIX in the list of files to be inserted

     Public API cleanups
      Move command constants into commands namespace
      Move operations onto IInteractiveWindowOperations interface
      move IContentTypeMetadata to internal class
      Make InteractiveContentTypeNames internal, move constants to InteractiveConstants
      Make RestoreHistoryEditTag internal
      Make CommandIds internal
      Make Guids internal
      Fix AV when opening interactive window (changeset 1408072)

This is necessary in order to present strings that originate from external APIs (e.g. the System.XML) with proper localization when they are embedded in diagnostics.
***NO_CI***
 (changeset 1408070)

This one was straightforward. There were just a couple of transgressions - both easily fixed. (changeset 1408016)