# Conflicts:
#	src/Features/CSharp/Portable/CSharpFeaturesResources.resx
#	src/Features/Core/Portable/Diagnostics/Analyzers/IDEDiagnosticIds.cs
#	src/VisualStudio/CSharp/Impl/CSharpVSResources.resx
#	src/VisualStudio/CSharp/Impl/Options/Formatting/StyleViewModel.cs
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.cs.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.de.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.es.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.fr.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.it.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ja.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ko.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pl.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.pt-BR.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.ru.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.tr.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hans.xlf
#	src/VisualStudio/CSharp/Impl/xlf/CSharpVSResources.zh-Hant.xlf

Fixes #35611

* Allow readonly methods to accept span parameters from stackalloc

* Cleanup

* Add relevant spec language to CheckInvocationArgMixing

* isReadOnlyInvocation -> isReceiverRefReadOnly

* Move isReceiverRefReadOnly to local function

Fixes #35661

* Also fix the type of a bound node (argument to a ctor) so it agrees with the corresponding parameter.
Fixes #35764
* Handle nested stackalloc initializers in the spiller and add a test that it works.

* Update dependencies from https://github.com/dotnet/arcade build 20190503.8

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8

* Update dependencies from https://github.com/dotnet/arcade build 20190504.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1

* Update dependencies from https://github.com/dotnet/arcade build 20190505.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2

* Update dependencies from https://github.com/dotnet/arcade build 20190506.12

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12

* Update dependencies from https://github.com/dotnet/arcade build 20190507.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7

* Update dependencies from https://github.com/dotnet/arcade build 20190508.5

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5

* Update dependencies from https://github.com/dotnet/arcade build 20190509.9

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9

* Update dependencies from https://github.com/dotnet/arcade build 20190510.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2

* Update dependencies from https://github.com/dotnet/arcade build 20190511.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1

* Update dependencies from https://github.com/dotnet/arcade build 20190512.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1

* Update dependencies from https://github.com/dotnet/arcade build 20190513.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3

* Update dependencies from https://github.com/dotnet/arcade build 20190514.13

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13

* Update dependencies from https://github.com/dotnet/arcade build 20190516.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2

* Update dependencies from https://github.com/dotnet/arcade build 20190516.4

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.4

* Update dependencies from https://github.com/dotnet/arcade build 20190517.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7

* Update dependencies from https://github.com/dotnet/arcade build 20190518.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2

* Update dependencies from https://github.com/dotnet/arcade build 20190520.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1

* Fix up XLF files

* Clear AssemblyVersion

* Add Sort Usings command back to the Edit > IntelliSense menu

* Remove old style command args and registration

X64 testing

More external access

* Separate script arguments from the script file for InteractiveCompiler tasks

* Added command line arguments as quoted text

Limit use of IBuiltInAnalyzer.OpenFileOnly

Fix violations of RS1024 in Microsoft.CodeAnalysis.EditorFeatures

* this addresses issue where we repeatedly trying to create different compilations in OOP causing a lot of allocations.

issue was OOP solution crawler processing documents from different proejcts rather than per same project. basically void the benefit the solution crawler (processing same project one at a time so that all share same compilation/symbols and etc)

root cause was due to documents got removed and then readded to remote workspace solution. and that was happening because remote workspace could moved backward.

fix is making sure that workspace can't never move backward.

...

some background.

originally, RemoteWorkspace was added to OOP as pure cache. so that, when someone need a soluton matching one from VS, OOP doesn't need to recreate the solution from scratch.

so, it always has set RemoteWorkspace to last requested solution from VS (a snapshot of VSWorkspace.CurrentSolution)

what that means is if there are multiple requestsion from VS with snapshot1, snapshot2, snapshot1, snapshot3

remoteWorkspace.CurrentSolution could move from snapshot1 -> snapshot2 -> snapshot1 -> snapshot3

it was all fine as pure cache since as a cache, there is no such concept of moving forward or backwawrd. it is just a snapshot. and RemoteWorkspace is just something we need to have due to solution having backpointer to workspace and I can do incremental update to be more efficient. but functionally, workspace wasn't required.

this got more complicated when solution crawler is added to OOP to support "Find all reference" and "navigate to"

strictly, solution crawler doesn't care whether solution going backward. as long as we can diff 2 solutions correctly, going backward is just another change in solution and solution cralwer handle those correctly.

problem is perf. now it causes unnecessary work. causing a lot of unnecessary allocation.

what make it worse is that, we mark document removed as high priority to process them faster. and we let solution crawler process them in any order rather than per project since removed document call back can't access compilaton. but since we allowed remote workspace solutoin to go back and forth, we end up mark a lot of document, high priority and start to process them not in group causing even more allocations.

now, we only allow remote workspace to move forward. never backward.

* updated comment

Merge release/dev16.2-preview1 to master

Merge remote-tracking branch 'dotnet/release/dev16.2-preview1' into merges/release/dev16.2-preview1-to-master

* Revert "Revert "Make compilation outputs available via a workspace service (#34809)""

This reverts commit f4892bc4.

* Handle non-absolute path set by VB Web App IntelliSense project

Cherry-pick PR #34909

Fixes #25997

Make IPackageInstallerService implementation lazy

Localize "General" groupbox header in the Formatting>General option page

Fix mismatched use of MEF 1 and 2

Fix violations of RS1024 in Microsoft.CodeAnalysis.Workspaces

Fix violations of RS1024 in Microsoft.CodeAnalysis.VisualBasic.Features

Remove legacy IVTs

Work around integration test crash in light bulb controller

Include dump file size in log output