Co-authored-by: NSam Harwell <sam@tunnelvisionlabs.com>
Co-authored-by: NManish Vasani <mavasani@microsoft.com>
Co-authored-by: NDavid Barbet <dabarbet@microsoft.com>
Co-authored-by: NJoey Robichaud <jorobich@microsoft.com>
Co-authored-by: NCyrus Najmabadi <cyrus.najmabadi@gmail.com>
Co-authored-by: NDavid Wengier <david.wengier@microsoft.com>
Co-authored-by: NShen Chen <cos_ifne@hotmail.com>
Co-authored-by: Nmsftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com>
Co-authored-by: NSam Harwell <Sam.Harwell@microsoft.com>
Co-authored-by: NFredric Silberberg <frsilb@microsoft.com>
Co-authored-by: NGen Lu <gel@microsoft.com>
Co-authored-by: NPetr Onderka <gsvick@gmail.com>
Co-authored-by: NTomáš Matoušek <tmat@users.noreply.github.com>
Co-authored-by: NYoussef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: NCristiano Suzuki <crsuzuki@microsoft.com>
Co-authored-by: NRikki Gibson <rigibson@microsoft.com>
Co-authored-by: NJoey Robichaud <joseph.robichaud@microsoft.com>
Co-authored-by: NYair Halberstadt <yairhalberstadt@gmail.com>
Co-authored-by: NAllison Chou <allichou@microsoft.com>
Co-authored-by: Nmeziantou <meziantou@live.fr>
Co-authored-by: NVritant Bhardwaj <vrbhardw@microsoft.com>
Co-authored-by: NJulien Couvreur <jcouv@users.noreply.github.com>
Co-authored-by: NShen Chen <shech@microsoft.com>
Co-authored-by: NShen Chen <Cosifne@users.noreply.github.com>
Co-authored-by: NChris Sienkiewicz <chsienki@microsoft.com>
Co-authored-by: NJinu <jinuj@microsoft.com>
Co-authored-by: NMarius Ungureanu <therzok@gmail.com>
Co-authored-by: NJason Malinowski <jason.malinowski@microsoft.com>
Co-authored-by: NBen Lichtman <belichtm@microsoft.com>
Co-authored-by: NBen Lichtman <uniqueiniquity@users.noreply.github.com>
Co-authored-by: NDavid Wengier <dawengie@microsoft.com>

* More tests.
* Make the delegate keyword recommender a bit stricter.

Manual fixes for IDE0059 violations for assignments of a non-constant value (we do not offer code fixes to remove such assignments which could have side effects)

Remove conditional code that was added due to older version of Microsoft.CodeAnalysis in CodeStyle layer

Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Extensions/SyntaxNodeExtensions.cs

Split ISyntaxFactsService into two parts:

1. `ISyntaxFacts`: Pure data interface to query about syntactic facts. This is moved to CompilerExtensions shared project and can be used by analyzers.

2. `ISyntaxFactsService`: Derives from ISyntaxFacts and ILanguageService and is present in the WorkspaceExtensions shared project. This enables Code fixes and Workspaces layer to access the same functionality via a language service, i.e. `GetLanguageService<ISyntaxFactsService>`.

Note that we cannot use a partial declaration for `ISyntaxFactsService` instead of `ISyntaxFacts`. This causes `ISyntaxFacts` to be defined in both the CodeStyle analyzer and CodeStyle fixer assembly (former imports CompilerExtensions and latter imports WorkspaceExtensions), which leads to type conflicts. We also cannot follow the approach taken for `ISyntaxKindsSevice` as it defines the second partial declaration `ISyntaxKindsSevice` which sub-types `ILanguageService` in Workspaces project, leading to the language service not being defined in CodeStyle fixer assembly, which will cause any code fix requesting `GetLanguageService<ISyntaxKindsService>` to fail. The only feasible approach for us to have the functionality available in shared analyzer layer is to split out the pure data query part of the service to a separate type, as done in this PR. I will send a follow-up PR to also split `ISyntaxKindsService` similarly. Hoepfully, these two are the only language services that are commonly used by our analyzers, and we will not require any more such splits.

Extracts out the changes to core Workspace changes from https://github.com/dotnet/roslyn/pull/41363.

Mostly straightforward annotation. The SymbolComparer is deleted because
the code was unused.