1. 11 12月, 2015 20 次提交
  2. 10 12月, 2015 14 次提交
    • D
      Merge pull request #7366 from DustinCampbell/watson-bug-fix · 8126d4da
      Dustin Campbell 提交于
      Watson: Fix crash when accessing CodeProperty.OverrideKind property for property not contained by a type
      8126d4da
    • H
      Merge pull request #7361 from heejaechang/fixtest2 · f47bfec4
      Heejae Chang 提交于
      add ResultDir to TestResult rather than retrieving it from ResultsFil…
      f47bfec4
    • D
      Merge pull request #7375 from davkean/nuget · 17e6725c
      David Kean 提交于
      Upgrade NuGet to 3.4.0.247 and increase restore timeout
      17e6725c
    • D
      Upgrade NuGet to 3.4.0.247 and increase restore timeout · e6225efa
      David Kean 提交于
      NuGet's timeout for restoring us is too short, causing a
      timeout on our internal build machines when the CPU is
      under high load. We need to upgrade to 3.4 to control
      this.
      
      Increase this to 20 minutes from the default 5 minutes.
      e6225efa
    • J
      Merge pull request #7316 from jasonmalinowski/remove-unneeded-project.lock.json-file · 4b07692f
      Jason Malinowski 提交于
      Delete build/ToolsetPackages/project.lock.json
      4b07692f
    • D
      Code Model shouldn't expose code elements for invalid members (e.g. methods in... · bc4d8064
      Dustin Campbell 提交于
      Code Model shouldn't expose code elements for invalid members (e.g. methods in namespaces) or fire events for them
      
      This change ensures that Code Model never considers members that are un-supported, such as methods declared directly inside of namespaces. It's possible that we may eventually add support in code model for top-level methods specifically within script code, but we don't support today.
      bc4d8064
    • M
      Merge pull request #7349 from mattwar/Bug7348 · 0b31fbc8
      Matt Warren 提交于
      Add support for NotInheritable and NotOverridable
      0b31fbc8
    • J
      Merge pull request #7315 from jasonmalinowski/merge-update-1-to-master · 732a05ae
      Jason Malinowski 提交于
      Merge update 1 branch to master
      732a05ae
    • D
      Merge pull request #7370 from davkean/disable · 2625e3aa
      David Kean 提交于
      Disable FullQualifiedTests.TestCaseSensitivity3 due to flakiness
      2625e3aa
    • J
      Delete build/ToolsetPackages/project.lock.json · 4b68a5b0
      Jason Malinowski 提交于
      Whereas other project.lock.json files are checked in because other
      tools consume them, this is consumed by nothing. All it does is make
      merging between branches more annoying.
      4b68a5b0
    • M
      Place sealed modifier before override · b6516558
      Matt Warren 提交于
      b6516558
    • D
      2c9dee2f
    • D
      Watson: Fix crash when accessing CodeProperty.OverrideKind property for... · 313eb8e0
      Dustin Campbell 提交于
      Watson: Fix crash when accessing CodeProperty.OverrideKind property for property not contained by a type
      
      The root cause is based on analysis of a Watson crash dump with ~300 hits. The call stack looks like this:
      
      ```
      microsoft_visualstudio_languageservices_csharp_ni!Microsoft.VisualStudio.LanguageServices.CSharp.CodeModel.CSharpCodeModelService.GetOverrideKind
      microsoft_visualstudio_languageservices_implementation_ni!Microsoft.VisualStudio.LanguageServices.Implementation.CodeModel.InternalElements.AbstractCodeMember.get_OverrideKind
      envdte80!EnvDTE80.CodeProperty2.get_OverrideKind
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeController+AllLanguages+AttributeIsNew.GetAttribute
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeController.GetAttribute
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeController.GetProperties
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.FireAddEvent
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.AddElement
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler.WalkCodeElement
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.AddElementWithChildren
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.RebindChildren
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.ChangeElementUnknown
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler+CodeModelCache.ChangeElement
      microsoft_visualstudio_modeling_artifactmapper_vshost!Microsoft.VisualStudio.Modeling.ArtifactMapper.VSHost.CodeHandler.codeModelEvents_Changed
      ```
      
      After analysis of the dump, I was able to reproduce the call stack using the following steps:
      
      1. Create new Class Library
      2. In the Solution Explorer, right-click on Class1.cs and choose View->View Class Diagram from the context menu.
      3. Add a new property inside Class1.
      4. Copy and paste that property *twice* inside the enclosing namespace of Class1.
      
      This causes an "Unknown" code model event to fire which the Class Designer responds to by digging through its elements and accessing various properties. One of those properties (`OverrideKind`) retrieves the containing type of the element, but that's null for the properties contained in a namespace and the call throws. So, the fix is to add a couple of simple null checks. Note that this affects all members, so I added tests for fields, events and methods as well.
      313eb8e0
    • M
      Merge pull request #7215 from mavasani/InvalidDiagnosticLocation · cd366830
      Manish Vasani 提交于
      Gracefully handle analyzer diagnostics with location outside the current compilation
      cd366830
  3. 09 12月, 2015 6 次提交