* Simplify codegen for struct declaration patterns
* Move box to perform the conversion only when the test succeeds

* Reject ref as an invalid modifier for accessors

* Updated test plan

* PR Comments

* Accept ref in parsing, and error out in binding

* Update test plan

* Fix build break

MemberSemanticModel.GetBoundLambdaOrQuery should use GetAdjustedNodePosition helper to ensure proper handling of zero-length tokens at the beginning of a syntax node. (#24049)

Fixes #23883.

Fixes VSO 547049

* added Microsoft.VisualStudio.IntegrationTest.Setup.vsix to signing

* removed duplicated entry.

* now test setup vsix is part of signtooldata.json no need to have special case for it.

also made exception to have better message

Merging on behalf of @alrz. Thanks!

There were two separate bugs here:
    1) Fixing up the MVID of the binary was being done *after* signing,
    when it should be done before.

    2) System.Reflection.Metadata has a bug where calculating the
    checksum occurs before signing, when it should happen after.

Both of these isues have been fixed and the helper utility that checks
to see whether a binary was signed has been changed to verify that the
signature and checksums of the binaries are valid, not just that the
signed bit is set on the assembly.

Fixes #23521

Merging on behalf of @alrz. Thanks!

When I added this interface, I had the implementations expose their
applicable type not by metadata, but by simply calling a method on
the instance. This is problematic if the implementation is in a
different assembly as we'll load it too early. This is causing F#
to load when they shouldn't.

This is intended as a temporary shim that fixes the perf load for
the F# case (the only current exporter of these outside the Roslyn
repo itself) without forcing an interface change. This will get deleted
soon enough once we migrate to newer Quick Info APIs.

This change removes the following APIs:
- TypeSymbol.BaseType
- TypeSymbol.Interfaces
- TypeSymbol.AllInterfaces
- NamedTypeSymbol.TypeArguments
- TypeParameterSymbol.ConstraintTypes

These APIs simply delegate the work to APIs with "NoUseSiteDiagnostics" suffix and are not supposed to be used inside compilers. They were left in the code-base because they used to be part of the public surface and the names were nicer, but they are no longer part of the public surface.

* Suggest stackalloc keyword in Span legal places

* Address PR Comments

* More PR Feedback

* Clean up

The conditional build of net45 was added when we didn't support any
desktop targetframeworks on Linux. Now that it's supported we should be
building all flavors of the utilities there.

* Pass in optional arguments by ref

* IOperation tree tests

* PR Comments

The dotnet CLI has been seeing a hang from VBCSCompiler in their build
on non-Windows platforms. The cause is this:

    1. dotnet build starts a child process to do `dotnet pack` and
    redirects its output to a buffer.
    2. `dotnet pack` starts a child process to do `compile`.
    3. `compile` starts vbcscompiler because one is not already running.
    4. VBCSCompiler inherits the output handles from (1).
    5. VBCSCompiler process finishes and processes (1) and (2) exit.
    6. The parent `dotnet build` process  is waiting for (2) to exit,
    which it has, but also to see EOF on its output stream. Because that
    stream has been captured and held open by VBCSCompiler, the EOF
    never comes.
    7. `dotnet build` hangs.

This change fixes the problem by creating new streams for input and
output for the compiler server process. This isn't quite what we do on
Windows -- on Windows we create invalid handles for the input and output
-- but it's as close as we can get using the portable APIs in
System.Diagnostics.Process.

Fixes #23734

* Source packages improvements

* Target net45

* Only generate source link when emitting PDBs

* Make BuildBoss happy

Merged it into the non-desktop specific project. Will make porting our
test projects to netcoreapp easier.

The portable test utilities project already multi-targets between
netstandard, netcoreapp and desktop. Having part of the desktop code
exist in a separate assembly makes it even harder to multitarget our
test projects. Combining them all together and fully embracing
multitargeting here.

This is in preparation of moving several other compiler test projects to
test against coreclr / mono.

fixed issue where same analyzer reference is installed in both vsix and nuget. deduplication in inproc analyzer manager wasn't present in OOP case. (#23772)

this doesn't address our workitem to merge those two. that work is a separate work item. this just follow what we currently do in proc.

Ensure-DotnetExe should be Ensure-DotnetSdk.

Need to publish the individual VSIX projects which used to represent our
uber VSIX package. The LUT + project system still use these for their
integration tests.