Merge dev15.3.x to master

Show builder for async lambda

Fixes #18985

Fixes https://github.com/dotnet/roslyn/issues/20937

Add a workaround for P2P references with reference assemblies

Report progress as we update the package index.

Merge dev15.3.x to master

Remove dead code from GenerateConstructor.

# Conflicts:
#	build/Targets/Imports.targets
#	src/EditorFeatures/Core/EditorFeatures.csproj

Initialize snippets after solution load is complete

Show modifier/method/type block declaration keywords after attribute …

Disable NETCore version check

Fixed smart variable naming

Works around https://github.com/dotnet/roslyn/issues/20945

Disable NETCore version check

Diagnostic analyzer to identify out of range placeholders in a format string.

Works around https://github.com/dotnet/roslyn/issues/20945

Fixes https://github.com/dotnet/roslyn/issues/20837

Wait for encapsulate field to complete

Check for prefix match before hard selecting when backspacing

Add an analyzer that offers to convert from a lambda to a local function.

* Improve type argument list parsing in error conditions.

* Fix type.

* Remove unused method.

* Improve generic parsing in a couple of additional cases.

* Share more code.

* Inline method.

* Fix logic.

* Add tests.

* Restore test class.

* REmove case, and add test.

Ensure we disconnect any projection buffers we create for views

Add null check in ExplicitInterfaceTypeCompletionProvider for invalid code

* Don't report modifier errors while parsing.

* Fix bad merge.

* restore code.

* Fix test.

* Remove old resource

* Alternative way to do partial checking.

* Alternative way to do partial checking.

* Simplify formatting.

* Restore formatting.

* Restore formatting.

* Restore formatting.

* Restore formatting.

* Restore formatting.

* Give a proper message.

* Update error positions.

* Update error positions.

* Update error positions.

* Actually report error on bad modifier.

* 	Simplify implementation of parsing constraints.

* Add tests.

Fixed Inline Temporary Variable refactoring

Swaps out all uses of CapturedVariablesByLambda for functions on the
Scope tree.

The reason the baseline changed is that the order of enumerating closures changed. I briefly looked into matching the behavior, but the problem is that the closure order in the old visitors is determined by the visitation of captured variables, not visitation of the closures themselves. More specifically, an item is only added to the CapturedVariablesByLambda dictionary when ReferenceVariable encounters a captured variable.

In contrast, the visitation of the Scope tree looks at closures in an in-order traversal of the tree, stopping at the first introduced closure, not necessarily the closure which first captured a variable.

One obvious consequence of this changing is that the old ordering for a series of nested lambdas was effectively post-order -- the interior closures would be added to the visitation first, since they would be added from the perspective of the captured variable looking up, instead of the visitor looking down. This particular case is responsible for all the baseline changes that I have seen.

When I looked into replicating this traversal order I found it complicated and pretty counter-intuitive. Since the baseline change was so low in emitted IL, I thought it better to keep a very natural in-order tree traversal and just rebaseline a few tests.

Fixes https://github.com/dotnet/roslyn/projects/26#card-3753318