fix issue with telemetry.

it looks like diagnostic telemetry got broken when we introduced a new flag for diagnostic engines in update 1.

also recent engine v2 changes didn't report all telemetry data

Merge master back to stabilization

* Bug 217740: Repro and test harness for C#

* Testing and fixing loading scenario in C# and VB

* Verifying VB case using attribute on field

* Adding more tests

* Adding VB tests

* Adding tests

* More tests on fields with double-attributes

* New test constraint

* Fixing VB side to new test constraints

* Fixing C# side to new test constraints

* Fixing remaining tests

* Adding comments

* Fixing VB field scenario too

Assert that completion has a TypeInferenceService

Port https://github.com/dotnet/roslyn/pull/11398 over to SymbolKeys. …

Port https://github.com/dotnet/roslyn/pull/11398 over to SymbolKeys.  The previous fix only addressed symbol ids.

Adjust implementation of MemberSemanticModel.GetEnclosingBinderInternal to avoid NullReferenceException.

Iterator Property setter should not be treated as an iterator

* Initialize the error list toggle state when error list is initialized

Currently, we initialize the error list toggle state only when workspace changes (solution add/remove/reload or project add/remove/reload) OR when FSD options change. However, if you start VS and bring up error list without opening any solution or changing FSD options, we might show stale error list state if your settings file or settings store changed from last VS session. Fix is to initialize the error list toggle state as soon as error list is initialized.

Fixes #11539

* Don't change the error list toggle state on workspace changes.

Utilize new archival options

Only archive when failing, rather than always.

Do not report warnings for malformed InformationalVersionAttribute values

Fix a flaky compiler suite

Adjust implementation of MemberSemanticModel.GetEnclosingBinderInternal to avoid NullReferenceException.

The change addresses the situation when SemanticModel is created to speculate on a With block and the function is trying to locate a binder for the With expression within the block.

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=187910&_a=edit.

made 2 states (designer or not) to 3 states (designer, not, unknown)

The intent of ServerRespectsAppConfig was to verify the server actually read the default timeout value from the application configuration file.  The test validated this in a very indirect way:

- Changing the value in app.config
- Starting the server
- Verifying it stopped in the given time frame

This can fail for a number of reasons: computer load during the test, another process communicating with the server, etc ...

Changed the test to just directly test the value being read from application settings.

Justification for ask mode: this test was flaky enough to break signed builds.

Restore backward compatibility in the way conversion from a reference type to an intrinsic value type is evaluated.

Disallow sealed overrides in structs

Allow foreach with string even if string does not implement foreach pattern.

Add better error messages for public signing

when it is unknown status, we will leave designer attribute as it used to be. and not touch anything.

one can go into unknown state if there is no explict designer attribute found but there are some types
with errors.

follow up on https://github.com/dotnet/roslyn/pull/11479

changed low memory error message to new one as we decided in the meeting

Restore backward compatibility in the way conversion from a reference type to an intrinsic value type is evaluated.

Fixes #9887.

* Fix #11068: Interactive window should allow to add commands to history without execution

* Fixed style: braces moved on a new line.

* Create new instance of language buffer for every history entry

* - Use ITextBufferFactoryService to create historyBuffer
- Move state check to the beginning of the method
- Use InvalidOperationException instead of ArgumentOutOfRangeException

* _buffer.Flush() should be called before calculation of insertionIndex

* - Added "exception" part to the 'AddToHistory' method description
- Added test that verifies history navigation

Add more tests for recently-fixed dynamic bugs

Allow debugging output when debugging unit tests

Improve error message for failing to sign on CoreCLR mac/linux