We need to be more conscious about producing synthesized symbols during lowering in order to enable EnC of method bodies whose lowering produce such symbols (e.g. lambdas, iterators, dynamic sites, etc.).

     This change refactors synthesized symbols in C# so that all symbols produced during lowering phase implement an interface (ISynthesizedMethodBodyImplementationSymbol) that can be used in the emit phase to retrieve information necessary for updating the corresponding metadata entities should they enter EnC.

     I also attempted to somewhat improve and increase consistency of the naming of synthesized symbols involved in this change.

     No new functionality is added by this change. (changeset 1247789)

Crefs ignore inherited members, but I missed a few cases.

1) Binder lookup dropped them, but semantic model lookup (totally separate code path) did not.
2) Base interface members were dropped, but System.Object members were not (except with recovery code during binding). (changeset 1245954)

     Bug (934091)  fix and additional coverage for conflict error messages when conflict between static local and local are defined with the same name

     Additional coverage added to ensure that single diagnostic is generated irrespective of order. (changeset 1242502)

Bug Fix 933719 on diagnostic message to remove term VB Core as its possible to repro without using VB Core.    Change Tests and add additional coverage for command line and Compilation scenarios without VB Core being used.
 (changeset 1241434)

There were issues with the PE headers generated by the compiler when emitting assemblies with no win32 resources (default behavior when you call Compilation.Emit).

If the size of a section is zero, then the relative virtual address should also be zero.  Previously, we would unconditionally set the address of the resource section to the end of the most recently preceding section that contained any data.  This was wrong in and of itself, but it also had the knock-on effect of breaking the logic in PeWriter.WriteRelocSection that is supposed to pad the last section to align with the file alignment boundary. (changeset 1240642)

When warnaserror is set for a project, we set the GeneralDiagnosticOption on CompilationOptions to be error and that turns any diagnostic that doesn't have a specific option set to an error. This means diagnostcs from simplify typename etc. get turned into errors and squiggles everything. The consensus from the diagnostic team meeting was this:
* When doing warn-as-error, don't raise severity for anything *below* warning (info or hidden).
* When doing suppress-all-warnings, don't lower severity for anything *above* warning (error).

Implementing this in C# and VB. Tests will follow.
 (changeset 1239863)

Use $(VisualStudioVersion) for MinimumVisualStudioVersion so the project won't trigger project upgrade dialog in higher versions of Visual Studio. (changeset 1239621)

When loading a .ruleset file we first validate it against a schema. However, we have a single XmlSchema object to do this, held in a static field. This means that if VBCSCompiler.exe is processing multiple build requests at once we may end up using this object simultaneously from multiple threads, and it isn't thread-safe.

The fix here is to create a new XmlSchema every time we need it. (changeset 1239493)

Without this, the option service couldn't distinguish between the two, and so it was loading the feature-specific option serializers for non-feature-specific options. This not only was a waste of resources (the VB serializers don't need to be loaded if all you have is C# open), but also risked deadlocks due to the subtleties in how serializers in VS must be created. (changeset 1238958)

Currently the compilers raise an error if a FileNotFoundException occurs while trying to load the ruleset file. However, DirectoryNotFoundExceptions are not handled, causing the compiler to crash.

Here we update RuleSet.LoadFromFile to utilize methods from FileUtilities. These already catch a number of exceptions related to reading files, and repackage them as IOExceptions. RuleSet.GetDiagnosticOptionsFromRuleSetFile can then handle them all by catching IOException. (changeset 1238689)

Ruleset parser was parsing only the rules from the managed analyzer. This was our original design but we recently changed it so that each custom analyzer will have it's own analyzer id but i forgot to remove this restrcition when I made that change. Removing the restriction. (changeset 1238580)

- Rename C# and VB subclasses to CSharpDefinitionMap and VisualBasicDefinitionMap, so that it's obvious that one is dealing with language specific subclass rather than the common superclass.
- Move some code that can easily be shared between C# and VB to the common superclass.
- Move local visitors to a separate file, make then nested in the DefinitionMap, so that C# impl matches VB.
 (changeset 1238157)

 Static Local : Additional Error for Duplicate Declarations (changeset 1238123)

Note: There is a bunch more code that could be deleted from the compiler perf tests. However, this is all I had appetite for at the moment and is the minimum that I required to get rid of for the experiement I am working on. (changeset 1237733)

The addition of an unserializable field (aliases) means we need to have custom serialization logic. (changeset 1237606)

Bug Fix for Devdiv: 931186. Makes type inference work inside short hand array initializer notations such as int[] a = {1,2,3}. Added some tests to cover this scenario and Implicit Array creation scenarios (var a = new[] {1,2,3}) (changeset 1237541)

Otherwise we don't recognize "C:\alpha\beta\Gamma.ruleset" as a full path, and incorrectly treat it as a relative path. (changeset 1237530)

Bug fix which prevented pinvoke methods declared using VB declare syntax from being found in SymbolFinder.FindReferencesAsync.   Added coverage to ensure VB/C# find pinvoke declarations. (changeset 1237455)

Make UnresolvedAnalyzerReference public. It is useful outside of the command-line compilers. (changeset 1237429)

Diagnostic Analyzers should be able to say that out of the rules that are produced by them, some are enabled\disabled by default (if no user options are passed in).

     - Adding a property to DiagnosticDescriptor that can be set by analyzers. The expression of this property needs to propagate through Diagnostic and DiagnosticData.
     - Making the compiler and analyzerdriver not even run an analyzer which is completely disabled and for the partially disabled ones, suppress the disabled rules.
     - Cnge all existing analyzers to set this to true. For the FxCop ones, based on audit of usefulness, we should turn off a whole bunch of them by default in the future.
 (changeset 1236992)

Allow for the exclusion of tests that require Visual Studio to be installed to run correctly. To exclude these tests, add the flag "/-trait "Environment=VSProductInstall"" when running xunit. Also, a few whitespace style changes were made. (changeset 1236761)

previously, it was handled by alignment rule by engine, but this caused an issue when combined with anchor rule.

now, I am taking different approach where rather than using alignment rule, I added new spacing option where engine will dynamically determine spaces to put after a token based on current indentation.

this should take care of this kind of scenario more cleanly. other approach would be using relative indentation, but that will be more expensive since it would create dependency between tokens and restrict how much we can concurrently format.

fixes # 63 (changeset 1236659)

previously, it was handled by alignment rule by engine, but this caused an issue when combined with anchor rule.

now, I am taking different approach where rather than using alignment rule, I added new spacing option where engine will dynamically determine spaces to put after a token based on current indentation.

this should take care of this kind of scenario more cleanly. other approach would be using relative indentation, but that will be more expensive since it would create dependency between tokens and restrict how much we can concurrently format.

fixes # 63 (changeset 1236659)

Adds support for method body visualization to MetadataVisualizer. (changeset 1236565)

cleaning up some of formatting options that no longer needed. (changeset 1236464)

DiagnosticSeverity.None is something that's not used by the compilers at all. Some IDE analyzers produce None diagnostics. The IDE uses it to mean diagnostics that are hidden (and are used for other purposes like offering fixes or graying out text). None means it is disabled. Calling this hidden so as to avoid that confusion.

Also updating the ruleset parser to understand Info and Hidden.
 (changeset 1236447)

now it should behave a bit better than before while typing. (changeset 1235522)