The Open directory contains several projects that rely on having a compatible version of Visual Studio 2015 installed in order to build properly.   At this time there is no version of Visual Studio that will work over the long term that we can ask customers, and Jenkins, to move to in order to edit and build Roslyn.sln on master.  Our dependency on the VS SDK just evolves too rapidly.

After some discussion I decided to put two solution files into the repo:

     - Roslyn2013.sln:  This solution is usable on a machine with only Visual Studio 2013 installed.  This unfortunately won't contain all of the new items we are releasing but at least gives customers a stable base to iterate on.
     - Roslyn.sln: This solution contains every project we've released and will work with some builds of 2015.  Likely it will work with the most recent CTP but I have not verified that (just don't have the right setup to do so).

The long term plan here is to always be able to edit, build and debug the master branch with an RTM version of Visual Studio.  But until we hit RTM (or really RC) of Visual Studio 2015 we are going to have a hybrid solution to keep both us and customers productive.   (changeset 1405691)

The compiler emits catch-all handler to all async methods. In case of async void methods we also emit the offset of the catch handler to PDB, so that the debugger can pretend that exceptions thrown by the async method are unhandled. Otherwise they are lost. Currently the compiler emits wrong offset, so the debugger is completely confused and displays "no source location" when such exception occurs.

     The fix is to remove a synthesized "nop" instruction that was incorrectly used to track the catch handler IL offset. Instead mark the synthesized BoundCatchHandler node by a flag and create the IL marker in the CodeGen when emitting instructions for such bound node.

     Affects both C# and VB.

     Fixes bug 1114809. (changeset 1405564)

Add LambdaExpressionSyntax node as an abstract base class of SimpleLambdaExpression, ParenthesizedLambdaExpression.
Add AnonymousFunctionExpression as an abstract base class of LambdaExpressionSyntax and AnonymousMethodExpression.
 (changeset 1405438)

Brace matching has code to check for matching spans left of the caret - to deal with cases like {$$()}. We need to protect against negative numbers when caret is at position 0. (changeset 1405386)

 (changeset 1405366)

***NO_CI***
 (changeset 1405238)

Background:

As discussed in the dev team all hands all code under the GitHub dotnet foundation is using a single process for contribution, API review, infrastructure and coding style. The idea is to present a unified view to our customer and give them a single story for contributing to any project under the dotnet foundation.

https://github.com/dotnet/corefx/wiki/Contributing#c-coding-style

The coding style transition is automated using a Roslyn based rewrite tool:

https://github.com/dotnet/codeformatter

This will be applied in stages across our developer tree. Right now the focus is on the Open directory as this is what is being presented on github. Code owners will be contacted before the transition happens.

Note: this is a soft style requirement. There are no build errors that come from this change. (changeset 1405126)

Fix a bug in the adjusted Color Color code that failed to correctly account for instance members on base types.
***NO_CI***
 (changeset 1404916)

We haven't calculated variable slot mapping when only whitespace/comments were updated in an active method. As a result the values of local variables were often lost after the update.

This changeset creates syntax map for such an edit.
Fixes RC bug 1113015. (changeset 1404723)

After some discussion between Neal, Sri and myself we decided to make AsyncQueue<T> and CompilationEvent internal. The justification for this was:

- At the time there is no need for this type to be public. Ideally the IDE and Compiler would be structured in a way that making it public was needed but for now it is not done that way.
- AsyncQueue<T> feels like a type which should be in BCL, not Roslyn.
- No concrete need for making this public at the moment.

Given that we decided to make it internal for now. One of the main hopes here is we can convince the BCL to take ownership of the AsyncQueue<T>. If we make it public now, even if they add such a type we'd never get to consume it.
 (changeset 1404591)

Creating one nuget package for FxCopAnalyzers that contains both C# and VB and an update install script that knows to install the right analyzer for the target right target project.

Creating a similar package for CodeAnalysis analyzers. Adding a dependency to this package from the CodeAnalysis.Common package so that any time a codeanalysis nuget is installed, the analyzers are installed as well.
 (changeset 1404420)

Updating readme links for CTP5

Fixing another typo.

Added a space after the "5" in CTP 5.  Corrected a mistype to say "CTP
5" instead of "Preview"

   (changeset 1403790)

These were accidentally changed to UTF-16LE during a recent scripted change.  This went unnoticed because the encoding change didn't register in CodeFlow (indeed if you view a shelve of this change in CodeFlow it will report no changes).  UTF-16 does not work well with Git as it is often interpreted as a binary file.  Moving back to UTF-8 so our GitHub experience works well for customers.

closes #66 (changeset 1403787)

made builtin analyzer exception to be treated like other analyzer exception except it log the exception using non-fatal-watson (changeset 1403750)

Changes the 4.0+ lock statement IL pattern to improve debugging experience and to match VB compiler. Previously “restarting” the lock by dragging IP to the lock() statement header didn’t reset “lockTaken” flag and Monitor.Enter threw an exception.
Fixes bug 767299.
 (changeset 1403711)

Before this change, Roslyn used a slightly different Color Color rule for Visual Basic than the Dev12 compiler. Where the Dev12 compiler's rules would never result in an unresolvable ambiguity, the Roslyn compiler's could, particularly if the LHS required late binding or had errors. The Color Color rules have been therefore been adjusted to make decisions in the same manner as Dev12 for late-bound cases (where we must be compatible). The new rules are given below.

If the base expression of a member access expression is a simple name and binds to a constant, field, property, local variable or parameter whose type has the same name, then the base expression can refer either to the member or the type. This can never result in ambiguity because the members that can be accessed off of either one are the same.

In the case that such a base expression binds to an instance member but the binding occurs within a context in which "Me" is not accessible, the expression instead binds to the type (if applicable).

If the base expression cannot be successfully disambiguated by the context in which it occurs, it binds to the member. This can occur in particular in late-bound calls or error conditions.
***NO_CI***
 (changeset 1403686)

Adds target type conversions for VB interpolated string expressions to allow them to be converted to IFormattable or FormattableString instances. (changeset 1403673)

Background:

As discussed in the dev team all hands all code under the GitHub dotnet foundation is using a single process for contribution, API review, infrastructure and coding style. The idea is to present a unified view to our customer and give them a single story for contributing to any project under the dotnet foundation.

https://github.com/dotnet/corefx/wiki/Contributing#c-coding-style

The coding style transition is automated using a Roslyn based rewrite tool:

https://github.com/dotnet/codeformatter

This will be applied in stages across our developer tree. Right now the focus is on the Open directory as this is what is being presented on github. Code owners will be contacted before the transition happens.

Note: this is a soft style requirement. There are no build errors that come from this change.
 (changeset 1403394)

It turns out the code in Solution Explorer to calculate the effective severity for a diagnostic (and thus show the correct icon) was using the diagnostic's enabled-by-default flag and the compilation's general diagnostic option in the wrong way.

If a diagnostic is disabled by default, then the only thing that can turn it on is a specific diagnostic option, not the general diagnostic option. Also, the general diagnostic option can only turn a warning into an error, or suppress a warning or info. (changeset 1403379)